Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0016796Openbravo ERP09. Financial managementpublic2011-04-13 15:472011-06-27 12:57
Reporterrgoris 
Assigned Tomirurita 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version3.0RC5 
Target Version3.0MP2Fixed in Versionpi 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0016796: User is not aware that bank statements cannot be imported without the proper modules installed
DescriptionNow, when trying to Import a bank statement when in financial account, the user is left to her own devices to figure out that she first needs to install a "bank statement format importer" module, such as cuaderno 43 or OFX in order to be able to import the bank statement file. This is not cool as the user can proceed selecting a file (any format) just to later receive an error.

it is also a missed upsell opportunity into Basic Edition.
Steps To Reproduce
Proposed SolutionOn click on the Import Bank Statement button, the user receives a warning that there are no import-modules installed. Explain also where and how to do it. Once there (at module management or Exchange) the user will realize soon enough that she needs to have Basic Edition to install OFX or c43 etc.

See image for solution proposal.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0016828 closed mirurita User is not aware that bank statements cannot be imported without the proper modules installed 
Attached Filespng InstallImportModule.png (63,788) 2011-04-13 15:47
https://issues.openbravo.com/file_download.php?file_id=3871&type=bug
png

png warningBad.png (62,880) 2011-05-03 14:45
https://issues.openbravo.com/file_download.php?file_id=3933&type=bug
png

png warningGood.png (60,085) 2011-05-03 14:46
https://issues.openbravo.com/file_download.php?file_id=3934&type=bug
png

png WarningNoFileImportExtInstalled.png (63,418) 2011-05-17 12:35
https://issues.openbravo.com/file_download.php?file_id=4018&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2011-04-13 15:47rgorisNew Issue
2011-04-13 15:47rgorisAssigned To => dalsasua
2011-04-13 15:47rgorisFile Added: InstallImportModule.png
2011-04-13 15:47rgorisModules => Core
2011-04-13 15:47rgorisOBNetwork customer => No
2011-04-13 16:01dalsasuaAssigned Todalsasua => mirurita
2011-04-13 16:02dalsasuaModulesCore => Advanced Payables and Receivables Mngmt
2011-04-13 16:02dalsasuaSummaryUser is not aware that she cannot import bank statements without the proper modules installed => User is not aware that bank statements cannot be imported without the proper modules installed
2011-04-15 14:51miruritaStatusnew => scheduled
2011-04-15 14:51miruritafix_in_branch => pi
2011-04-26 09:55hgbotCheckin
2011-04-26 09:55hgbotNote Added: 0036078
2011-04-26 09:55hgbotStatusscheduled => resolved
2011-04-26 09:55hgbotResolutionopen => fixed
2011-04-26 09:55hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/11053ddb29cd67ffe72c8997a297d2acb1fc6c41 [^]
2011-05-03 14:45rgorisFile Added: warningBad.png
2011-05-03 14:46rgorisFile Added: warningGood.png
2011-05-03 14:48rgorisNote Added: 0036317
2011-05-03 14:48rgorisStatusresolved => new
2011-05-03 14:48rgorisResolutionfixed => open
2011-05-12 13:26hudsonbotCheckin
2011-05-12 13:26hudsonbotNote Added: 0036765
2011-05-12 17:14rgorisTarget Version => 3.0MP0
2011-05-12 17:14rgorisfix_in_branchpi =>
2011-05-17 12:35rgorisFile Added: WarningNoFileImportExtInstalled.png
2011-05-17 12:36rgorisNote Added: 0037066
2011-05-17 12:36rgorisStatusnew => scheduled
2011-05-17 15:20rgorisTarget Version3.0MP0 => 3.0MP1
2011-06-22 19:57dmitry_mezentsevTarget Version3.0MP1 => 3.0MP2
2011-06-23 10:22hgbotCheckin
2011-06-23 10:22hgbotNote Added: 0038512
2011-06-23 10:22hgbotStatusscheduled => resolved
2011-06-23 10:22hgbotResolutionopen => fixed
2011-06-23 10:22hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/11053ddb29cd67ffe72c8997a297d2acb1fc6c41 [^] => http://code.openbravo.com/erp/devel/pi/rev/c399ea037d580b755709c9129d222dccf5668e5d [^]
2011-06-23 15:03hudsonbotCheckin
2011-06-23 15:03hudsonbotNote Added: 0038514
2011-06-27 11:36rgorisNote Added: 0038533
2011-06-27 12:27miruritaNote Added: 0038534
2011-06-27 12:57rgorisStatusresolved => closed
2011-06-27 12:57rgorisFixed in Version => pi

Notes
(0036078)
hgbot   
2011-04-26 09:55   
Repository: erp/devel/pi
Changeset: 11053ddb29cd67ffe72c8997a297d2acb1fc6c41
Author: Mikel Irurita <mikel.irurita <at> openbravo.com>
Date: Fri Apr 15 14:51:26 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/11053ddb29cd67ffe72c8997a297d2acb1fc6c41 [^]

Fixes issue 16796: show message when no import bank file modules are installed

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MESSAGE.xml
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/ImportBankFile.java
---
(0036317)
rgoris   
2011-05-03 14:48   
The solution that was built uses a 2.50 style warning message bar. If you choose to use a message inside the popup window then a 3.0 style message bar should be used. See images attached.

Alternatively (which I prefer) the user is not allowed at all to import files so this popup never appears. In this case the warning message appears on top of the form or grid (just as any other message).
(0036765)
hudsonbot   
2011-05-12 13:26   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c40e579fcd38 [^]

Maturity status: Test
(0037066)
rgoris   
2011-05-17 12:36   
I have added a last image showing the ideal solution which is consistent with overall ob3 behavior.
(0038512)
hgbot   
2011-06-23 10:22   
Repository: erp/devel/pi
Changeset: c399ea037d580b755709c9129d222dccf5668e5d
Author: Mikel Irurita <mikel.irurita <at> openbravo.com>
Date: Thu Jun 23 10:20:37 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c399ea037d580b755709c9129d222dccf5668e5d [^]

Fixes issue 16796: import bank statement info message

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/ImportBankFile.java
---
(0038514)
hudsonbot   
2011-06-23 15:03   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5614633d86ea [^]

Maturity status: Test
(0038533)
rgoris   
2011-06-27 11:36   
Looking good. One thing: would it be possible to not show the lightbox (popup) first before showing the message? Now the lightbox flashes for 1/10th of a second when pressing the Import Statement button.
(0038534)
mirurita   
2011-06-27 12:27   
As the button has a HTML mapping defined the (generated) popup skeleton is shown by default.
In the server logic the popup is closed returning the error message to the opener window. That's why you see the popup for a very short time.
I think we should live with this approach until platform provides a way of handling that.