Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0016775 | Openbravo ERP | A. Platform | public | 2011-04-12 17:27 | 2011-05-31 09:44 |
|
| Reporter | shuehner | |
| Assigned To | iperdomo | |
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | 3.0MP0 | Fixed in Version | | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0016775: index.jsp code related to Authentication manager not having same behavior then copy in HSAS |
| Description | When code in index.jsp does throw an exception if the configured authentication manager cannot be found.
The central code in HSAS, does log an error to the log and transparently (for the user) uses the DefaultAuthenticationManager instead of breaking the login.
Attached patch add the same error handling and also improves the error message in HSAS to more specifically point to the problem. |
| Steps To Reproduce | |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files |  16775.diff (1,912) 2011-04-12 17:28
https://issues.openbravo.com/file_download.php?file_id=3865&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2011-04-12 17:27 | shuehner | New Issue | |
| 2011-04-12 17:27 | shuehner | Assigned To | => alostale |
| 2011-04-12 17:27 | shuehner | Modules | => Core |
| 2011-04-12 17:28 | shuehner | File Added: 16775.diff | |
| 2011-04-12 17:28 | shuehner | Assigned To | alostale => iperdomo |
| 2011-04-12 18:35 | shuehner | Note Added: 0035871 | |
| 2011-05-02 10:47 | alostale | Status | new => scheduled |
| 2011-05-05 17:46 | dmitry_mezentsev | Note Added: 0036418 | |
| 2011-05-05 17:46 | dmitry_mezentsev | Target Version | 3.0RC7 => 3.0MP0 |
| 2011-05-27 17:45 | hgbot | Checkin | |
| 2011-05-27 17:45 | hgbot | Note Added: 0037677 | |
| 2011-05-27 17:45 | hgbot | Status | scheduled => resolved |
| 2011-05-27 17:45 | hgbot | Resolution | open => fixed |
| 2011-05-27 17:45 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/3bf5295a7f03f8de258c51e9e636e85d203a0a97 [^] |
| 2011-05-30 11:50 | iperdomo | Note Added: 0037708 | |
| 2011-05-30 11:50 | iperdomo | Status | resolved => closed |
| 2011-05-31 09:44 | hudsonbot | Checkin | |
| 2011-05-31 09:44 | hudsonbot | Note Added: 0037787 | |
|
Notes |
|
|
|
Note: even with that patch behavior is not optimal. HSAS code does log an error is auth-manager cannot be loaded. But that happen only after login using builtin classic login page.
We should check if we can log similar error directly from index.jsp or centralize both code-copies. |
|
|
|
|
|
|
|
(0037677)
|
|
hgbot
|
|
2011-05-27 17:45
|
|
Repository: erp/devel/pi
Changeset: 3bf5295a7f03f8de258c51e9e636e85d203a0a97
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Fri May 27 17:45:12 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/3bf5295a7f03f8de258c51e9e636e85d203a0a97 [^]
Fixed 16775: Improve error handling if defined authentication.manager is missing
In case the defined authentication.manager can't be loaded log an error message
and use the default one instead of crashing with ClassNotFoundException.
Also improve error message in that case pointing to config option in config file
---
M src/index.jsp
M src/org/openbravo/base/secureApp/HttpSecureAppServlet.java
---
|
|
|
|
|
Changes made by Stefan.
Tested in pi @ rev b1c830dd5ee0 |
|
|
|
|
|