Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0016685Openbravo ERPA. Platformpublic2011-04-07 12:462011-05-31 11:52
ReporterHexDump 
Assigned Tojpabloae 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Version 
Target VersionFixed in Version2.50MP30 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0016685: Test for JAVA_HOME should be placed after root test is done in build.xml
Description<target name="init" depends="code.rev">
    <fail if="no.java.home" message="The environment variable JAVA_HOME is not $
    <fail if="root.user" message="Don't run ant tasks with the root user" />
</target>

This should be set as:

<target name="init" depends="code.rev">
    <fail if="root.user" message="Don't run ant tasks with the root user" />
    <fail if="no.java.home" message="The environment variable JAVA_HOME is not $
</target>

The problem here are environment vars. On ubuntu I had my java_home, etc... in /etc/environment. This seems not to be exported when going super user, so, I was getting an error saying that JAVA_HOME was not set, but it would have been much more better to flag that root account should not be used.

Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0016684 closed jpabloae Test for JAVA_HOME should be placed after root test is done in build.xml 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-04-07 12:49iperdomoTypedefect => backport
2011-04-07 12:49iperdomofix_in_branch => 2.50
2011-04-07 12:51iperdomoAssigned Toiperdomo => jpabloae
2011-04-07 12:56hgbotCheckin
2011-04-07 12:56hgbotNote Added: 0035728
2011-04-07 12:56hgbotStatusscheduled => resolved
2011-04-07 12:56hgbotResolutionopen => fixed
2011-04-07 12:56hgbotFixed in SCM revision => http://code.openbravo.com/erp/stable/2.50/rev/b4b65665f2f1e62f4fdaaf0c01360f0d2ca84eba [^]
2011-05-31 11:52gorka_gilNote Added: 0037820
2011-05-31 11:52gorka_gilStatusresolved => closed
2011-05-31 11:52gorka_gilFixed in Version => 2.50MP30

Notes
(0035728)
hgbot   
2011-04-07 12:56   
Repository: erp/stable/2.50
Changeset: b4b65665f2f1e62f4fdaaf0c01360f0d2ca84eba
Author: Juan Pablo Aroztegi <juanpablo.aroztegi <at> openbravo.com>
Date: Thu Apr 07 12:55:31 2011 +0200
URL: http://code.openbravo.com/erp/stable/2.50/rev/b4b65665f2f1e62f4fdaaf0c01360f0d2ca84eba [^]

Fixes 16685: swap the order in the root.user and no.java.home checks.

Some Linux systems don't have JAVA_HOME set for the root user.
When a user runs ant commands in these cases they get an
error about the JAVA_HOME not being set, but the real cause
is that they're running the command as root. Hence the order
swapping.

---
M build.xml
---
(0037820)
gorka_gil   
2011-05-31 11:52   
Verified.