Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0016639Openbravo ERPA. Platformpublic2011-04-05 11:102011-06-10 19:38
alostale 
thirumalaik 
normalminoralways
closedfixed 
5
 
 
Core
No
0016639: Exclude column from audit
Audit trail is defined at table level. When a table is marked to be audited any change within it is stored in the audit trail. Sometimes there are tables to be audited with columns that doesn't make sense to keep.
-By default, when a table is audited all its columns should be audited
-Add an exclude audit field to ad_column, when it is checked, this column is excluded from audit.
contrib
related to defect 00167063.0MP2 closed alostale Deletion not properly audited (missing window) 
related to defect 00167603.0MP3 closed jecharri Show audit info button is cached 
related to defect 0017609 acknowledged Triage Platform Base Code-review for issue: 16639 
Issue History
2011-04-05 11:10alostaleNew Issue
2011-04-05 11:10alostaleAssigned To => alostale
2011-04-05 11:10alostaleModules => Core
2011-04-05 11:10alostaleTag Attached: contrib
2011-04-05 11:10alostaleStatusnew => scheduled
2011-04-05 11:10alostaleAssigned Toalostale => thirumalaik
2011-04-05 11:10alostalefix_in_branch => pi
2011-04-07 18:11alostaleRelationship addedrelated to 0016706
2011-04-12 11:55alostaleRelationship addedrelated to 0016760
2011-04-20 11:38hgbotCheckin
2011-04-20 11:38hgbotNote Added: 0036041
2011-04-20 11:38hgbotStatusscheduled => resolved
2011-04-20 11:38hgbotResolutionopen => fixed
2011-04-20 11:38hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0b7613b265ef5ea23a65cf0f2d8f8a758df66d87 [^]
2011-04-20 11:38hgbotCheckin
2011-04-20 11:38hgbotNote Added: 0036042
2011-04-20 11:38hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/0b7613b265ef5ea23a65cf0f2d8f8a758df66d87 [^] => http://code.openbravo.com/erp/devel/pi/rev/41dfd35d8c246889c4f4ab8496b9bbf9bc0e3e76 [^]
2011-05-12 13:26hudsonbotCheckin
2011-05-12 13:26hudsonbotNote Added: 0036751
2011-05-12 13:26hudsonbotCheckin
2011-05-12 13:26hudsonbotNote Added: 0036752
2011-06-10 19:34shuehnerRelationship addedrelated to 0017609
2011-06-10 19:38shuehnerNote Added: 0038266
2011-06-10 19:38shuehnerStatusresolved => closed

Notes
(0036041)
hgbot   
2011-04-20 11:38   
Repository: erp/devel/pi
Changeset: 0b7613b265ef5ea23a65cf0f2d8f8a758df66d87
Author: Thirumalai Kandasami <thirumalai <at> qualian.in>
Date: Thu Apr 07 20:11:29 2011 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/0b7613b265ef5ea23a65cf0f2d8f8a758df66d87 [^]

Fixed issue 16639:Exclude column from audit

---
M src-db/database/model/postscript-Oracle.sql
M src-db/database/model/postscript-PostgreSql.sql
M src-db/database/model/tables/AD_COLUMN.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_DATASET_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/erpCommon/ad_callouts/SL_TableAudit.java
---
(0036042)
hgbot   
2011-04-20 11:38   
Repository: erp/devel/pi
Changeset: 41dfd35d8c246889c4f4ab8496b9bbf9bc0e3e76
Author: Thirumalai Kandasami <thirumalai <at> qualian.in>
Date: Mon Apr 18 20:12:01 2011 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/41dfd35d8c246889c4f4ab8496b9bbf9bc0e3e76 [^]

Fixed issue 16639:Exclude column from Audit trail

---
M src-db/database/model/triggers/AD_COLUMN_MOD_TRG.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/erpCommon/businessUtility/AuditTrailPopup.java
M src/org/openbravo/erpCommon/businessUtility/AuditTrailPopupDeleted.html
M src/org/openbravo/erpCommon/businessUtility/AuditTrailPopupDeleted.xml
M src/org/openbravo/erpCommon/businessUtility/AuditTrailPopupHistory.html
M src/org/openbravo/erpCommon/businessUtility/AuditTrailPopupHistory.xml
---
(0036751)
hudsonbot   
2011-05-12 13:26   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c40e579fcd38 [^]

Maturity status: Test
(0036752)
hudsonbot   
2011-05-12 13:26   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c40e579fcd38 [^]

Maturity status: Test
(0038266)
shuehner   
2011-06-10 19:38   
Reviewed+test on pi-mp0 (rev: bc96d042bfeb). Functionality works correctly and allows excluding individual columns from being fully audited for tables marked as such. AuditTrailPopup shows a hint in the message area to notify the user of those columns. However if older audit data includes those columns that data is still displayed (ok).
A few technical issues found in reviewing the code changes have been logged as a new issue (17609).