0016635: If a module that contains a module script is uninstalled, this module script is not uninstalled and it is executed

Openbravo Issue Tracking System - Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0016635

Modules

Central Repository

public

2011-04-04 17:30

2014-04-01 21:46

Reporter

adrianromero

Assigned To

alostale

Priority

normal

Severity

major

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Regression date

Regression introduced by commit

Regression level

Review Assigned To

Support ticket

OBNetwork customer

Regression introduced in release

Summary

0016635: If a module that contains a module script is uninstalled, this module script is not uninstalled and it is executed

Description

When uninstalling a module that contains a module script, the classes that contains the logic of this module script are not removed and are executed when compiling the application. This is wrong because the module is not installed any longer.

Steps To Reproduce

This can be tested with the IDL 3.0.0 that contains a module script. This is a sequence that raises this problem:

1.- Install a new Openbravo ERP 3.0
2.- Install IDL

Result:
Process completed successfully
Module successfully installed Initial Data Load - 3.0.0
This module installs a module script in the following location:

src-util/modulescript/src/src/org/openbravo/idl/modulescript/RemoveOldIDLEntitiesData.java

3.- Install IDL 4 java

Result
Process completed successfully
Module successfully installed Initial Data Load Extension for Java - 1.0.0
Module successfully installed Initial Data Load - 1.1.8

The IDL has been downgraded to version 1.1.8 (To fix the dependencies of the IDL 4 java is already another issue that must be resolved indepentently) but the module script of 3.0.0 is still installed which is wrong.
src-util/modulescript/src/src/org/openbravo/idl/modulescript/RemoveOldIDLEntitiesData.java

5.- execute ant smartbuild -Dlocal=no

An error is raised because of the module script:

         [java] 208870 WARN - SQL Command failed with: ERROR: inserción o actualización en la tabla «idl_fields» viola la llave foránea «idl_field_entities»
         [java] Detail: La llave (idl_entities_id)=(FF80818124241FE0012424493CA7005A) no está presente en la tabla «idl_entities».
         [java] 208904 WARN - -- END
         [java] ALTER TABLE IDL_FIELDS
         [java] ADD CONSTRAINT IDL_FIELD_ENTITIES FOREIGN KEY (IDL_ENTITIES_ID) REFERENCES IDL_ENTITIES (IDL_ENTITIES_ID)

Proposed Solution

Additional Information