Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0016619Openbravo ERPB. User interfacepublic2011-04-02 13:072011-05-13 18:45
Reportericiordia 
Assigned Toiperdomo 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Versionany
Product Versionpi 
Target Version3.0RC7Fixed in Version3.0RC7 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0016619: Idle space in Sales Invoice window
DescriptionIn some cases (I guess related to not displayed fields) the system inserts some blank rows in the form (see payment monitor section in the attached file). If you colapse that section it is even worse
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00170923.0RC7 closed alostale Sections that are collapsed disappear when you maximize the child tab 
related to defect 0019378 closed dbaz Hidden sections take space 
Attached Filespng blankSpace.png (58,785) 2011-04-02 13:07
https://issues.openbravo.com/file_download.php?file_id=3816&type=bug
png

png space.png (65,820) 2011-05-02 14:36
https://issues.openbravo.com/file_download.php?file_id=3925&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2011-04-02 13:07iciordiaNew Issue
2011-04-02 13:07iciordiaAssigned To => iperdomo
2011-04-02 13:07iciordiaFile Added: blankSpace.png
2011-04-02 13:07iciordiaModules => Core
2011-04-04 09:19rgorisNote Added: 0035502
2011-04-05 10:30alostaleStatusnew => scheduled
2011-04-05 12:37hgbotCheckin
2011-04-05 12:37hgbotNote Added: 0035595
2011-04-05 12:37hgbotStatusscheduled => resolved
2011-04-05 12:37hgbotResolutionopen => fixed
2011-04-05 12:37hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ba863d26907fd25b10aa3469f9d420ff3136214f [^]
2011-04-08 17:24marvintmStatusresolved => closed
2011-04-09 00:00anonymoussf_bug_id0 => 3281276
2011-05-02 14:36rgorisNote Added: 0036262
2011-05-02 14:36rgorisStatusclosed => new
2011-05-02 14:36rgorisResolutionfixed => open
2011-05-02 14:36rgorisFile Added: space.png
2011-05-02 14:36rgorisTarget Version3.0RC6 => 3.0RC7
2011-05-02 16:44iperdomoStatusnew => scheduled
2011-05-02 16:44iperdomofix_in_branch => pi
2011-05-03 17:08iperdomoNote Added: 0036323
2011-05-03 17:37hgbotCheckin
2011-05-03 17:37hgbotNote Added: 0036324
2011-05-03 17:37hgbotStatusscheduled => resolved
2011-05-03 17:37hgbotResolutionopen => fixed
2011-05-03 17:37hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/ba863d26907fd25b10aa3469f9d420ff3136214f [^] => http://code.openbravo.com/erp/devel/pi/rev/adc02724e7d6cbc89a2c03d9a4778760728694ae [^]
2011-05-05 11:29hgbotCheckin
2011-05-05 11:29hgbotNote Added: 0036389
2011-05-11 09:25alostaleRelationship addedrelated to 0017092
2011-05-12 13:28hudsonbotCheckin
2011-05-12 13:28hudsonbotNote Added: 0036806
2011-05-12 13:30hudsonbotCheckin
2011-05-12 13:30hudsonbotNote Added: 0036824
2011-05-13 10:44hgbotCheckin
2011-05-13 10:44hgbotNote Added: 0036957
2011-05-13 10:44hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/adc02724e7d6cbc89a2c03d9a4778760728694ae [^] => http://code.openbravo.com/erp/devel/pi/rev/310c45e82c0d934ab7e7b6f57d28e7a1e314f10d [^]
2011-05-13 14:09dbazStatusresolved => closed
2011-05-13 14:09dbazFixed in Version => 3.0RC7
2011-05-13 18:45hudsonbotCheckin
2011-05-13 18:45hudsonbotNote Added: 0036983
2011-12-27 22:46dbazRelationship addedrelated to 0019378

Notes
(0035502)
rgoris   
2011-04-04 09:19   
same as: https://www.pivotaltracker.com/story/show/9419727 [^]
(0035595)
hgbot   
2011-04-05 12:37   
Repository: erp/devel/pi
Changeset: ba863d26907fd25b10aa3469f9d420ff3136214f
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Tue Apr 05 12:36:49 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ba863d26907fd25b10aa3469f9d420ff3136214f [^]

Fixes issue 16619: Updates form item alwaysTakeSpace when collapsing/expanding
- The alwaysTakeSpace flag controls if the item will always take space even if
    is not displayed. When set to true, and you collapse a section, the space is
    still occupied by the item(s)

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-formitem-widgets.js
---
(0036262)
rgoris   
2011-05-02 14:36   
Problem seem to have returned or was not solved entirely. See image attached.
(0036323)
iperdomo   
2011-05-03 17:08   
@rgoris:
The space you are showing is a different issue (but related). In this case, the section contains several fields, but because of display-logic is applied, are not shown.

I'll push a change to not show sections when all the fields that belongs to it are not visible
(0036324)
hgbot   
2011-05-03 17:37   
Repository: erp/devel/pi
Changeset: adc02724e7d6cbc89a2c03d9a4778760728694ae
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Tue May 03 17:37:06 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/adc02724e7d6cbc89a2c03d9a4778760728694ae [^]

Fixes issue 16619: Hide sections where all fields are not visible

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-formitem-widgets.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-view-form.js
---
(0036389)
hgbot   
2011-05-05 11:29   
Repository: erp/devel/pi
Changeset: d2c32038b8ef2fa6ef3f84f032aed828f6373f00
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu May 05 11:28:28 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d2c32038b8ef2fa6ef3f84f032aed828f6373f00 [^]

related to issu 1657: Show audit in form after issue 16619

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/templates/ob-view-field.js.ftl
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewFormComponent.java
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-formitem-widgets.js
---
(0036806)
hudsonbot   
2011-05-12 13:28   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c40e579fcd38 [^]

Maturity status: Test
(0036824)
hudsonbot   
2011-05-12 13:30   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c40e579fcd38 [^]

Maturity status: Test
(0036957)
hgbot   
2011-05-13 10:44   
Repository: erp/devel/pi
Changeset: 310c45e82c0d934ab7e7b6f57d28e7a1e314f10d
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Fri May 13 10:42:25 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/310c45e82c0d934ab7e7b6f57d28e7a1e314f10d [^]

Fixes issue 16619: Handle alwaysTakeSpace for HiddenItems

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-formitem-widgets.js
---
(0036983)
hudsonbot   
2011-05-13 18:45   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/84da0073d386 [^]

Maturity status: Test