Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0016582Openbravo ERPA. Platformpublic2011-03-31 11:522011-04-07 00:00
Reporterplujan 
Assigned Tomarvintm 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0RC6Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0016582: Combo filling is not working as expected in Open Close periods
DescriptionWhen opening the Open Close periods, the Until Period combo does not correspond with the Year value. See attach.
Steps To Reproduce1. Use a context with a Fiscal Calendar and at least three years (2009, 2010 and 2011), and with all the 12 periods created for those years
2. Go to Open Close periods window. When you open the window, the Year combo has a value (let's say 2011), and the Until Period has periods for a different one (let's say 2010). See attach.
3. Change Year value to 2009. Now the values in the other field are the proper ones.
4. Change Year value back to 2011. Now the values in the other field are correct as well.
Proposed SolutionWhen opening the window, the same rules used when changing values in the combo should be applied.
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng clientAndOrganizationShouldBeSetUp.png (50,370) 2011-03-31 11:52
https://issues.openbravo.com/file_download.php?file_id=3803&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2011-03-31 11:52plujanNew Issue
2011-03-31 11:52plujanAssigned To => marvintm
2011-03-31 11:52plujanFile Added: clientAndOrganizationShouldBeSetUp.png
2011-03-31 11:52plujanModules => Core
2011-03-31 12:25hgbotCheckin
2011-03-31 12:25hgbotNote Added: 0035411
2011-03-31 12:25hgbotStatusnew => resolved
2011-03-31 12:25hgbotResolutionopen => fixed
2011-03-31 12:25hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f5c8f4c9f1de20c9fd17bc30c2904ded7e23cacd [^]
2011-03-31 12:26hgbotCheckin
2011-03-31 12:26hgbotNote Added: 0035412
2011-04-01 16:30hgbotCheckin
2011-04-01 16:30hgbotNote Added: 0035475
2011-04-01 20:46plujanNote Added: 0035487
2011-04-01 20:46plujanStatusresolved => new
2011-04-01 20:46plujanResolutionfixed => open
2011-04-01 20:46plujanStatusnew => scheduled
2011-04-01 20:46plujanfix_in_branch => pi
2011-04-04 09:41hgbotCheckin
2011-04-04 09:41hgbotNote Added: 0035507
2011-04-04 09:41hgbotStatusscheduled => resolved
2011-04-04 09:41hgbotResolutionopen => fixed
2011-04-04 09:41hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/f5c8f4c9f1de20c9fd17bc30c2904ded7e23cacd [^] => http://code.openbravo.com/erp/devel/pi/rev/dc283db4f5f62db328f8eb19ca0024c1412f15b5 [^]
2011-04-06 19:11iperdomoNote Added: 0035682
2011-04-06 19:11iperdomoStatusresolved => closed
2011-04-07 00:00anonymoussf_bug_id0 => 3278060

Notes
(0035411)
hgbot   
2011-03-31 12:25   
Repository: erp/devel/pi
Changeset: f5c8f4c9f1de20c9fd17bc30c2904ded7e23cacd
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Mar 31 12:18:08 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f5c8f4c9f1de20c9fd17bc30c2904ded7e23cacd [^]

Fixed issue 16582. Two main things have been changed in the FIC:
- runCallouts will now return a list of changed columns instead of whether a comboreload is necessary.
- The subsequent combo reload will now only compute the columns which depend on the changed columns instead of all the columns. This is done for two reasons: a subordinated combo (fed by a callout instead of combotabledata) would not work if a full combo reload is done always (ex. Payment Out window), and some combos rely on combo reload to work correctly (ex. Open/Close period control)

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java
---
(0035412)
hgbot   
2011-03-31 12:26   
Repository: erp/devel/pi
Changeset: 704efebf5095d74aae524a6f05de4cfa80d6c27c
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Mar 31 12:23:24 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/704efebf5095d74aae524a6f05de4cfa80d6c27c [^]

Related to issue 16582. Remove unnecessary parameters.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java
---
(0035475)
hgbot   
2011-04-01 16:30   
Repository: erp/devel/pi
Changeset: 116849a2c4b43199790414ccf1678ef960f555e8
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Fri Apr 01 16:29:43 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/116849a2c4b43199790414ccf1678ef960f555e8 [^]

Related to issue 16582. When a callout returns a combo, its values will be used even if no row is selected.
In that case, the first element will be selected by default.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java
---
(0035487)
plujan   
2011-04-01 20:46   
In current smoke executions, the same issue could be reproduced.
(0035507)
hgbot   
2011-04-04 09:41   
Repository: erp/devel/pi
Changeset: dc283db4f5f62db328f8eb19ca0024c1412f15b5
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon Apr 04 09:39:57 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/dc283db4f5f62db328f8eb19ca0024c1412f15b5 [^]

Fixed issue 16582 . When a callout changes a combo, the new value will be set in the request so that subsequent callouts work correctly.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java
---
(0035682)
iperdomo   
2011-04-06 19:11   
Tested on pi @ rev 0e1a6b0259c3