Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0016572Openbravo ERPA. Platformpublic2011-03-31 09:442011-06-03 13:26
Reporterrgoris 
Assigned Tomarvintm 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP0Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0016572: OPTIMIZE-05: Rename context menu items
DescriptionA few changes:
- renamed "New record in grid" to "Insert row Ctrl+i"
- add "Clone record" to the menu, place it below "Insert row"
- change all words to lower case except for the first word
- add the keyboard shortcuts where possible (right aligned)

NOTE: check with latest status in shortcuts and add them.
Steps To Reproduce
Proposed SolutionPage 8 in the pdf
Additional Information
TagsNo tags attached.
Relationships
Attached Filespdf Flow Optima V2.pdf (2,655,522) 2011-03-31 09:44
https://issues.openbravo.com/file_download.php?file_id=3798&type=bug
png KS-Context.png (10,825) 2011-05-31 10:21
https://issues.openbravo.com/file_download.php?file_id=4129&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2011-03-31 09:44rgorisNew Issue
2011-03-31 09:44rgorisAssigned To => alostale
2011-03-31 09:44rgorisFile Added: Flow Optima V2.pdf
2011-03-31 09:44rgorisModules => Core
2011-04-08 13:40rgorisTarget Version => 3.0RC7
2011-04-08 13:42rgorisStatusnew => scheduled
2011-04-08 13:42rgorisNote Added: 0035774
2011-04-08 13:51rgorisTypefeature request => defect
2011-05-10 13:35dmitry_mezentsevNote Added: 0036625
2011-05-10 13:35dmitry_mezentsevTarget Version3.0RC7 => 3.0MP0
2011-05-17 09:15iperdomoPriorityurgent => normal
2011-05-17 09:16iperdomoPrioritynormal => urgent
2011-05-19 11:57rgorisAssigned Toalostale => marvintm
2011-05-24 12:13rgorisPriorityurgent => normal
2011-05-24 12:13rgorisDescription Updatedbug_revision_view_page.php?rev_id=2094#r2094
2011-05-25 17:42rgorisNote Added: 0037442
2011-05-25 17:42rgorisDescription Updatedbug_revision_view_page.php?rev_id=2110#r2110
2011-05-25 17:42rgorisDescription Updatedbug_revision_view_page.php?rev_id=2111#r2111
2011-05-30 12:42rgorisNote Added: 0037716
2011-05-30 16:23hgbotCheckin
2011-05-30 16:23hgbotNote Added: 0037743
2011-05-30 16:23hgbotStatusscheduled => resolved
2011-05-30 16:23hgbotResolutionopen => fixed
2011-05-30 16:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e8dcd653fb6fcd0c56aabbda4bc69bf4f5140461 [^]
2011-05-31 09:45hudsonbotCheckin
2011-05-31 09:45hudsonbotNote Added: 0037802
2011-05-31 10:17rgorisFile Added: KS-Context.png
2011-05-31 10:18rgorisNote Added: 0037808
2011-05-31 10:18rgorisStatusresolved => new
2011-05-31 10:18rgorisResolutionfixed => open
2011-05-31 10:20rgorisFile Deleted: KS-Context.png
2011-05-31 10:21rgorisFile Added: KS-Context.png
2011-05-31 10:21rgorisNote Edited: 0037808bug_revision_view_page.php?bugnote_id=0037808#r2148
2011-05-31 12:35rgorisStatusnew => scheduled
2011-05-31 12:35rgorisNote Added: 0037824
2011-05-31 12:36rgorisfix_in_branch => pi
2011-05-31 18:01hgbotCheckin
2011-05-31 18:01hgbotNote Added: 0037839
2011-06-01 10:40hgbotCheckin
2011-06-01 10:40hgbotNote Added: 0037870
2011-06-01 10:43marvintmNote Added: 0037871
2011-06-01 10:43marvintmStatusscheduled => resolved
2011-06-01 10:43marvintmResolutionopen => fixed
2011-06-01 12:07rgorisStatusresolved => closed
2011-06-03 13:26hudsonbotCheckin
2011-06-03 13:26hudsonbotNote Added: 0037967
2011-06-03 13:26hudsonbotCheckin
2011-06-03 13:26hudsonbotNote Added: 0037978

Notes
(0035774)
rgoris   
2011-04-08 13:42   
As per discussion with Psarobe we have put these issues forward to RC7 due to business partner´s requests.
(0036625)
dmitry_mezentsev   
2011-05-10 13:35   
Does not fit RC7.
(0037442)
rgoris   
2011-05-25 17:42   
Since that we have the clone functionality we must add "Clone record" to the context menu.
(0037716)
rgoris   
2011-05-30 12:42   
Re: last comment after discussion with Marvintm: We can wait till clone is available for all document types in the future.
So you can leave it for now.
(0037743)
hgbot   
2011-05-30 16:23   
Repository: erp/devel/pi
Changeset: e8dcd653fb6fcd0c56aabbda4bc69bf4f5140461
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon May 30 15:12:42 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e8dcd653fb6fcd0c56aabbda4bc69bf4f5140461 [^]

Fixed issue 16572. Done the following changes:
- Changed 'New record in grid'->'Insert row'
- Changed 'New record in grid' to 'Insert row'
- Changed upper case to lower case in the context menu items
- Added keyboard shortcuts to a couple of options in the context menu items

---
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0037802)
hudsonbot   
2011-05-31 09:45   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ea275e03a164 [^]

Maturity status: Test
(0037808)
rgoris   
2011-05-31 10:18   
(edited on: 2011-05-31 10:21)
Just a few details that aren´t good yet.

f2 must be F2 (uppercase F)
Ctrl+I must be Ctrl+i (lowercase i)
Ctrl+Delete is incorrect. It must be Del only.

See image attached.
(0037824)
rgoris   
2011-05-31 12:35   
as per notes for small changes
(0037839)
hgbot   
2011-05-31 18:01   
Repository: erp/devel/pi
Changeset: de85bb7ca07bedab92f61951e9d7360c15814178
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Tue May 31 18:00:55 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/de85bb7ca07bedab92f61951e9d7360c15814178 [^]

Related to issue 16572: Changed some keys name

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-keyboard-manager.js
---
(0037870)
hgbot   
2011-06-01 10:40   
Repository: erp/devel/pi
Changeset: 49ef0e8d7dbc5cbeee05ee26930ae6c41a9c4915
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Jun 01 10:38:09 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/49ef0e8d7dbc5cbeee05ee26930ae6c41a9c4915 [^]

Related to issue 16572. Added messages for key names

---
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-keyboard-manager.js
---
(0037871)
marvintm   
2011-06-01 10:43   
Last two commits should have fixed the remaining issues.
(0037967)
hudsonbot   
2011-06-03 13:26   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2a05e66b60ca [^]

Maturity status: Test
(0037978)
hudsonbot   
2011-06-03 13:26   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2a05e66b60ca [^]

Maturity status: Test