Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0016508Openbravo ERPA. Platformpublic2011-03-28 11:472011-06-01 12:07
Reporterrgoris 
Assigned Toiperdomo 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version3.0RC5 
Target Version3.0MP0Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0016508: Remove the light box at all times, the red message bar is enough.
DescriptionFor example when moving from header to lines when the header cannot be saved yet, the modal error message comes up. It is very harsh and redundant as there is also a red error message in the form/grid below.

So: We can take the modal error message out. It already works like this when changing tabs in case a new form was not saved yet. This is good. Now do the same for changing levels.

Prerequisite is that the red message should explain the why about the auto save.
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0016576 acknowledged Triage Platform Base OPTIMIZE-09: Extend "not being able to save" message 
related to defect 0031749 closed NaroaIriarte When a record is saving a warning is thrown, the message is not correct. 
Attached Filespng double-error.png (108,608) 2011-03-28 11:47
https://issues.openbravo.com/file_download.php?file_id=3766&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2011-03-28 11:47rgorisNew Issue
2011-03-28 11:47rgorisAssigned To => alostale
2011-03-28 11:47rgorisFile Added: double-error.png
2011-03-28 11:47rgorisModules => Core
2011-03-28 11:48rgorisIssue Monitored: rgoris
2011-03-28 11:48rgorisIssue End Monitor: rgoris
2011-03-28 11:48rgorisIssue Monitored: rgoris
2011-03-28 11:48rgorisIssue Monitored: psarobe
2011-05-02 20:46rgorisTypefeature request => defect
2011-05-02 20:47rgorisTarget Version3.0 => 3.0RC8
2011-05-05 09:10alostaleStatusnew => scheduled
2011-05-05 10:27gorka_gilTarget Version3.0RC8 => 3.0MP0
2011-05-17 09:15iperdomoPriorityhigh => normal
2011-05-24 12:15rgorisPrioritynormal => urgent
2011-05-26 16:26rgorisAssigned Toalostale => mtaal
2011-05-26 16:33mtaalNote Added: 0037611
2011-05-26 16:33mtaalStatusscheduled => feedback
2011-05-26 19:09rgorisNote Added: 0037626
2011-05-26 19:09rgorisStatusfeedback => scheduled
2011-05-26 19:09rgorisfix_in_branch => pi
2011-05-27 13:45rgorisRelationship addedrelated to 0016576
2011-05-30 11:29iperdomoAssigned Tomtaal => iperdomo
2011-05-30 11:49dmitry_mezentsevNote Added: 0037707
2011-05-30 12:13hgbotCheckin
2011-05-30 12:13hgbotNote Added: 0037713
2011-05-30 12:13hgbotStatusscheduled => resolved
2011-05-30 12:13hgbotResolutionopen => fixed
2011-05-30 12:13hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d222c0c7c6563680aa10faa45dee2fea8ff825e9 [^]
2011-05-31 09:45hudsonbotCheckin
2011-05-31 09:45hudsonbotNote Added: 0037797
2011-05-31 10:11rgorisNote Added: 0037806
2011-05-31 10:11rgorisStatusresolved => new
2011-05-31 10:11rgorisResolutionfixed => open
2011-05-31 10:12iperdomoStatusnew => scheduled
2011-05-31 14:06hgbotCheckin
2011-05-31 14:06hgbotNote Added: 0037829
2011-05-31 14:06hgbotStatusscheduled => resolved
2011-05-31 14:06hgbotResolutionopen => fixed
2011-05-31 14:06hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/d222c0c7c6563680aa10faa45dee2fea8ff825e9 [^] => http://code.openbravo.com/erp/devel/pi/rev/6f30131e9922a0e03c7eebf42817a1a2de167879 [^]
2011-05-31 21:36hudsonbotCheckin
2011-05-31 21:36hudsonbotNote Added: 0037858
2011-06-01 12:07rgorisStatusresolved => closed
2015-12-18 13:10NaroaIriarteRelationship addedrelated to 0031749

Notes
(0037611)
mtaal   
2011-05-26 16:33   
Problem is that the message in the red is the save failure reason and the message box is the auto-save message. The message in the red can not be changed directly, so the auto-save message should be added after the other one.

I am afraid that there is not enough space in the red bar to add the complete auto-save message.
(0037626)
rgoris   
2011-05-26 19:09   
Can´t we just say (in the red message):

"ERROR: Saving failed" -- and then the rest.

This makes sense as this error only occurs when there was a saving attempt.
(0037707)
dmitry_mezentsev   
2011-05-30 11:49   
Rob,

Could we please postpone it to MP1?
I agree that it is not nice but it is not sth that just does not work (and we have portion of such things).
(0037713)
hgbot   
2011-05-30 12:13   
Repository: erp/devel/pi
Changeset: d222c0c7c6563680aa10faa45dee2fea8ff825e9
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Mon May 30 12:11:32 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d222c0c7c6563680aa10faa45dee2fea8ff825e9 [^]

Fixes issue 16508: Removed light box on failed autosave

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-statusbar.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js
---
(0037797)
hudsonbot   
2011-05-31 09:45   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ea275e03a164 [^]

Maturity status: Test
(0037806)
rgoris   
2011-05-31 10:11   
As discussed over Skype with Ivan: We forgot to extend the message:

"ERROR: Saving failed" -- and then the rest.
(0037829)
hgbot   
2011-05-31 14:06   
Repository: erp/devel/pi
Changeset: 6f30131e9922a0e03c7eebf42817a1a2de167879
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Tue May 31 14:05:20 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6f30131e9922a0e03c7eebf42817a1a2de167879 [^]

Fixes issue 16508: Added -Saving failed- prefix to normal server reply

---
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-messagebar.js
---
(0037858)
hudsonbot   
2011-05-31 21:36   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b7e7d64488f5 [^]

Maturity status: Test