Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0016406Openbravo ERP01. General setuppublic2011-03-21 19:372012-03-02 15:39
ReporterXpand-IT 
Assigned Tomigueldejuana 
PrioritynormalSeveritytrivialReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0MP9 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0016406: External modules "Visit Site" link. Undefined links behaviour
DescriptionWhen the "Visit Site" link is not defined some Browsers try to make something out of it and it might redirect to unexpected sites.
Steps To ReproduceLoggin with System Administrator:
navigate to General Setup || Application || Module Management
Tab: Add Modules

Search for a module. If the module doesn't have a site associated, Firefox will try to rebuild the link using the word "hidden".

It might lead to some undesired sites.
Proposed SolutionIf there is no site, the link shouldn't be active.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-03-21 19:37Xpand-ITNew Issue
2011-03-21 19:37Xpand-ITAssigned To => adrianromero
2011-03-21 19:37Xpand-ITModules => Core
2011-06-03 10:58dalsasuaAssigned Toadrianromero => dalsasua
2011-07-20 18:16dalsasuaAssigned Todalsasua => jonalegriaesarte
2011-09-19 22:18psarobeNote Added: 0041101
2011-09-19 22:18psarobeStatusnew => feedback
2011-09-21 12:03Xpand-ITNote Added: 0041187
2011-10-07 13:17dmitry_mezentsevStatusfeedback => scheduled
2011-10-07 13:17dmitry_mezentsevNote Added: 0041557
2011-10-07 13:17dmitry_mezentsevfix_in_branch => pi
2011-10-07 13:18dmitry_mezentsevTarget Version => 3.0MP6
2011-10-07 13:18dmitry_mezentsevfix_in_branchpi =>
2011-11-25 17:22jonalegriaesarteAssigned Tojonalegriaesarte => alostale
2011-11-28 10:12alostaleTarget Version3.0MP6 =>
2012-02-21 18:07alostaleAssigned Toalostale => migueldejuana
2012-02-28 11:47migueldejuanaNote Added: 0045520
2012-02-28 12:58hgbotCheckin
2012-02-28 12:58hgbotNote Added: 0045530
2012-02-28 12:58hgbotStatusscheduled => resolved
2012-02-28 12:58hgbotResolutionopen => fixed
2012-02-28 12:58hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0c00996cda5f8c8d98c01c6e481a2155692de1e0 [^]
2012-02-28 12:59alostaleNote Added: 0045531
2012-02-28 12:59alostaleStatusresolved => closed
2012-02-28 12:59alostaleFixed in Version => 3.0MP9
2012-03-02 15:39hudsonbotCheckin
2012-03-02 15:39hudsonbotNote Added: 0045970

Notes
(0041101)
psarobe   
2011-09-19 22:18   
The issue is not clear. Please write the steps
(0041187)
Xpand-IT   
2011-09-21 12:03   
##Using Firefox

Loggin with System Administrator:
navigate to General Setup || Application || Module Management
Tab: Add Modules

Search for the module: "Asistente para añadir nuevos campos"
Click the link "Visit Site"
Firefox will try to find a website which has the word "hidden", which in this case is not a desired site, for sure.

If the module doesn't have a website associated maybe this link should point to www.openbravo.com?
(0041557)
dmitry_mezentsev   
2011-10-07 13:17   
I can reproduce it.
My proposal is to make URL field of the Module mandatory (at least forge project for the module that is published exists and it is much better to redirect users to it at least).
(0045520)
migueldejuana   
2012-02-28 11:47   
Test Plan:

Loggin with System Administrator:
navigate to General Setup || Application || Module Management
Tab: Add Modules

Search for the module: "Asistente para añadir nuevos campos"

See that it hasn't the "Visit site" link. Modules with URL have the "Visit site" link.
(0045530)
hgbot   
2012-02-28 12:58   
Repository: erp/devel/pi
Changeset: 0c00996cda5f8c8d98c01c6e481a2155692de1e0
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Feb 28 12:43:57 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/0c00996cda5f8c8d98c01c6e481a2155692de1e0 [^]

Fixed issue 16406: Adding modules, modules without URL, 'Visit site' disappears

---
M src/org/openbravo/erpCommon/ad_forms/ModuleManagement.java
M src/org/openbravo/erpCommon/modules/ModuleBox.srpt
M src/org/openbravo/erpCommon/modules/ModuleBox.xml
---
(0045531)
alostale   
2012-02-28 12:59   
Code reviewed and tested in pi@0c00996cda5f
(0045970)
hudsonbot   
2012-03-02 15:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test