Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0016338Openbravo ERPA. Platformpublic2011-03-16 18:342011-04-07 00:00
Reporterplujan 
Assigned Tomtaal 
PriorityhighSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0RC7Fixed in Version3.0RC6 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0016338: Usability issue when a message is shown in Lines
DescriptionI've detected a big usability issue when creating lines. Potentially could create a deletion of data that I was not willing to delete. See steps.
Steps To Reproduce1. Enter as QAAdmin
2. Go to Purchase Invoice and create a header.
3. Go to Lines and create 3 lines. Let's assume this lines are correct data that belong to the header.
4. Click in New in order to create a fourth line in Grid view
5. Suppose an alert makes an info banner to appear (like the one reported in issue 0016337)
6. Suppose that the banner tells you that you should not create this line. Before saving, you realize that creating this line was actually a mistake.
7. So you have a banner in a new record for a line that should not be there. Click the banner (seeking for copying the message shown)
8. When clicking the banner, the record you were is saved (wrong!) and the focus was moved to header (wrong!)
9. If you do not realize the small orange line on the left and click Delete button to delete the wrong saved line, you could finish with no Invoice at all, including the header and the correct lines
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0016337 closed marvintm Strange message "0.0 is not correct, consider using 0.00" when creating a Purchase Invoice line 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-03-16 18:34plujanNew Issue
2011-03-16 18:34plujanAssigned To => alostale
2011-03-16 18:34plujanModules => Core
2011-03-16 19:02plujanRelationship addedrelated to 0016337
2011-03-21 10:13alostaleTarget Version => 3.0RC6
2011-03-21 10:13alostaleStatusnew => scheduled
2011-03-21 10:13alostaleAssigned Toalostale => mtaal
2011-03-21 10:13alostalefix_in_branch => pi
2011-04-05 15:10mtaalNote Added: 0035605
2011-04-05 15:10mtaalStatusscheduled => feedback
2011-04-05 15:11mtaalTarget Version3.0RC6 => 3.0RC7
2011-04-05 15:11mtaalfix_in_branchpi =>
2011-04-05 15:39plujanNote Added: 0035607
2011-04-05 15:39plujanStatusfeedback => new
2011-04-05 15:53plujanNote Added: 0035611
2011-04-05 16:11hgbotCheckin
2011-04-05 16:11hgbotNote Added: 0035612
2011-04-05 16:11hgbotStatusnew => resolved
2011-04-05 16:11hgbotResolutionopen => fixed
2011-04-05 16:11hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f6835145eb18341bdf9071c6393ddd5aceff4f2d [^]
2011-04-06 11:19alostaleNote Added: 0035646
2011-04-06 11:19alostaleStatusresolved => closed
2011-04-06 11:20alostaleFixed in Version => 3.0RC6
2011-04-07 00:00anonymoussf_bug_id0 => 3278048

Notes
(0035605)
mtaal   
2011-04-05 15:10   
I can't really reproduce this issue (don't know how to get a message without saving the record). One change I made is that now the line is not saved anymore when clicking in the message bar, another change planned for the future is to make it better visible that a row is selected in an active or inactive view.

So afaics this issue can be closed/not reproducable, unless you can provide some way to reproduce it ofcourse.

gr. Martin
(0035607)
plujan   
2011-04-05 15:39   
As described in the issue steps, the issue was exposed by another issue. However, there is a way to simulate the behavior in order to see this issue.

You have to modify the Product callout in Purchase Invoice Lines, so it show a message. You can use as a base the Business Partner callout that shows a message when credit is over limit.
(0035611)
plujan   
2011-04-05 15:53   
Here, some simplified steps to avoid the change in the callout:
1. Enter as QAAdmin
2. Go to Purchase Invoice and create a header.
3. Go to Lines and create 3 lines. Let's assume this lines are correct data that belong to the header.
4. Click in New in order to create a fourth line in Grid view
5. Complete the product with "Raw Material A"
6. By filling the Product, the Tax is automatically filled. Delete the Tax content, leaving the field blank.
7. Click the Save button. An message will tell you that there is an error. If you click that banner to copy the content, then the focus is moved back to Header.
8. Now, if you do not realize the focus was moved, you could by mistake delete the entire Invoice instead the line.
(0035612)
hgbot   
2011-04-05 16:11   
Repository: erp/devel/pi
Changeset: f6835145eb18341bdf9071c6393ddd5aceff4f2d
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Apr 05 16:10:27 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f6835145eb18341bdf9071c6393ddd5aceff4f2d [^]

Fixes issue 16338: Usability issue when a message is shown in Lines

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-standard-view.js
---
(0035646)
alostale   
2011-04-06 11:19   
Now message appears in lines tab