Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0016285Openbravo ERPA. Platformpublic2011-03-15 10:012011-04-07 00:00
Reporterrgoris 
Assigned Tomtaal 
PriorityurgentSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0RC6Fixed in Versionpi 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0016285: Opening form ("switching to form view") must have immediate response
DescriptionDouble clicking a row in the grid (or CTRL-F2 or ENTER or clicking form icon)opens the form view. Sometimes this can take up to 1 second, which is a bit too long without informing the user on the progress. Feedback must be provided.
Steps To Reproduce
Proposed SolutionSwitch to form view immediately and then start loading the fields and rendering them. Most important is that the action (button click, keyboard press or double click) immediately responds.
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff 16285.diff (1,319) 2011-03-24 12:12
https://issues.openbravo.com/file_download.php?file_id=3754&type=bug
Issue History
Date ModifiedUsernameFieldChange
2011-03-15 10:01rgorisNew Issue
2011-03-15 10:01rgorisAssigned To => alostale
2011-03-15 10:01rgorisModules => Core
2011-03-16 10:27iperdomoAssigned Toalostale => iperdomo
2011-03-16 10:27iperdomoPriorityhigh => urgent
2011-03-16 10:27iperdomoTypefeature request => defect
2011-03-16 10:27iperdomoTarget Version3.0 => 3.0RC6
2011-03-16 10:27iperdomoStatusnew => scheduled
2011-03-16 10:27iperdomofix_in_branch => pi
2011-03-24 12:12iperdomoFile Added: 16285.diff
2011-03-24 12:13iperdomoAssigned Toiperdomo => mtaal
2011-03-28 23:13mtaalNote Added: 0035290
2011-03-28 23:13mtaalStatusscheduled => feedback
2011-03-29 10:14rgorisNote Added: 0035298
2011-03-29 17:18rgorisNote Added: 0035348
2011-03-31 12:29shuehnerNote Added: 0035413
2011-03-31 12:29shuehnerIssue Monitored: shuehner
2011-03-31 12:56rgorisNote Added: 0035416
2011-04-01 13:37rgorisStatusfeedback => scheduled
2011-04-04 14:19hgbotCheckin
2011-04-04 14:19hgbotNote Added: 0035552
2011-04-04 14:19hgbotStatusscheduled => resolved
2011-04-04 14:19hgbotResolutionopen => fixed
2011-04-04 14:19hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5f32bb22bf389c8ae88ae77de83c1b7152b73ca2 [^]
2011-04-06 08:53rgorisNote Added: 0035635
2011-04-06 08:53rgorisStatusresolved => closed
2011-04-06 08:53rgorisFixed in Version => pi
2011-04-07 00:00anonymoussf_bug_id0 => 3278045

Notes
(0035290)
mtaal   
2011-03-28 23:13   
Rob,
The system first does a call to the server to get the default values of fields and then opens the form. This is by design and has replaced an earlier implementation which opened the form directly but first disabled the fields.

So what should it be, stay like it is or be changed back to the old behavior?

gr. Martin
(0035298)
rgoris   
2011-03-29 10:14   
Martin, definitely first open form instantly,then lo
ading
(0035348)
rgoris   
2011-03-29 17:18   
As a general rule, every click/doubleclick the user does, needs an immediate response. Then, if needed, a loading process indicator can be shown. In this case, disabling the fields for a short moment, is the best solution.
(0035413)
shuehner   
2011-03-31 12:29   
Hmm i think that was just changed the opposite way. Some time ago the form did open and without values and the values where loaded and appeared after some delay.
Which several users complained about.
Now that behavior is different with all the form display being delayed and the form only painted in the final state always...

This bug now ask for changing this back again? reopening the old complains?
(0035416)
rgoris   
2011-03-31 12:56   
To my knowledge this change has not been discussed thoroughly, at least not with me. Either way, it is essential to have an immediate response. Since the delay is very short we can probably do without progress-feedback while the form is loading its values.

In case this causes a problem (perhaps the one you are referring to) we can then insert an interstitial progress/waiting indicator but this should be in-form then.

So steps to take:
1) Immediate action on doubleclick/formbutton/enter: form view opens instantly
2) Fields are disabled while loading
3) After trying (1) and (2) perhaps: add loading bar (candy bar) while loading fields.
(0035552)
hgbot   
2011-04-04 14:19   
Repository: erp/devel/pi
Changeset: 5f32bb22bf389c8ae88ae77de83c1b7152b73ca2
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Apr 04 14:18:38 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5f32bb22bf389c8ae88ae77de83c1b7152b73ca2 [^]

Fixes issue 16285: Opening form (switching to form view) must have immediate response

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-standard-view.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-view-form.js
---
(0035635)
rgoris   
2011-04-06 08:53   
yay!