Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0016281Openbravo ERPA. Platformpublic2011-03-14 19:132011-03-16 00:00
shuehner 
marvintm 
normalminorhave not tried
closedfixed 
5
 
 
Core
No
0016281: Export to CSV button should be deactivted if not rows are shown in grid
If showing an empty grid and using the Export CSV button it creates an 'empty' csv file only having the header lines with the column names.

As that is quite pointless the button should not be active in the first place if no rows are shown.
No tags attached.
Issue History
2011-03-14 19:13shuehnerNew Issue
2011-03-14 19:13shuehnerAssigned To => marvintm
2011-03-14 19:13shuehnerModules => Core
2011-03-15 11:30hgbotCheckin
2011-03-15 11:30hgbotNote Added: 0034860
2011-03-15 11:30hgbotStatusnew => resolved
2011-03-15 11:30hgbotResolutionopen => fixed
2011-03-15 11:30hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c090a7e0bef76341a1228b0ef377cf59fd48a222 [^]
2011-03-15 16:46shuehnerNote Added: 0034899
2011-03-15 16:46shuehnerStatusresolved => closed
2011-03-16 00:00anonymoussf_bug_id0 => 3214420

Notes
(0034860)
hgbot   
2011-03-15 11:30   
Repository: erp/devel/pi
Changeset: c090a7e0bef76341a1228b0ef377cf59fd48a222
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Mar 15 11:29:08 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/c090a7e0bef76341a1228b0ef377cf59fd48a222 [^]

Fixed issue 16281. Export to CSV button will be disabled if no rows are shown in the grid.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-toolbar.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-view-grid.js
---
(0034899)
shuehner   
2011-03-15 16:46   
Reviewed on pi/pgsql (rev:84d59a44cabd).
Now the export csv button is deactivated is grid is empty.

Note: the second changed file adds some update state of buttons calls to various places where it had been missing. No review can be done for that part as no steps to reproduce the fixed issue for that part are known.