0016208: Dal-Identifier calculation is using wrong order among the identifier fields defined for the table.

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0016208

Openbravo ERP

A. Platform

public

2011-03-10 16:21

2011-10-05 12:51

Reporter

shuehner

Assigned To

shuehner

Priority

normal

Severity

major

Reproducibility

have not tried

Status

closed

Resolution

duplicate

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0016208: Dal-Identifier calculation is using wrong order among the identifier fields defined for the table.

Description

If a table contains more than one field marked as identifier then the order among those fields is defined via the column ad_column.seqno (see i.e. ComboTableQuery_data.xsql or src-db/database/model/functions/AD_COLUMN_IDENTIFIER_SQL.xml).

DAL identifier calculation doesn't use this but instead reuses ad_column.position which is the standard order of the columns inside the table.

Example:
dal-identifier:
address spain - - Pamplona - 31002 - United States -
sql-identifier:
address spain - - 31002 - Pamplona - - United States

Which have different column ordering.

Steps To Reproduce

See attached diff for a junit testcase which exposes the issue for the table c_location, as it has identifier columns defined with an ordering different from the column order in the table.

Proposed Solution

When populating list of identifierColumns in org.openbravo.base.model.Table reorder the list by seq (which needs to be added to the mapping & file first).

Additional Information