0016146: Having a module include in a package two times, the package module task gives an error, but packages the module

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0016146

Openbravo ERP

A. Platform

public

2011-02-07 10:48

2011-03-15 12:15

Reporter

egoitz

Assigned To

alostale

Priority

high

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

2.50MP25

Target Version

2.50MP28

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0016146: Having a module include in a package two times, the package module task gives an error, but packages the module

Description

Having a module include in a package two times, the package module task gives an error, but packages the module.
After the error the package modules should stop, and not package a module.

Steps To Reproduce

-Create a new module and check as indevelopment
-Creaate a new package and check as indevelopment
-Go to include tab of the package.
-Add the module created on the first step two time.
-Export the modules: ant export.database
-Package the module package.
You get the following error:

obx.export.config.script:
[extractModule] 1 [main] ERROR org.openbravo.erpCommon.modules.ExtractModule - Error packaging module
[extractModule] java.util.zip.ZipException: duplicate entry: com.openbravo.borrar-0.0.1.obx
[extractModule] at java.util.zip.ZipOutputStream.putNextEntry(ZipOutputStream.java:175)
[extractModule] at org.openbravo.erpCommon.modules.ExtractModule.extractPackage(ExtractModule.java:181)
[extractModule] at org.openbravo.erpCommon.modules.ExtractModule.extract(ExtractModule.java:94)
[extractModule] at org.openbravo.erpCommon.modules.ExtractModule.extractName(ExtractModule.java:150)
[extractModule] at org.openbravo.erpCommon.modules.ExtractModuleTask.doExecute(ExtractModuleTask.java:64)
[extractModule] at org.openbravo.erpCommon.modules.ExtractModuleTask.execute(ExtractModuleTask.java:44)
[extractModule] at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:288)
[extractModule] at sun.reflect.GeneratedMethodAccessor1.invoke(Unknown Source)
[extractModule] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
[extractModule] at java.lang.reflect.Method.invoke(Method.java:597)
[extractModule] at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
[extractModule] at org.apache.tools.ant.Task.perform(Task.java:348)
[extractModule] at org.apache.tools.ant.Target.execute(Target.java:357)
[extractModule] at org.apache.tools.ant.Target.performTasks(Target.java:385)
[extractModule] at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1337)
[extractModule] at org.apache.tools.ant.Project.executeTarget(Project.java:1306)
[extractModule] at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41)
[extractModule] at org.apache.tools.ant.Project.executeTargets(Project.java:1189)
[extractModule] at org.apache.tools.ant.Main.runBuild(Main.java:758)
[extractModule] at org.apache.tools.ant.Main.startAnt(Main.java:217)
[extractModule] at org.apache.tools.ant.launch.Launcher.run(Launcher.java:257)
[extractModule] at org.apache.tools.ant.launch.Launcher.main(Launcher.java:104)

BUILD SUCCESSFUL

Proposed Solution

Two options.

-Add a validation to avoid packaging module if the module is include twice

-Add a constraint to avoid including the module twice

In any case, after any error the process shoud not say
Build Successfull

Additional Information