Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0015870Openbravo ERPA. Platformpublic2011-02-07 10:482011-03-16 00:00
Reporteregoitz 
Assigned Toalostale 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version2.50MP25 
Target Version2.50MP28Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0015870: Having a module include in a package two times, the package module task gives an error, but packages the module
DescriptionHaving a module include in a package two times, the package module task gives an error, but packages the module.
After the error the package modules should stop, and not package a module.
Steps To Reproduce-Create a new module and check as indevelopment
-Creaate a new package and check as indevelopment
-Go to include tab of the package.
-Add the module created on the first step two time.
-Export the modules: ant export.database
-Package the module package.
You get the following error:

obx.export.config.script:
[extractModule] 1 [main] ERROR org.openbravo.erpCommon.modules.ExtractModule - Error packaging module
[extractModule] java.util.zip.ZipException: duplicate entry: com.openbravo.borrar-0.0.1.obx
[extractModule] at java.util.zip.ZipOutputStream.putNextEntry(ZipOutputStream.java:175)
[extractModule] at org.openbravo.erpCommon.modules.ExtractModule.extractPackage(ExtractModule.java:181)
[extractModule] at org.openbravo.erpCommon.modules.ExtractModule.extract(ExtractModule.java:94)
[extractModule] at org.openbravo.erpCommon.modules.ExtractModule.extractName(ExtractModule.java:150)
[extractModule] at org.openbravo.erpCommon.modules.ExtractModuleTask.doExecute(ExtractModuleTask.java:64)
[extractModule] at org.openbravo.erpCommon.modules.ExtractModuleTask.execute(ExtractModuleTask.java:44)
[extractModule] at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:288)
[extractModule] at sun.reflect.GeneratedMethodAccessor1.invoke(Unknown Source)
[extractModule] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
[extractModule] at java.lang.reflect.Method.invoke(Method.java:597)
[extractModule] at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
[extractModule] at org.apache.tools.ant.Task.perform(Task.java:348)
[extractModule] at org.apache.tools.ant.Target.execute(Target.java:357)
[extractModule] at org.apache.tools.ant.Target.performTasks(Target.java:385)
[extractModule] at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1337)
[extractModule] at org.apache.tools.ant.Project.executeTarget(Project.java:1306)
[extractModule] at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41)
[extractModule] at org.apache.tools.ant.Project.executeTargets(Project.java:1189)
[extractModule] at org.apache.tools.ant.Main.runBuild(Main.java:758)
[extractModule] at org.apache.tools.ant.Main.startAnt(Main.java:217)
[extractModule] at org.apache.tools.ant.launch.Launcher.run(Launcher.java:257)
[extractModule] at org.apache.tools.ant.launch.Launcher.main(Launcher.java:104)

BUILD SUCCESSFUL
Proposed SolutionTwo options.

-Add a validation to avoid packaging module if the module is include twice

-Add a constraint to avoid including the module twice

In any case, after any error the process shoud not say
Build Successfull
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00161462.50MP28 closed alostale Having a module include in a package two times, the package module task gives an error, but packages the module 
related to defect 0016542 closed alostale ant package.module does not create the obx file if the dependencies are not exactly satisfied 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-02-07 10:48egoitzNew Issue
2011-02-07 10:48egoitzAssigned To => alostale
2011-02-07 10:48egoitzModules => Core
2011-02-07 10:48egoitzOBNetwork customer => No
2011-02-07 10:50egoitzIssue Monitored: networkb
2011-02-07 18:37egoitzOBNetwork customerNo => Yes
2011-02-07 18:37egoitzProposed Solution updated
2011-02-14 08:22alostaleStatusnew => scheduled
2011-03-07 09:36alostaleStatusscheduled => acknowledged
2011-03-07 09:36alostaleStatusacknowledged => scheduled
2011-03-07 09:36alostalefix_in_branch => pi
2011-03-07 09:46hgbotCheckin
2011-03-07 09:46hgbotNote Added: 0034594
2011-03-07 09:46hgbotStatusscheduled => resolved
2011-03-07 09:46hgbotResolutionopen => fixed
2011-03-07 09:46hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/fc7ec1644bf0ac61006d8e60a9a88468f2c6989f [^]
2011-03-15 12:15marvintmNote Added: 0034867
2011-03-15 12:15marvintmStatusresolved => closed
2011-03-16 00:00anonymoussf_bug_id0 => 3214394
2011-03-30 13:00alostaleRelationship addedrelated to 0016542

Notes
(0034594)
hgbot   
2011-03-07 09:46   
Repository: erp/devel/pi
Changeset: fc7ec1644bf0ac61006d8e60a9a88468f2c6989f
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Mar 07 09:37:30 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/fc7ec1644bf0ac61006d8e60a9a88468f2c6989f [^]

fixed bug 15870: Do not include same module more than once

  When packaging module in obx file, it is checked the same module is not included
  more than once.

---
M build.xml
M src/org/openbravo/service/system/ModuleValidator.java
M src/org/openbravo/service/system/SystemValidationResult.java
M src/org/openbravo/service/system/SystemValidationTask.java
---
(0034867)
marvintm   
2011-03-15 12:15   
Tested that when a package includes (recursively) the same module more than once, package.module fails, and that it doesn't fail when this doesn't happen.