Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0015785Openbravo ERP09. Financial managementpublic2011-01-27 01:252011-06-22 23:19
Reportereintelau 
Assigned Toeduardo_Argal 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0MP1Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0015785: Payment method pay in/out flags are ignored when displaying payment methods for a txn.
DescriptionThe Payment Method definition allows you to flag if this payment method is valid for incoming payments and/or for outgoing payments. The expectation would be if a payment method is not valid for incoming payments, then it won't be displayed as an option when receiving payments.

However all the windows that record a payment in the system (Add Transaction popup, Payment In, Payment Out, etc), ignore the pay in/out flags when populating the available payment methods and just look at what methods are configure for the account.
Steps To Reproduce1) Run OB with demo data
2) Go to Financial Accounts, select US Bank-Account 1
3) Go to payment methods for account, select Wire Transfer & untick Payment Out Allowed.
4) Open Purchase Invoice window & select invoice 1000008
5) Click Add Payments
6) Notice that the add Payments window has opened with US Bank-Account 1 and Wire Transfer selected.
7) Change to check payment, then a different bank account and back again.
8) Notice that Wire Transfer is still selectable in the payment method dropdown
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files? aprm_15785 (19,346) 2011-01-28 01:16
https://issues.openbravo.com/file_download.php?file_id=3554&type=bug
Issue History
Date ModifiedUsernameFieldChange
2011-01-27 01:25eintelauNew Issue
2011-01-27 01:25eintelauAssigned To => dalsasua
2011-01-27 01:25eintelauModules => Advanced Payables and Receivables Mngmt
2011-01-27 11:33miruritaAssigned Todalsasua => eduardo_Argal
2011-01-28 01:16eintelauFile Added: aprm_15785
2011-01-28 01:17eintelauNote Added: 0033937
2011-05-20 07:09hgbotCheckin
2011-05-20 07:09hgbotNote Added: 0037256
2011-05-20 07:09hgbotStatusnew => resolved
2011-05-20 07:09hgbotResolutionopen => fixed
2011-05-20 07:09hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2c4c356c8ad52e03b4a7fae7b4377d5f80b2cd3a [^]
2011-05-26 07:45hudsonbotCheckin
2011-05-26 07:45hudsonbotNote Added: 0037520
2011-06-14 12:19psanjuanNote Added: 0038335
2011-06-14 12:19psanjuanStatusresolved => new
2011-06-14 12:19psanjuanTarget Version => 3.0MP1
2011-06-22 14:11hgbotCheckin
2011-06-22 14:11hgbotNote Added: 0038483
2011-06-22 14:11hgbotStatusnew => resolved
2011-06-22 14:11hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/2c4c356c8ad52e03b4a7fae7b4377d5f80b2cd3a [^] => http://code.openbravo.com/erp/devel/pi/rev/1396f621eb35be28ebd74795a7a0a48c5174038c [^]
2011-06-22 16:28hgbotCheckin
2011-06-22 16:28hgbotNote Added: 0038484
2011-06-22 17:35psanjuanNote Added: 0038491
2011-06-22 17:35psanjuanStatusresolved => closed
2011-06-22 23:19hudsonbotCheckin
2011-06-22 23:19hudsonbotNote Added: 0038505
2011-06-22 23:19hudsonbotCheckin
2011-06-22 23:19hudsonbotNote Added: 0038506

Notes
(0033937)
eintelau   
2011-01-28 01:17   
Attached patch filters payment methods by pay in/out on
- Add Payment popups
- Payment In/Out windows
- Business Partner Customer/Vendor tab
(0037256)
hgbot   
2011-05-20 07:09   
Repository: erp/devel/pi
Changeset: 2c4c356c8ad52e03b4a7fae7b4377d5f80b2cd3a
Author: Ben Sommerville <ben.sommerville <at> eintel.com.au>
Date: Sat Mar 12 20:18:49 2011 +1100
URL: http://code.openbravo.com/erp/devel/pi/rev/2c4c356c8ad52e03b4a7fae7b4377d5f80b2cd3a [^]

Fixes issue 15785: Filter payment methods by payment in/out flags when populating combos

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddPaymentFromInvoice.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddPaymentFromTransaction.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_forms/BatchPaymentExecution.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/dao/AdvPaymentMngtDao.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java
M src/org/openbravo/erpCommon/ad_callouts/SE_PaymentMethod_FinAccount.java
---
(0037520)
hudsonbot   
2011-05-26 07:45   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/728387046be6 [^]

Maturity status: Test
(0038335)
psanjuan   
2011-06-14 12:19   
this one is not properly fixed. Let's take it for MP1 as this is not a critical one.
(0038483)
hgbot   
2011-06-22 14:11   
Repository: erp/devel/pi
Changeset: 1396f621eb35be28ebd74795a7a0a48c5174038c
Author: Mikel Irurita <mikel.irurita <at> openbravo.com>
Date: Wed Jun 22 14:09:40 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1396f621eb35be28ebd74795a7a0a48c5174038c [^]

Fixes issue 15785: Payment method pay in/out flags are ignored

---
M src-db/database/sourcedata/AD_AUXILIARINPUT.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_VAL_RULE.xml
---
(0038484)
hgbot   
2011-06-22 16:28   
Repository: erp/devel/pi
Changeset: ff3f6eebfc5b5a43d9a0ecb2d6b494340b3643b8
Author: Mikel Irurita <mikel.irurita <at> openbravo.com>
Date: Wed Jun 22 16:27:57 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ff3f6eebfc5b5a43d9a0ecb2d6b494340b3643b8 [^]

Related to issue 15785: fix callout and add validation to payment proposal

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src/org/openbravo/erpCommon/ad_callouts/SE_PaymentMethod_FinAccount.java
---
(0038491)
psanjuan   
2011-06-22 17:35   
fixed and working
(0038505)
hudsonbot   
2011-06-22 23:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/aab463ce0882 [^]

Maturity status: Test
(0038506)
hudsonbot   
2011-06-22 23:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/aab463ce0882 [^]

Maturity status: Test