Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0015746Openbravo ERP07. Sales managementpublic2011-01-24 14:012011-01-27 11:36
psarobe 
adrianromero 
immediatemajoralways
closedfixed 
5
2.50MP24 
2.50MP24 
Core
No
0015746: Create invoices from orders. Invoice rule. After delivery not working properly
In this case it creates one invoice per line that has the sales order
Regression
related to defect 00148842.50MP24 closed sivaraman Empty invoice line when creating invoice (Create Invoices from Orders process) 
has duplicate defect 0015805 closed adrianromero 'Create Invoices from Orders' does not work properly 
blocks defect 0015745 closed adrianromero Create invoices from orders. Invoice rule. After delivery not working properly 
Issue History
2011-01-24 14:01psarobeTypedefect => backport
2011-01-24 14:01psarobefix_in_branch => 2.50
2011-01-24 15:51hgbotCheckin
2011-01-24 15:51hgbotNote Added: 0033829
2011-01-24 15:51hgbotStatusscheduled => resolved
2011-01-24 15:51hgbotResolutionopen => fixed
2011-01-24 15:51hgbotFixed in SCM revision => http://code.openbravo.com/erp/stable/2.50/rev/d1e872fa524feffd33cae834d775a42c05df1780 [^]
2011-01-24 15:53adrianromeroNote Added: 0033830
2011-01-24 16:00adrianromeroNote Added: 0033832
2011-01-24 16:01adrianromeroRelationship addedrelated to 0014884
2011-01-25 13:43psarobeStatusresolved => closed
2011-01-25 13:43psarobeFixed in Version => 2.50MP24
2011-01-26 11:29hgbotCheckin
2011-01-26 11:29hgbotNote Added: 0033871
2011-01-26 11:29hgbotStatusclosed => resolved
2011-01-26 11:29hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/stable/2.50/rev/d1e872fa524feffd33cae834d775a42c05df1780 [^] => http://code.openbravo.com/erp/stable/2.50/rev/8731a5d5ed2048cfdc2bf7c102bc048e07136331 [^]
2011-01-26 17:19adrianromeroversion => 2.50MP24
2011-01-26 17:19adrianromeroTag Attached: Regression
2011-01-26 17:19psarobeStatusresolved => closed
2011-01-27 10:08hgbotCheckin
2011-01-27 10:08hgbotNote Added: 0033896
2011-01-27 10:08hgbotStatusclosed => resolved
2011-01-27 10:08hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/stable/2.50/rev/8731a5d5ed2048cfdc2bf7c102bc048e07136331 [^] => http://code.openbravo.com/erp/stable/2.50/rev/a95f4cc7c61c52eb8495f7bb307ae52980e38b16 [^]
2011-01-27 11:36psarobeNote Added: 0033908
2011-01-27 11:36psarobeStatusresolved => closed
2011-01-31 11:53adrianromeroRelationship addedhas duplicate 0015805

Notes
(0033829)
hgbot   
2011-01-24 15:51   
Repository: erp/stable/2.50
Changeset: d1e872fa524feffd33cae834d775a42c05df1780
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Mon Jan 24 15:50:07 2011 +0100
URL: http://code.openbravo.com/erp/stable/2.50/rev/d1e872fa524feffd33cae834d775a42c05df1780 [^]

Fixes issue 0015746: Create invoices from orders. Invoice rule. After delivery not working properly
It has been restored the line removed

---
M src-db/database/model/functions/C_INVOICE_CREATE.xml
---
(0033830)
adrianromero   
2011-01-24 15:53   
This issue is a regression caused by the changeset: https://code.openbravo.com/erp/devel/pi/rev/cd3774744f01 [^]

In the mentioned changes has been removed more code than needed this is why it has been needed to restore the line incorrectly removed
(0033832)
adrianromero   
2011-01-24 16:00   
* Testing the issue

Follow the steps to reproduce:
- Add a new discount record to an existing customer
- Create and process a new Sales order for this customer with the following details: Transaction Document Warehouse Order, Invoice Terms: After Delivery.
- Verify that the discount has been properly applied
- Go to Create Invoices from Orders, select the order just created and process.
- Verify that only one invoice is created

Test also that the related issue 14884 continues working as expected.

Test also general cases in the process Create Invoices from orders.

Test also the process Generate Invoices with Orders generated the same way

* Other areas affected

This modification also affects the process Generate Invoices.
(0033871)
hgbot   
2011-01-26 11:29   
Repository: erp/stable/2.50
Changeset: 8731a5d5ed2048cfdc2bf7c102bc048e07136331
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Mon Jan 24 15:50:07 2011 +0100
URL: http://code.openbravo.com/erp/stable/2.50/rev/8731a5d5ed2048cfdc2bf7c102bc048e07136331 [^]

Fixes issue 0015746: Create invoices from orders. Invoice rule. After delivery not working properly
It has been restored the line removed

---
M src-db/database/model/functions/C_INVOICE_CREATE.xml
---
(0033896)
hgbot   
2011-01-27 10:08   
Repository: erp/stable/2.50
Changeset: a95f4cc7c61c52eb8495f7bb307ae52980e38b16
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Mon Jan 24 15:50:07 2011 +0100
URL: http://code.openbravo.com/erp/stable/2.50/rev/a95f4cc7c61c52eb8495f7bb307ae52980e38b16 [^]

Fixes issue 0015746: Create invoices from orders. Invoice rule. After delivery not working properly
It has been restored the line removed

---
M src-db/database/model/functions/C_INVOICE_CREATE.xml
---
(0033908)
psarobe   
2011-01-27 11:36   
Works fine