Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0015721Openbravo ERPA. Platformpublic2011-01-21 08:212012-10-01 13:26
Reporteralostale 
Assigned ToAugustoMauch 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version3.0MP16 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0015721: Error checking locally end version dependency
Descriptioncheck.module.consistency task doesn't detect inconsistencies for end version of major enforcement dependencies.
Steps To Reproduce-Create a module: "test dep", version 2.1.0.
-Create a module: "test" depending with major enforcement on "test dep" module from version 1.0.0 to 2.0.0.
-Execute ant check.module.consistency. The obtained result is the instance is consistent whereas it should have failed.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-01-21 08:21alostaleNew Issue
2011-01-21 08:21alostaleAssigned To => alostale
2011-01-21 08:21alostaleModules => Core
2011-01-21 08:21alostaleOBNetwork customer => No
2011-01-21 11:02shuehnerIssue Monitored: shuehner
2011-01-21 11:03shuehnerNote Added: 0033803
2011-01-24 08:18alostaleStatusnew => scheduled
2012-09-19 10:24AugustoMauchAssigned Toalostale => AugustoMauch
2012-09-19 10:25AugustoMauchClosed by => alostale
2012-09-19 14:33AugustoMauchNote Added: 0052228
2012-09-19 14:33AugustoMauchNote Edited: 0052228bug_revision_view_page.php?bugnote_id=0052228#r3872
2012-09-19 14:33AugustoMauchNote Edited: 0052228bug_revision_view_page.php?bugnote_id=0052228#r3873
2012-09-19 14:34AugustoMauchNote Edited: 0052228bug_revision_view_page.php?bugnote_id=0052228#r3874
2012-09-19 14:34AugustoMauchNote Edited: 0052228bug_revision_view_page.php?bugnote_id=0052228#r3875
2012-09-19 14:36AugustoMauchIssue Monitored: alostale
2012-09-19 14:40hgbotCheckin
2012-09-19 14:40hgbotNote Added: 0052229
2012-09-19 14:40hgbotStatusscheduled => resolved
2012-09-19 14:40hgbotResolutionopen => fixed
2012-09-19 14:40hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0619603e5e540878fb78a4c637d3041a465014d5 [^]
2012-09-26 17:19hudsonbotCheckin
2012-09-26 17:19hudsonbotNote Added: 0052786
2012-10-01 13:26alostaleNote Added: 0052957
2012-10-01 13:26alostaleStatusresolved => closed
2012-10-01 13:26alostaleFixed in Version => 3.0MP16

Notes
(0033803)
shuehner   
2011-01-21 11:03   
Probably candidate for backport to 2.50? As shows some problem in the local dependency calculation/verification?
(0052228)
AugustoMauch   
2012-09-19 14:33   
(edited on: 2012-09-19 14:34)
The change only affects major dependencies having defined a last version.

Test plan:
- Create two modules, Test and DependentTest (which depends on Test). Execute the check.module.consistency task using the following parameters:

Test Version -- First Version -- Last Version -- Expected outcome
   2.1.1 -- 1.0.0 -- 2.1.1 -- Success
   2.1.1 -- 1.0.0 -- 2.1.2 -- Success
   2.1.1 -- 2.1.1 -- 2.1.1 -- Success
   2.1.1 -- 2.1.2 -- 2.3.0 -- Failure
   2.1.1 -- 1.0.0 -- 2.0.0 -- Failure (This one is equivalent to the case described in the issue)
   2.1.1 -- 2.2.1 -- 2.2.2 -- Failure
(0052229)
hgbot   
2012-09-19 14:40   
Repository: erp/devel/pi
Changeset: 0619603e5e540878fb78a4c637d3041a465014d5
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Sep 19 14:38:29 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/0619603e5e540878fb78a4c637d3041a465014d5 [^]

Fixes issue 15721: Module dependency validation has been fixed

The process that the modules dependencies was not working properly with modules that had major dependencies having defined a last version.

---
M src/org/openbravo/erpCommon/modules/VersionUtility.java
---
(0052786)
hudsonbot   
2012-09-26 17:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b780e90c6452 [^]

Maturity status: Test
(0052957)
alostale   
2012-10-01 13:26   
Code reviewed and tested.

Awaiting pi to be unfrozen to push jUnit test cases for this issue.