Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0015630Openbravo ERP08. Project and service managementpublic2011-01-12 12:362011-03-24 00:00
Reporterpsarobe 
Assigned Toadrianromero 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version3.0RC2 
Target Version2.50MP26Fixed in Version3.0RC4 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0015630: Project profitability report is not working under some circumstances
DescriptionProject profitability report is not working under some circumstances

Steps To ReproduceSteps to reproduce further error on this issue:

Create a new Project (either Service or Multiphase)

Set values for:

o Value, Name

o Bus. Partner

o Sales Represetative

o Planned Service Revenue

o Planned Expenses

o Services Provided Cost

o Outsourced Cost

o Planned Reinvoiced Expenses
xecute Project Profitability Report -> Fails: Error: There is no Conversion Rate defined for Day to Hour.

If you enter a Time Sheet for this project, then the report will work.
Proposed Solution
Additional Information
TagsRegression
Relationships
related to defect 0010690 closed adrianromero Expense Report and Project Profitability Reports display hours even if time sheet lines are in days 
depends on backport 00156312.50MP26 closed adrianromero Project profitability report is not working under some circumstances 
related to defect 0015808 closed dmiguelez Project profitability report does not detect whether there are conversion to hours or not 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-01-12 12:36psarobeNew Issue
2011-01-12 12:36psarobeAssigned To => adrianromero
2011-01-12 12:36psarobeModules => Core
2011-01-12 12:37psarobeStatusnew => scheduled
2011-01-12 12:37psarobefix_in_branch => pi
2011-01-12 12:38psarobeTag Attached: Regression
2011-01-12 12:38psarobeNote Added: 0033597
2011-01-13 16:52rafarodaIssue Monitored: rafaroda
2011-01-13 18:27hgbotCheckin
2011-01-13 18:27hgbotNote Added: 0033630
2011-01-13 18:27hgbotStatusscheduled => resolved
2011-01-13 18:27hgbotResolutionopen => fixed
2011-01-13 18:27hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/8b633bd01c5e07ebdb2ef5f28a79f2b721202130 [^]
2011-01-13 18:31adrianromeroNote Added: 0033632
2011-01-13 18:32adrianromeroversion2.50MP24 => 3.0RC3
2011-01-13 18:32adrianromerofix_in_branchpi =>
2011-01-13 18:33adrianromeroNote Added: 0033633
2011-01-13 18:33adrianromeroRelationship addedrelated to 0010690
2011-01-17 12:31psarobeNote Added: 0033678
2011-01-17 12:31psarobeStatusresolved => new
2011-01-17 12:31psarobeResolutionfixed => open
2011-01-17 14:24hgbotCheckin
2011-01-17 14:24hgbotNote Added: 0033686
2011-01-17 14:24hgbotStatusnew => resolved
2011-01-17 14:24hgbotResolutionopen => fixed
2011-01-17 14:24hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/8b633bd01c5e07ebdb2ef5f28a79f2b721202130 [^] => http://code.openbravo.com/erp/devel/pi/rev/189e816bcd7c6216526fdad1f3ed9e7f734dfd3a [^]
2011-01-17 14:25adrianromeroNote Added: 0033688
2011-01-17 15:50hgbotCheckin
2011-01-17 15:50hgbotNote Added: 0033690
2011-01-17 15:50hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/189e816bcd7c6216526fdad1f3ed9e7f734dfd3a [^] => http://code.openbravo.com/erp/devel/pi/rev/bcf2d9cce366cf8506322c1d42060f2303a1a709 [^]
2011-01-26 11:53psarobeversion3.0RC3 => 2.50MP23
2011-01-26 17:20adrianromeroversion2.50MP23 => 3.0RC2
2011-01-28 10:16hgbotCheckin
2011-01-28 10:16hgbotNote Added: 0033947
2011-01-28 10:16hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/bcf2d9cce366cf8506322c1d42060f2303a1a709 [^] => http://code.openbravo.com/erp/devel/pi/rev/91b91cf993184142ed9f142ddc6ad46643577a72 [^]
2011-01-28 11:27adrianromeroRelationship addedrelated to 0015808
2011-03-23 10:40psarobeStatusresolved => closed
2011-03-23 10:40psarobeFixed in Version => 3.0RC4
2011-03-24 00:00anonymoussf_bug_id0 => 3238862

Notes
(0033597)
psarobe   
2011-01-12 12:38   
Regression introduces by https://issues.openbravo.com/view.php?id=10690 [^]
(0033630)
hgbot   
2011-01-13 18:27   
Repository: erp/devel/pi
Changeset: 8b633bd01c5e07ebdb2ef5f28a79f2b721202130
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Jan 13 18:26:53 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/8b633bd01c5e07ebdb2ef5f28a79f2b721202130 [^]

Fixes issue 0015630: Project profitability report is not working under some circumstances
It has been modified the Profitability report and Expenses report to not to raise the conversion rate error when it is not needed.

---
M src/org/openbravo/erpCommon/ad_reports/ReportExpense.java
M src/org/openbravo/erpCommon/ad_reports/ReportProjectProfitabilityJR.java
---
(0033632)
adrianromero   
2011-01-13 18:31   
* Testing the issue

Verify that now projects with no time sheets can execute the Profitability project and also the Expenses project.

Verify also that the related issue 10690 works as expected. days are properly converted to hours in both reports.

* Other areas affected

Only has been modified the Expenses report and Project Profitability report.
(0033633)
adrianromero   
2011-01-13 18:33   
This regression has been created because when solving issue 10690 it has not been tested the case of projects with expense lines that are not time reports.
(0033678)
psarobe   
2011-01-17 12:31   
It is still failing in this scenario:

If you add hours against a product which UOM is hours then it is not working. The error is the same: There is no conversion rate between hours and days. It makes no sense since everything is in hours
(0033686)
hgbot   
2011-01-17 14:24   
Repository: erp/devel/pi
Changeset: 189e816bcd7c6216526fdad1f3ed9e7f734dfd3a
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Mon Jan 17 14:23:22 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/189e816bcd7c6216526fdad1f3ed9e7f734dfd3a [^]

Fixes issue 0015630: Project profitability report is not working under some circumstances
It has been added the case of expenses reported in hours

---
M src/org/openbravo/erpCommon/ad_reports/ReportExpense.java
M src/org/openbravo/erpCommon/ad_reports/ReportExpense_data.xsql
M src/org/openbravo/erpCommon/ad_reports/ReportProjectProfitabilityJR.java
---
(0033688)
adrianromero   
2011-01-17 14:25   
* Testing the issue

It has to be included the case of testing the scenario described in the note c33680
(0033690)
hgbot   
2011-01-17 15:50   
Repository: erp/devel/pi
Changeset: bcf2d9cce366cf8506322c1d42060f2303a1a709
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Mon Jan 17 15:49:43 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/bcf2d9cce366cf8506322c1d42060f2303a1a709 [^]

Fixes issue 0015630: Project profitability report is not working under some circumstances
Fixed
Fixing sql sentence

---
M src/org/openbravo/erpCommon/ad_reports/ReportExpense_data.xsql
---
(0033947)
hgbot   
2011-01-28 10:16   
Repository: erp/devel/pi
Changeset: 91b91cf993184142ed9f142ddc6ad46643577a72
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Fri Jan 28 10:15:37 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/91b91cf993184142ed9f142ddc6ad46643577a72 [^]

Fixes issue 0015630: Project profitability report is not working under some circumstances
It has been modified properly the UOM to convert to take always hours and has been restored the gropping on the Profitability report SQL sentence to remove the UOM. This sentence must be grouping only by project

---
M src/org/openbravo/erpCommon/ad_reports/ReportExpense_data.xsql
M src/org/openbravo/erpCommon/ad_reports/ReportProjectProfitabilityJR.java
M src/org/openbravo/erpCommon/ad_reports/ReportProjectProfitability_data.xsql
---