Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0015573Openbravo ERPZ. Otherspublic2011-01-04 19:172011-01-06 00:00
Reportershuehner 
Assigned Tomtaal 
PriorityimmediateSeveritycriticalReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0015573: api-check 734 fails
DescriptionThis api-check build fails:
http://builds.openbravo.com/job/int-api/734/console [^]


org.openbravo.client.application.window:
Abs.add
method org.openbravo.client.application.window.OBViewFormComponent.OBViewFieldDefinition.getTargetEntity(): new interface method in /srv/hudson/workspace/int-full-oracle/SANDBOX/api-checks/output/734
method org.openbravo.client.application.window.OBViewFormComponent.OBViewFieldDefinition.isParentProperty(): new interface method in /srv/hudson/workspace/int-full-oracle/SANDBOX/api-checks/output/734

Adding new methods to an interface definition will break existing classes implementing that interface as they need to be extended to implement the newly added methods.
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-01-04 19:17shuehnerNew Issue
2011-01-04 19:17shuehnerAssigned To => mtaal
2011-01-04 19:17shuehnerModules => Core
2011-01-04 19:26mtaalNote Added: 0033526
2011-01-04 19:26mtaalAssigned Tomtaal => iciordia
2011-01-05 09:41iciordiaNote Added: 0033528
2011-01-05 09:41iciordiaAssigned Toiciordia => mtaal
2011-01-05 15:34hgbotCheckin
2011-01-05 15:34hgbotNote Added: 0033531
2011-01-05 15:34hgbotStatusnew => resolved
2011-01-05 15:34hgbotResolutionopen => fixed
2011-01-05 15:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/f03bbe9b03ce76c7187f483c961cfee7c3c77b21 [^]
2011-01-05 18:59shuehnerNote Added: 0033533
2011-01-05 18:59shuehnerStatusresolved => closed
2011-01-06 00:00anonymoussf_bug_id0 => 3152156

Notes
(0033526)
mtaal   
2011-01-04 19:26   
This interface is in reality internal and can be made private. It is part of code which is not discussed in public and code which can not in anyway be meaningfully be extended.

Afaics there is no risk at all in changing this interface. I propose to make it private as part of this issue.

gr. Martin
(0033528)
iciordia   
2011-01-05 09:41   
Agree, let's make private that interface. API change approved since there is no risk of any module using it.

Ismael
(0033531)
hgbot   
2011-01-05 15:34   
Repository: erp/devel/api-checks
Changeset: f03bbe9b03ce76c7187f483c961cfee7c3c77b21
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Jan 05 15:28:40 2011 +0100
URL: http://code.openbravo.com/erp/devel/api-checks/rev/f03bbe9b03ce76c7187f483c961cfee7c3c77b21 [^]

Fixes issue 15578, Fixes issue 15573

---
M java/reference/java.japi.gz
---
(0033533)
shuehner   
2011-01-05 18:59   
api-check fine -> closing