Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0015542Openbravo ERPA. Platformpublic2010-12-29 11:172011-03-15 00:00
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0015542: API Change: the script tags in manual windows using the selector have changed
DescriptionIn 3.0 RC4 the way static resources are included in a page have changed: instead of many individual requests, all resources are concatenated (both javascript and stylesheets).
In addition resources only needed for classic windows are not read/included in new user interface pages.

This means that the way resources are read for the selector in classic windows has changed. This is documented here:
http://wiki.openbravo.com/wiki/Projects/Selector/Developers_Manual#Add_script_statements_in_head [^]

This change can be seen as an API change, explicit approval is needed therefore.
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-12-29 11:17mtaalNew Issue
2010-12-29 11:17mtaalAssigned To => iciordia
2010-12-29 11:17mtaalModules => Core
2010-12-29 12:35iciordiaNote Added: 0033424
2010-12-29 12:35iciordiaAssigned Toiciordia => mtaal
2010-12-29 17:01hgbotCheckin
2010-12-29 17:01hgbotNote Added: 0033426
2010-12-29 17:01hgbotStatusnew => resolved
2010-12-29 17:01hgbotResolutionopen => fixed
2010-12-29 17:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/322d25f6d91499d893043855a196d27a3a410903 [^]
2010-12-29 17:06hgbotCheckin
2010-12-29 17:06hgbotNote Added: 0033427
2010-12-29 17:06hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/322d25f6d91499d893043855a196d27a3a410903 [^] => http://code.openbravo.com/erp/devel/pi/rev/340f54dec87ea07a8fd31e5ee70700498e9b224f [^]
2010-12-29 17:07hgbotCheckin
2010-12-29 17:07hgbotNote Added: 0033428
2010-12-29 17:07hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/340f54dec87ea07a8fd31e5ee70700498e9b224f [^] => http://code.openbravo.com/erp/devel/pi/rev/d08bdcb628d6fdf188d199d50b293072991aed7c [^]
2010-12-31 15:19hudsonbotCheckin
2010-12-31 15:19hudsonbotNote Added: 0033502
2010-12-31 15:19hudsonbotCheckin
2010-12-31 15:19hudsonbotNote Added: 0033503
2010-12-31 15:20hudsonbotCheckin
2010-12-31 15:20hudsonbotNote Added: 0033504
2011-03-14 16:16mtaalNote Added: 0034811
2011-03-14 16:16mtaalStatusresolved => closed
2011-03-15 00:00anonymoussf_bug_id0 => 3212137

Notes
(0033424)
iciordia   
2010-12-29 12:35   
This API change is too risky (would affect several 2.50 modules) so it is rejected. The code should be adapted to support the previous behaviour.

Ismael
(0033426)
hgbot   
2010-12-29 17:01   
Repository: erp/devel/pi
Changeset: 322d25f6d91499d893043855a196d27a3a410903
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Dec 29 17:00:56 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/322d25f6d91499d893043855a196d27a3a410903 [^]

Fixes issue 15542: API Change: the script tags in manual windows using the selector have changed

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/ApplicationComponentProvider.java
M modules/org.openbravo.client.application/web/org.openbravo.client.application/index.html
---
(0033427)
hgbot   
2010-12-29 17:06   
Repository: erp/devel/pi
Changeset: 340f54dec87ea07a8fd31e5ee70700498e9b224f
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Dec 29 17:05:37 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/340f54dec87ea07a8fd31e5ee70700498e9b224f [^]

Fixes issue 15542: API Change: the script tags in manual windows using the selector have changed

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/BaseComponentProvider.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/ComponentProvider.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/KernelComponentProvider.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/KernelConstants.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/KernelServlet.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/StaticResourceComponent.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/StyleSheetResourceComponent.java
---
(0033428)
hgbot   
2010-12-29 17:07   
Repository: erp/devel/pi
Changeset: d08bdcb628d6fdf188d199d50b293072991aed7c
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Dec 29 17:06:52 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/d08bdcb628d6fdf188d199d50b293072991aed7c [^]

Fixes issue 15542: API Change: the script tags in manual windows using the selector have changed

---
M modules/org.openbravo.client.myob/src/org/openbravo/client/myob/MyOpenbravoComponentProvider.java
M modules/org.openbravo.client.querylist/src/org/openbravo/client/querylist/QueryListComponentProvider.java
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceComponentProvider.java
M modules/org.openbravo.userinterface.selector/src-wad/org/openbravo/userinterface/selector/wad/WADSelector.java
M modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/SelectorComponentProvider.java
M modules/org.openbravo.userinterface.smartclient/src/org/openbravo/userinterface/smartclient/SmartClientComponentProvider.java
A modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/classic-skin-variable.js
R modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-default-settings.js
---
(0033502)
hudsonbot   
2010-12-31 15:19   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/322d25f6d914 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/f27092744645 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
(0033503)
hudsonbot   
2010-12-31 15:19   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/340f54dec87e [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/f27092744645 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
(0033504)
hudsonbot   
2010-12-31 15:20   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/d08bdcb628d6 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/f27092744645 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
(0034811)
mtaal   
2011-03-14 16:16   
Closed