Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0015517Openbravo ERP09. Financial managementpublic2010-12-02 19:442011-05-24 10:57
maite 
dalsasua 
urgentmajoralways
closedfixed 
5
2.40MP12 
2.40MP13 
OBPS
Core
No
0015517: Error in message obtained when processing Bank Statement
Under some conditions, error "In line the debt payment has a change status later than the selected Account Date" is thrown which is wrongly composed because it does not indicate line number
1. Sales Management || Transactions || Sales Invoice || Header : create invoice with date 02/12/2010, document type "AR Invoice" and any line and COMPLETE it
2. Financial Management || Receivables & Payables || Transactions || Remittance || Header : create remittance for date 02/12/2010 and pressing "create lines from" choose payment associated to previous invoice. Process remittance
3. Financial Management || Receivables & Payables || Transactions || Bank Statement || Header : create bank statement with date 01/12/2010 and "pressing create lines from" choose negative payment associated to the remmitance
4. Try to process Bank Statement and you will obtain:
error "In line the debt payment has a change status later than the selected Account Date"
without indicating line number

Error is located in C_DP_MANAGEMENT_POST in query
IF(NOT FINISH_PROCESS) THEN
      SELECT count(*), MAX(ml.line)
      INTO v_Aux, v_line
      FROM C_DP_ManagementLine ml,
        C_DP_Management m
      WHERE ml.C_DP_Management_ID=m.C_DP_Management_ID
        AND m.C_DP_Management_ID=v_Record_ID
        AND exists
        (SELECT 1
        FROM C_DP_ManagementLine ml1,
          C_DP_Management m1
        WHERE m1.C_DP_Management_ID=ml1.C_DP_Management_ID
          AND ml1.C_Debt_Payment_ID=ml.C_Debt_Payment_ID
          AND m1.processed='Y'
          AND m1.DateAcct>m.DateAcct
        )
        ;
      if v_Aux!=0 then
        
       RAISE_APPLICATION_ERROR(-20000, '@Inline@'||v_line||' '||'@LaterChangeStatus@') ;
      end if;
    END IF;--FINISH_PROCESS

closingMay2011
blocks defect 00153632.40MP13 closed dalsasua Error in message obtained when processing Bank Statement 
Issue History
2010-12-23 18:24dalsasuaTypedefect => backport
2010-12-23 18:24dalsasuafix_in_branch => 2.40
2010-12-27 09:13dalsasuaNote Added: 0033397
2010-12-27 12:23hgbotCheckin
2010-12-27 12:23hgbotNote Added: 0033403
2010-12-27 12:23hgbotStatusscheduled => resolved
2010-12-27 12:23hgbotResolutionopen => fixed
2010-12-27 12:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/stable/2.40/rev/1933e86e2cc6943762dfa489a59e90830f0b3a81 [^]
2011-05-24 10:03dalsasuaTag Attached: closingMay2011
2011-05-24 10:57dalsasuaStatusresolved => closed

Notes
(0033397)
dalsasua   
2010-12-27 09:13   
This is the current process executed if the bank statement described in steps to reproduce is processed:

1.- C_BankStatement_Post procedure do create a new payment status management document automatically.
2.- This payment status management document do have always just two lines.
3.- Once the payment status management is created, it is processed, running C_DP_Management_Post process
4.- If the process fails, the error is returned to the C_BankStatment_Post, and shown in the UI.
5.- If it occurs that, as described in the steps to reproduce, the C_DP_Management_Post process fails, because there exists one payment status management prior to the new one, it will show the error:
In line XX the debt payment has a change status later than the selected Account Date
The XX will belong to the line in the newly created payment status management document (so, whether 10 or 20). In any case, nothing to do with the line number of the payment status management document that already exists.

There exists a bug in C_BankStatement_Post. Because of this, the lines created in the new payment status management document are not set. When the error mentioned in the issue is displayed, it shows "In line the debt...", while it must say "In line 10 the debt..." or "In line 20 the debt...".

I will fix this, and line number will be shown, but this will not help the reporter, as the line number of the existing payment status management document is expected, and not the line number of the new one. I think, also the message must enhanced to show this information.
(0033403)
hgbot   
2010-12-27 12:23   
Repository: erp/stable/2.40
Changeset: 1933e86e2cc6943762dfa489a59e90830f0b3a81
Author: David Alsasua <david.alsasua <at> openbravo.com>
Date: Mon Dec 27 12:22:21 2010 +0100
URL: http://code.openbravo.com/erp/stable/2.40/rev/1933e86e2cc6943762dfa489a59e90830f0b3a81 [^]

Fixes issue 15517: Error in message obtained when processing Bank Statement

---
M src-db/database/model/functions/C_BANKSTATEMENT_POST.xml
M src-db/database/model/functions/C_DP_MANAGEMENT_POST.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
---