Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0015464Openbravo ERPA. Platformpublic2010-12-16 17:112010-12-16 19:52
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version2.50MP25Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0015464: excludeFilter for modulescripts & modules/*/src-wad in compileSqlc task is not working
Descriptionwhich leads to the classes of src-wad in a module not being excluded and being present in their current version in the normal classpath.

When now a module is updated which has an 'internal' abi-change (like java and its xsql file in selector 1.0.12 -> 1.0.13) then Wad-call (using big project.class.path) will encounter the old class file from the wrong location, mixing it with the new class file for the xsql file and the whole update/compile willl fail.
Steps To ReproduceUsing i.e. mp21
Try to update from selector version 1.0.11 or 1.0.12 to 1.0.13 (not yet released)
Proposed Solutiona.) fix exclude in compileSqlc
b.) define minimal classpath for Wad so it does not pickup random other classfiles from various locations.
Additional Information
TagsNo tags attached.
Relationships
blocks defect 00154632.50MP25 closed shuehner excludeFilter for modulescripts & modules/*/src-wad in compileSqlc task is not working 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-12-16 17:11shuehnerTypedefect => backport
2010-12-16 17:11shuehnerfix_in_branch => 2.50
2010-12-16 17:44hgbotCheckin
2010-12-16 17:44hgbotNote Added: 0033245
2010-12-16 17:44hgbotStatusscheduled => resolved
2010-12-16 17:44hgbotResolutionopen => fixed
2010-12-16 17:44hgbotFixed in SCM revision => http://code.openbravo.com/erp/stable/2.50/rev/8a25973842698edb3013065bf2d8ace599e65d52 [^]
2010-12-16 19:52marvintmNote Added: 0033253
2010-12-16 19:52marvintmStatusresolved => closed

Notes
(0033245)
hgbot   
2010-12-16 17:44   
Repository: erp/stable/2.50
Changeset: 8a25973842698edb3013065bf2d8ace599e65d52
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Thu Dec 16 17:41:19 2010 +0100
URL: http://code.openbravo.com/erp/stable/2.50/rev/8a25973842698edb3013065bf2d8ace599e65d52 [^]

Fixed 15464: Fix updating modules having src-wad parts with internal changes
The excludeFilter for the src-wad parts of a module did not work correctly so
when updating a module having a src-wad which did changes its 'internal' api
between i.e. a xsql-file and a java class calling this the update process
failed it was mixing the old java class with the new version of the xsql file.
Fixed by:
- fixing exclude filter in compileSqlc task to really not module src-wad part
  of a module in normal compile
- define a new minimal classpath for Wad invcocation during compilation to not
  pickup those unwanted .class file even if they do exist.
- Along the way also fix excludeFilter in same location for src-util
  (moduleScripts) as it was also broken

---
M build.xml
M src/build.xml
---
(0033253)
marvintm   
2010-12-16 19:52   
Works fine.