Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0015362Openbravo ERPA. Platformpublic2010-12-02 19:162010-12-16 22:16
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version2.50MP25 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0015362: Remove around 130.000 duplicate db-queries from Wad to speedup wad runtime around 40s-1min
DescriptionWadUtility.getWadControlClass is an utility method to return an instance of the corresponding WadControl for a pair of parentReference & subReference.

One step in this is to lookup the java-classname for this pair in the database.

The total number of queries done for this in a typical compile.complete is around 13000. The total number of unique parentReference/subReference pairs is around 350.

Using a small cache for this lookup can remove most of those 130000 queries which leads to a speedup of Wad part of an compile.complete of around 40s to 1min (depending on the system).
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-12-02 19:16shuehnerNew Issue
2010-12-02 19:16shuehnerAssigned To => shuehner
2010-12-02 19:16shuehnerModules => Core
2010-12-02 19:22hgbotCheckin
2010-12-02 19:22hgbotNote Added: 0033019
2010-12-02 19:22hgbotStatusnew => resolved
2010-12-02 19:22hgbotResolutionopen => fixed
2010-12-02 19:22hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/abe749f609f8c07185a630e2f800d3995ae7e3fc [^]
2010-12-03 01:56hudsonbotCheckin
2010-12-03 01:56hudsonbotNote Added: 0033025
2010-12-14 16:37alostaleStatusresolved => closed
2010-12-14 16:37alostaleFixed in Version => 2.50MP25
2010-12-16 22:16anonymoussf_bug_id0 => 3138804

Notes
(0033019)
hgbot   
2010-12-02 19:22   
Repository: erp/devel/pi
Changeset: abe749f609f8c07185a630e2f800d3995ae7e3fc
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Thu Dec 02 19:19:21 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/abe749f609f8c07185a630e2f800d3995ae7e3fc [^]

Fixed 15362: Speedup wad by caching many repeated queries.
Remove nearly 130.000 db-queries by using a small cache of around 350 entries

---
M src-wad/src/org/openbravo/wad/WadUtility.java
---
(0033025)
hudsonbot   
2010-12-03 01:56   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/abe749f609f8 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/75b773c7562f [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.19066.obx [^]