Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0015353Openbravo ERPA. Platformpublic2010-12-02 13:162010-12-30 13:13
Reportershuehner 
Assigned Tomarvintm 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version2.50MP24 
Target Version2.50MP25Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0015353: Usuing Dataset: 'Export referencedata' trigger 'db has local changes check' but is not protected by 'isindevelopment'
DescriptionAfter issue 15178 was implemented the 'export referencedata' does modify the ad_dataset row of the dataset being exported (to write a checksum there).

This will prevent all further update.database calls (i.e. update/install of modules) until this changed ad_dataset row is exported.

However the user does not know this as this action (export referencedata) is not protected by the 'You need to set the module into development' check which is present in all other actions requiring to export a module afterwards.
Steps To ReproduceInstall i.e. 3.0rc3 (this means no module in development)
Goto the dataset window
locate entry to 'My openbravo'
use the 'export referencedata' button
run ant update.database
This will fail with the 'db has local changes' message
Proposed SolutionWhen exporting a dataset/referencedata require the module containing it to be in development.
Additional Information
TagsNo tags attached.
Relationships
related to defect 00151782.50MP25 closed marvintm Users shouldn't be able to apply a dataset if it hasn't changed 
depends on backport 00154082.50MP25 closed marvintm Usuing Dataset: 'Export referencedata' trigger 'db has local changes check' but is not protected by 'isindevelopment' 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-12-02 13:16shuehnerNew Issue
2010-12-02 13:16shuehnerAssigned To => marvintm
2010-12-02 13:16shuehnerModules => Core
2010-12-02 13:16shuehnerRelationship addedrelated to 0015178
2010-12-06 07:46alostaleStatusnew => scheduled
2010-12-13 12:58marvintmStatusscheduled => acknowledged
2010-12-13 12:58marvintmStatusacknowledged => scheduled
2010-12-13 12:58marvintmfix_in_branch => pi
2010-12-13 13:01hgbotCheckin
2010-12-13 13:01hgbotNote Added: 0033122
2010-12-13 13:01hgbotStatusscheduled => resolved
2010-12-13 13:01hgbotResolutionopen => fixed
2010-12-13 13:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f0e7e3fce5616dcd0ee3ec14ee11ed66dda9a3a8 [^]
2010-12-14 13:08hgbotCheckin
2010-12-14 13:08hgbotNote Added: 0033163
2010-12-14 14:07shuehnerNote Added: 0033166
2010-12-14 14:07shuehnerStatusresolved => new
2010-12-14 14:07shuehnerResolutionfixed => open
2010-12-14 16:00hgbotCheckin
2010-12-14 16:00hgbotNote Added: 0033170
2010-12-14 16:00hgbotStatusnew => resolved
2010-12-14 16:00hgbotResolutionopen => fixed
2010-12-14 16:00hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/f0e7e3fce5616dcd0ee3ec14ee11ed66dda9a3a8 [^] => http://code.openbravo.com/erp/devel/pi/rev/dad0e6a907253d8483b2e548ac68b5ea747bcd26 [^]
2010-12-14 16:41shuehnerNote Added: 0033176
2010-12-14 16:41shuehnerStatusresolved => closed
2010-12-16 22:16anonymoussf_bug_id0 => 3138802
2010-12-30 13:13hudsonbotCheckin
2010-12-30 13:13hudsonbotNote Added: 0033435
2010-12-30 13:13hudsonbotCheckin
2010-12-30 13:13hudsonbotNote Added: 0033445

Notes
(0033122)
hgbot   
2010-12-13 13:01   
Repository: erp/devel/pi
Changeset: f0e7e3fce5616dcd0ee3ec14ee11ed66dda9a3a8
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon Dec 13 13:00:09 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f0e7e3fce5616dcd0ee3ec14ee11ed66dda9a3a8 [^]

Fixed issue 15353. The process will check if the module is in development before running.

---
M src/org/openbravo/erpCommon/ad_actionButton/ExportReferenceData.java
---
(0033163)
hgbot   
2010-12-14 13:08   
Repository: erp/stable/2.50
Changeset: 06a1060d50dec0a1a331c951f7a9195dcca5b56a
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Dec 14 12:39:22 2010 +0100
URL: http://code.openbravo.com/erp/stable/2.50/rev/06a1060d50dec0a1a331c951f7a9195dcca5b56a [^]

Related to issue 15353. Improved title of error message.

---
M src/org/openbravo/erpCommon/ad_actionButton/ExportReferenceData.java
---
(0033166)
shuehner   
2010-12-14 14:07   
Not working. Using the export button with a module not in development now does show an error message. However the next update.database will still fail. As the ad_dataset row was still changed.
Most likely by the automatically triggered autosave (when clicking the button) which does at least update the updatedby columns.
Ideas to fix:
- change autosave to not to empty updates
- trigger which avoids changing updated on this table only if there's no real change
- disable autosave for this button (there's an option to configure that)
- hide button with displaylogic if module is not in development
- disable button with readonlylogic if module is not in development
(0033170)
hgbot   
2010-12-14 16:00   
Repository: erp/devel/pi
Changeset: dad0e6a907253d8483b2e548ac68b5ea747bcd26
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Dec 14 15:58:42 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/dad0e6a907253d8483b2e548ac68b5ea747bcd26 [^]

Fixed issue 15353. Export reference data will no longer trigger autosave

---
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0033176)
shuehner   
2010-12-14 16:41   
Tested on pi/pgsql (rev: dad0e6a90725) now working fine. However autosave is now disabled for this button (export reference data) in the 'dataset window.
(0033435)
hudsonbot   
2010-12-30 13:13   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/f0e7e3fce561 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/7d7e5eebcc62 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.19448.obx [^]
(0033445)
hudsonbot   
2010-12-30 13:13   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/dad0e6a90725 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/7d7e5eebcc62 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.19448.obx [^]