Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0015321Openbravo ERPA. Platformpublic2010-11-27 18:122010-12-16 22:16
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0015321: Remove code generated in /* comment */ blocks in all generated servlets
DescriptionWad does currently generate a few blocks of unsued (as comment code) into all generated servlets:

- commented commandIn("DELETE_RELATION") block -> not used since DataGrid exists
- commented function deleteRelation only references in above block
- unused SqlMethod deleteTransactional only referenced in above function
Steps To Reproduce
Proposed Solution- remove the unused code
While at it:
- remove unused constant SUBTABS_COL_SIZE
- make to package-local utility functions also private as rest of utility functions per servlet (fine for api as already package local and also erpWindows is excluded from api-check)
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-11-27 18:12shuehnerNew Issue
2010-11-27 18:12shuehnerAssigned To => shuehner
2010-11-27 18:15hgbotCheckin
2010-11-27 18:15hgbotNote Added: 0032897
2010-11-27 18:15hgbotStatusnew => resolved
2010-11-27 18:15hgbotResolutionopen => fixed
2010-11-27 18:15hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/33fec3e331ef22cd5781f9d0b1e7429d32ca9d92 [^]
2010-11-30 17:52hudsonbotCheckin
2010-11-30 17:52hudsonbotNote Added: 0032960
2010-12-13 15:15marvintmNote Added: 0033128
2010-12-13 15:15marvintmStatusresolved => closed
2010-12-16 22:16anonymoussf_bug_id0 => 3138800

Notes
(0032897)
hgbot   
2010-11-27 18:15   
Repository: erp/devel/pi
Changeset: 33fec3e331ef22cd5781f9d0b1e7429d32ca9d92
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Sat Nov 27 18:14:49 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/33fec3e331ef22cd5781f9d0b1e7429d32ca9d92 [^]

Fixed 15321: remove some unused code in all generated servlets
Saves around 1mb
132280l srcAD.orig
131092l srcAD

---
M src-wad/src/org/openbravo/wad/datasource.xsqlxml
M src-wad/src/org/openbravo/wad/javasource.javaxml
---
(0032960)
hudsonbot   
2010-11-30 17:52   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/33fec3e331ef [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/7c27b4b566df [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.19017.obx [^]
(0033128)
marvintm   
2010-12-13 15:15   
Works fine