Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0015308Openbravo ERPA. Platformpublic2010-11-26 16:052010-12-16 22:16
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version2.50MP25 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0015308: Cleanup some wad-code
DescriptionThis issue is to do some cleanup in the existing wad-code:
- Making classes/methods private where possible
- After that identifying and removing some unused code

As main api-check does not check org.openbravo.wad no issue with that. And the only known user of that unofficial api (UI selector, src-wad part) is not affected those changes.
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-11-26 16:05shuehnerNew Issue
2010-11-26 16:05shuehnerAssigned To => shuehner
2010-11-26 16:34hgbotCheckin
2010-11-26 16:34hgbotNote Added: 0032885
2010-11-26 16:34hgbotCheckin
2010-11-26 16:34hgbotNote Added: 0032886
2010-11-26 16:34hgbotCheckin
2010-11-26 16:34hgbotNote Added: 0032887
2010-11-26 16:34hgbotCheckin
2010-11-26 16:34hgbotNote Added: 0032888
2010-11-26 16:34hgbotStatusnew => resolved
2010-11-26 16:34hgbotResolutionopen => fixed
2010-11-26 16:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4d16fada2ef56b71394cd9f6b69314aac6362d72 [^]
2010-11-30 17:52hudsonbotCheckin
2010-11-30 17:52hudsonbotNote Added: 0032954
2010-11-30 17:52hudsonbotCheckin
2010-11-30 17:52hudsonbotNote Added: 0032955
2010-11-30 17:52hudsonbotCheckin
2010-11-30 17:52hudsonbotNote Added: 0032956
2010-11-30 17:52hudsonbotCheckin
2010-11-30 17:52hudsonbotNote Added: 0032957
2010-12-14 16:35alostaleStatusresolved => closed
2010-12-14 16:35alostaleFixed in Version => 2.50MP25
2010-12-16 22:16anonymoussf_bug_id0 => 3138798

Notes
(0032885)
hgbot   
2010-11-26 16:34   
Repository: erp/devel/pi
Changeset: 089cdca2f1b5292fce34121df905045c3e7645b2
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Fri Nov 26 16:06:57 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/089cdca2f1b5292fce34121df905045c3e7645b2 [^]

Issue 15308: make code in wad more private to facilitate some cleanup

---
M src-wad/src/org/openbravo/wad/Wad.java
M src-wad/src/org/openbravo/wad/WadActionButton.java
M src-wad/src/org/openbravo/wad/WadConnection.java
M src-wad/src/org/openbravo/wad/WadUtility.java
M src-wad/src/org/openbravo/wad/validation/WADValidationResult.java
M src-wad/src/org/openbravo/wad/validation/WADValidator.java
---
(0032886)
hgbot   
2010-11-26 16:34   
Repository: erp/devel/pi
Changeset: fc84c3b9955c339a917796c53a1c817715cb8289
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Fri Nov 26 16:07:55 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/fc84c3b9955c339a917796c53a1c817715cb8289 [^]

Issue 15308: Remove some unused (and now private) code

---
M src-wad/src/org/openbravo/wad/Wad.java
M src-wad/src/org/openbravo/wad/WadActionButton.java
M src-wad/src/org/openbravo/wad/WadConnection.java
M src-wad/src/org/openbravo/wad/WadUtility.java
---
(0032887)
hgbot   
2010-11-26 16:34   
Repository: erp/devel/pi
Changeset: 457a10871cb0fc0b4b4214408c773b9efabf1d69
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Fri Nov 26 16:10:07 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/457a10871cb0fc0b4b4214408c773b9efabf1d69 [^]

Issue 15308: Remove code for some long unused command line parameters in Wad
- directory Translate, translation to, Base path, Src path
They are still passed to Wad by the build.xml files to keep that interface
stable

---
M src-wad/src/org/openbravo/wad/Wad.java
---
(0032888)
hgbot   
2010-11-26 16:34   
Repository: erp/devel/pi
Changeset: 4d16fada2ef56b71394cd9f6b69314aac6362d72
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Fri Nov 26 16:12:35 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/4d16fada2ef56b71394cd9f6b69314aac6362d72 [^]

Fixed 15308: Last part remove some more unsued code

---
M src-wad/src/org/openbravo/wad/Wad.java
M src-wad/src/org/openbravo/wad/WadActionButton.java
M src-wad/src/org/openbravo/wad/WadUtility_data.xsql
---
(0032954)
hudsonbot   
2010-11-30 17:52   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/089cdca2f1b5 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/7c27b4b566df [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.19017.obx [^]
(0032955)
hudsonbot   
2010-11-30 17:52   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/fc84c3b9955c [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/7c27b4b566df [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.19017.obx [^]
(0032956)
hudsonbot   
2010-11-30 17:52   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/457a10871cb0 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/7c27b4b566df [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.19017.obx [^]
(0032957)
hudsonbot   
2010-11-30 17:52   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/4d16fada2ef5 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/7c27b4b566df [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.19017.obx [^]