Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0015292Openbravo ERPZ. Otherspublic2010-11-25 13:102011-03-04 15:18
Reporteriperdomo 
Assigned Toiperdomo 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS Version2.6.30-gentoo-r5
Product Version2.50 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesUser Interface Client Kernel
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0015292: Concatenate all static resources to make a single request
DescriptionAll static resources should be concatenated in a single file to save HTTP requests. Current approach is a GET request for each static resource.
Steps To Reproduce
Proposed Solution* Concatenate all static resources files in a single string
* Hash the string, the result will be used as file name
* Save the file name in web/js if the hash doesn't exist
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0015325 closed iperdomo Navigation components should use the PropertyStore asynchronously 
related to feature request 00153803.0MP0 closed iperdomo Remove tomcat's Expires filter 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-11-25 13:10iperdomoNew Issue
2010-11-25 13:10iperdomoAssigned To => iperdomo
2010-11-25 13:11iperdomoStatusnew => scheduled
2010-11-25 13:11iperdomofix_in_branch => pi
2010-11-25 16:30hgbotCheckin
2010-11-25 16:30hgbotNote Added: 0032854
2010-11-25 16:32hgbotCheckin
2010-11-25 16:32hgbotNote Added: 0032855
2010-11-25 16:35hgbotCheckin
2010-11-25 16:35hgbotNote Added: 0032856
2010-11-25 16:37hgbotCheckin
2010-11-25 16:37hgbotNote Added: 0032857
2010-11-26 21:52hgbotCheckin
2010-11-26 21:52hgbotNote Added: 0032894
2010-11-29 08:28iperdomoRelationship addeddepends on 0015325
2010-12-02 10:57mtaalStatusscheduled => resolved
2010-12-02 10:57mtaalFixed in SCM revision => pi
2010-12-02 10:57mtaalResolutionopen => fixed
2010-12-02 10:57mtaalNote Added: 0032999
2010-12-02 10:57mtaalStatusresolved => closed
2010-12-09 11:47iperdomoRelationship addedrelated to 0015380
2010-12-09 16:08anonymoussf_bug_id0 => 3133574
2011-03-04 15:18hgbotCheckin
2011-03-04 15:18hgbotNote Added: 0034565

Notes
(0032854)
hgbot   
2010-11-25 16:30   
Repository: erp/mods/org.openbravo.client.kernel
Changeset: 6818f6bcba69b99d25e5325d0c1de9ec67cd8793
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Thu Nov 25 16:27:46 2010 +0100
URL: http://code.openbravo.com/erp/mods/org.openbravo.client.kernel/rev/6818f6bcba69b99d25e5325d0c1de9ec67cd8793 [^]

Issue 15292: Static resources are read and concatenated
- Changed compression tool from JSMin to Closure compiler
- The static resources are read (.js files) and generated if is a component
    and concatenated together.
- If the module is in development the resources are jslinted
- If the module is not in development the resources are minimized
- The whole big string is 'hashed' and used a file name

---
M src/org/openbravo/client/kernel/BaseComponent.java
M src/org/openbravo/client/kernel/ComponentGenerator.java
M src/org/openbravo/client/kernel/JSCompressor.java
M src/org/openbravo/client/kernel/KernelComponentProvider.java
M src/org/openbravo/client/kernel/KernelConstants.java
M src/org/openbravo/client/kernel/KernelServlet.java
M src/org/openbravo/client/kernel/KernelUtils.java
M src/org/openbravo/client/kernel/StaticResourceComponent.java
A lib/runtime/compiler-20100917.jar
R lib/runtime/jsmin.0.2.4.jar
---
(0032855)
hgbot   
2010-11-25 16:32   
Repository: erp/mods/org.openbravo.userinterface.smartclient
Changeset: 356bcf8b69343325ba492fc801b850a167d20fc6
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Thu Nov 25 16:30:34 2010 +0100
URL: http://code.openbravo.com/erp/mods/org.openbravo.userinterface.smartclient/rev/356bcf8b69343325ba492fc801b850a167d20fc6 [^]

Issue 15292: Removed ISC_Combined from static resources
- Removed the ISC_Combined.js from static resources. Is loaded from the
    index.html
- Changed the path of the load skin code
- Removed commented code

---
M src/org/openbravo/userinterface/smartclient/SmartClientComponentProvider.java
---
(0032856)
hgbot   
2010-11-25 16:35   
Repository: erp/mods/org.openbravo.client.application
Changeset: 38a6ab786f488932dcd7ab4585757400ac558cc6
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Thu Nov 25 16:33:28 2010 +0100
URL: http://code.openbravo.com/erp/mods/org.openbravo.client.application/rev/38a6ab786f488932dcd7ab4585757400ac558cc6 [^]

Issue 15292: Updated code for static resources, fixes 'goto' as variable name
- Updated the application code to use the new static resources
- goto is a reserved word, it shouldn't be used as variable name
- Updated index.html to load ISC_Combined.js plus the spinner when loading
    static resources

---
M src/org/openbravo/client/application/ApplicationComponentProvider.java
M src/org/openbravo/client/application/navigationbarcomponents/templates/application-menu.js.ftl
M web/org.openbravo.client.application/index.html
---
(0032857)
hgbot   
2010-11-25 16:37   
Repository: erp/mods/org.openbravo.client.myob
Changeset: e7d636648f5bc884ff69162b4acb2c28003e3947
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Thu Nov 25 16:35:06 2010 +0100
URL: http://code.openbravo.com/erp/mods/org.openbravo.client.myob/rev/e7d636648f5bc884ff69162b4acb2c28003e3947 [^]

Issue 15292: Updated static resources to use new code
- Updated component provider to use new code
- Fixes CSS file. Wrong definition of black color

---
M src/org/openbravo/client/myob/MyOpenbravoComponentProvider.java
M web/org.openbravo.userinterface.smartclient/openbravo/skins/3.00/org.openbravo.client.myob/ob-widget-styles.css
---
(0032894)
hgbot   
2010-11-26 21:52   
Repository: erp/mods/org.openbravo.client.application
Changeset: f6b07a20ce46fd61d81d9a3c6805f3f293c3d8a6
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Fri Nov 26 21:52:23 2010 +0100
URL: http://code.openbravo.com/erp/mods/org.openbravo.client.application/rev/f6b07a20ce46fd61d81d9a3c6805f3f293c3d8a6 [^]

Issue 15292: showEdges triggers JS error in IE

---
M web/org.openbravo.client.application/index.html
---
(0032999)
mtaal   
2010-12-02 10:57   
Reviewed
(0034565)
hgbot   
2011-03-04 15:18   
Repository: erp/mods/org.openbravo.client.kernel
Changeset: 6818f6bcba69b99d25e5325d0c1de9ec67cd8793
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Thu Nov 25 16:27:46 2010 +0100
URL: http://code.openbravo.com/erp/mods/org.openbravo.client.kernel/rev/6818f6bcba69b99d25e5325d0c1de9ec67cd8793 [^]

Issue 15292: Static resources are read and concatenated
- Changed compression tool from JSMin to Closure compiler
- The static resources are read (.js files) and generated if is a component
    and concatenated together.
- If the module is in development the resources are jslinted
- If the module is not in development the resources are minimized
- The whole big string is 'hashed' and used a file name

---
M src/org/openbravo/client/kernel/BaseComponent.java
M src/org/openbravo/client/kernel/ComponentGenerator.java
M src/org/openbravo/client/kernel/JSCompressor.java
M src/org/openbravo/client/kernel/KernelComponentProvider.java
M src/org/openbravo/client/kernel/KernelConstants.java
M src/org/openbravo/client/kernel/KernelServlet.java
M src/org/openbravo/client/kernel/KernelUtils.java
M src/org/openbravo/client/kernel/StaticResourceComponent.java
A lib/runtime/compiler-20100917.jar
R lib/runtime/jsmin.0.2.4.jar
---