Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0015195Openbravo ERPA. Platformpublic2010-11-15 21:542012-04-21 14:23
iperdomo 
migueldejuana 
urgentminoralways
closedfixed 
202.6.30-gentoo-r5
2.50MP23 
3.0MP11 
Core
No
0015195: Add trigger/validation when a module ships a dataset
When a module ships (adds) a dataset, the 'hasReferenceData' check should automatically set to 'Y', if not the dataset will not be applied.
* Create a module
* Adds a dataset at System level
* DON'T check the 'Has reference data'
* Export/package the module
* Install the module in other instance, the dataset is not applied
* Add a validation, trigger to the module that has a reference data, and has not the 'has reference data' check
contrib
Issue History
2010-11-15 21:54iperdomoNew Issue
2010-11-15 21:54iperdomoAssigned To => alostale
2010-11-15 21:56shuehnerIssue Monitored: shuehner
2010-11-22 08:35alostaleStatusnew => scheduled
2011-04-01 18:11alostaleTag Attached: contrib
2012-04-03 08:29alostaleAssigned Toalostale => migueldejuana
2012-04-03 08:30alostaleNote Added: 0047325
2012-04-03 08:33alostaleTypedefect => feature request
2012-04-16 16:10hgbotCheckin
2012-04-16 16:10hgbotNote Added: 0047589
2012-04-16 16:10hgbotStatusscheduled => resolved
2012-04-16 16:10hgbotResolutionopen => fixed
2012-04-16 16:10hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6017d223d4234ffd46475abcd077198f8b209581 [^]
2012-04-16 16:15migueldejuanaNote Added: 0047590
2012-04-16 17:46AugustoMauchNote Added: 0047595
2012-04-16 17:46AugustoMauchStatusresolved => closed
2012-04-16 17:46AugustoMauchFixed in Version => 3.0MP11
2012-04-18 18:01migueldejuanaNote Added: 0047719
2012-04-21 14:23hudsonbotCheckin
2012-04-21 14:23hudsonbotNote Added: 0047812

Notes
(0047325)
alostale   
2012-04-03 08:30   
This validation shuould be done when packaging the module. It should warn in case the moudle has reference data and it is not marked as so or in case it is marked and it doesn't contain reference data.
(0047589)
hgbot   
2012-04-16 16:10   
Repository: erp/devel/pi
Changeset: 6017d223d4234ffd46475abcd077198f8b209581
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Apr 16 16:08:20 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6017d223d4234ffd46475abcd077198f8b209581 [^]

Fixed issue 15195: New module validation when packaging for 'has reference data'
This validation has been done when packaging the module. It warn in case the module has reference data and it is not marked as so or in case it is marked and it doesn't contain reference data.

---
M src/org/openbravo/service/system/ModuleValidator.java
---
(0047590)
migueldejuana   
2012-04-16 16:15   
Test plan:
* Create a module
* Adds a dataset at System level
* DON'T check the 'Has reference data'
* Export/package the module
* It should show a warning: Module 'moduleName' has Dataset associated but it has not been marked as 'has reference data'
* Remove previously added dataset
* check the 'Has reference data'
* Export/package the module
* It should show a warning: Module 'moduleName' has been marked as 'has reference data' but it has no Dataset associated



It should be no risky.
(0047595)
AugustoMauch   
2012-04-16 17:46   
Code reviewed and verified in pi@61bfbed9ea6e
(0047719)
migueldejuana   
2012-04-18 18:01   
changeset: 16098:61bfbed9ea6e
user: Miguel de Juana <miguel.dejuana@openbravo.com>
date: Mon Apr 16 16:46:16 2012 +0200
summary: Related to 15195: Fixed typo.
(0047812)
hudsonbot   
2012-04-21 14:23   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2eb57286c1fc [^]

Maturity status: Test