Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0015126Openbravo ERPA. Platformpublic2010-11-08 11:402020-06-26 07:09
Reportershuehner 
Assigned Tocberner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR20Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0015126: create.database.database fails with db-name like 'org.openbravo.base.seam' on postgres
DescriptionWhen using a database-name or user-name with a dot '.' in it then the current build.xml/build-create.xml fail to properly quote the value and thus at least create.database (probably more) tasks fails.

Note: if that should be supported all tasks need to be tested/fixed to add proper quoting.

A mini-test showed that on pgsql double-quotes are necessary and single-quote do not work to fix this issue
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0043952 closed cberner ant create.database on postgresql fails with username containing @ symbol 
Attached Filesdiff 15126_incomplete.diff (1,360) 2010-11-08 11:41
https://issues.openbravo.com/file_download.php?file_id=3302&type=bug
Issue History
Date ModifiedUsernameFieldChange
2010-11-08 11:40shuehnerNew Issue
2010-11-08 11:40shuehnerAssigned To => alostale
2010-11-08 11:40shuehnerOBNetwork customer => No
2010-11-08 11:41shuehnerFile Added: 15126_incomplete.diff
2010-11-08 11:41shuehnerNote Added: 0032463
2010-11-15 08:07alostaleStatusnew => scheduled
2010-11-15 08:07alostaleAssigned Toalostale => marvintm
2010-11-15 08:07alostalefix_in_branch => pi
2012-06-12 15:49alostaleTypedefect => design defect
2012-06-12 15:49alostalefix_in_branchpi =>
2012-09-24 23:25AugustoMauchNote Added: 0052465
2012-09-24 23:25AugustoMauchPrioritylow => normal
2018-04-08 16:49shuehnerAssigned Tomarvintm => platform
2020-05-05 18:20shuehnerRelationship addedrelated to 0043952
2020-06-12 14:33cbernerNote Added: 0120832
2020-06-12 14:33cbernerAssigned Toplatform => cberner
2020-06-16 08:19cbernerReview Assigned To => alostale
2020-06-16 08:19cbernerTriggers an Emergency Pack => No
2020-06-24 09:22hgbotCheckin
2020-06-24 09:22hgbotNote Added: 0121009
2020-06-24 09:22hgbotStatusscheduled => resolved
2020-06-24 09:22hgbotResolutionopen => fixed
2020-06-24 09:22hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4ca657b8d22de22881085b0d0478f338b4314a9a [^]
2020-06-26 07:09alostaleStatusresolved => closed
2020-06-26 07:09alostaleFixed in Version => 3.0PR20Q3

Notes
(0032463)
shuehner   
2010-11-08 11:41   
Added incomplete prototype which add the necessary quoting to create.database on postgres. Not completely tested or finished but shows the needed type of changes.
(0052465)
AugustoMauch   
2012-09-24 23:25   
Effort: 1
Impact: low
Plan: mid
(0120832)
cberner   
2020-06-12 14:33   
Merge Request: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/84 [^]
(0121009)
hgbot   
2020-06-24 09:22   
Repository: erp/devel/pi
Changeset: 4ca657b8d22de22881085b0d0478f338b4314a9a
Author: Cristian Berner <cristian.berner <at> openbravo.com>
Date: Fri Jun 12 14:23:59 2020 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4ca657b8d22de22881085b0d0478f338b4314a9a [^]

Fixes ISSUE-15126: Fixes create.database when database name contains dot

Database name is now sorrounded by quotes in build-create.xml, allowing more names to be
used as a database name on database creation, names like
org.openbravo.seam now are permitted

---
M src-db/database/build-create.xml
---