Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0014818Openbravo ERPA. Platformpublic2010-10-07 14:142010-10-20 00:00
Reportershuehner 
Assigned Tomtaal 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version2.50MP23Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0014818: Check for views on each dal-startup are to 'verbose'
DescriptionNow that DAL supports views the ad_column definition for views needs to conform to the usual rules (i.e. for a column named ad_client_id a table named ad_client) needs to exist.

Some modules contain incorrect definitions for their views as up to now and could get away with it as i.e. those might be in an ad_column entry which is not used (example used by an not display ad_field record only).

As module owners cannot be expected to fix this for all modules immediately and may need some month (and no urgency for them, if they don't use their views via dal (which they couldn't so far)) the warning display needs to be not so intrusive like it is now.

I.e. use the 'usual' policy of 'warning' developers and 'not scaring' users.
Steps To Reproduceon current pi
install org.openbravo.advpaymentmngt module (i.e. latest hg)
see output of any dal-startup (tomcat startup, generate.entities)
Proposed SolutionChange logging output to be not so intrusive (i.e. no stacktrace if they don't give a benefit (i.e. BaseForeignKeyDomainType:51 perhaps) and downgrade loglevels for the other errors perhaps (warning or info or nothing (perhaps only for views as for normal tables those checks should probably stay at level error like they are now))
Additional Information
TagsNo tags attached.
Relationships
related to defect 0014817 closed mirurita This module contains incorrect ad_column definitions for some of its views 
Attached Filestxt generate.entities.txt (55,834) 2010-10-07 14:15
https://issues.openbravo.com/file_download.php?file_id=3189&type=bug
Issue History
Date ModifiedUsernameFieldChange
2010-10-07 14:14shuehnerNew Issue
2010-10-07 14:14shuehnerAssigned To => alostale
2010-10-07 14:15shuehnerAssigned Toalostale => mtaal
2010-10-07 14:15shuehnerRelationship addedrelated to 0014817
2010-10-07 14:15shuehnerFile Added: generate.entities.txt
2010-10-07 17:25shuehnerNote Added: 0031652
2010-10-11 08:57alostaleStatusnew => scheduled
2010-10-11 08:57alostalefix_in_branch => pi
2010-10-14 19:34hgbotCheckin
2010-10-14 19:34hgbotNote Added: 0031860
2010-10-14 19:34hgbotStatusscheduled => resolved
2010-10-14 19:34hgbotResolutionopen => fixed
2010-10-14 19:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/8f1e3114223e139c894ec23a272731dc9398ee34 [^]
2010-10-18 17:39hudsonbotCheckin
2010-10-18 17:39hudsonbotNote Added: 0031929
2010-10-19 10:27marvintmNote Added: 0031955
2010-10-19 10:27marvintmStatusresolved => closed
2010-10-20 00:00anonymoussf_bug_id0 => 3090872

Notes
(0031652)
shuehner   
2010-10-07 17:25   
Note: The example module used in the description did already fix the issue a week ago. To reproduce it use a hg version not including the changeset below:

Fixed in revision 627:0ce4317b52d5 (30th Sept)
https://code.openbravo.com/erp/pmods/org.openbravo.advpaymentmngt/rev/0ce4317b52d5 [^]
(0031860)
hgbot   
2010-10-14 19:34   
Repository: erp/devel/pi
Changeset: 8f1e3114223e139c894ec23a272731dc9398ee34
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Thu Oct 14 19:34:11 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/8f1e3114223e139c894ec23a272731dc9398ee34 [^]

fixes issue 14818: Check for views on each dal-startup are to 'verbose'

---
M src/build.xml
M src/org/openbravo/base/gen/GenerateEntitiesTask.java
M src/org/openbravo/base/gen/ModelProviderComponent.java
M src/org/openbravo/base/gen/gen_entity.oaw
M src/org/openbravo/base/model/Column.java
M src/org/openbravo/base/model/ModelProvider.java
M src/org/openbravo/base/model/domaintype/BaseForeignKeyDomainType.java
M src/org/openbravo/base/session/OBPropertiesProvider.java
---
(0031929)
hudsonbot   
2010-10-18 17:39   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/8f1e3114223e [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/e1c7df1ae349 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18559.obx [^]
(0031955)
marvintm   
2010-10-19 10:27   
Checked that when installing an old version of the module which still doesn't have the fixes for the views issue, no warnings or errors were raised on the rebuild window.