Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0014734Openbravo ERP09. Financial managementpublic2010-09-30 09:182010-10-30 11:24
Reporternetworkb 
Assigned Tosathiyan 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Version2.50MP22 
Target Version2.50MP24Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0014734: the accounting entries generated by a cash with glitem is wrong
Description. if you have got a cash, and the lines are gl item, the acconting entries generated to post, are with account credit.
The account correct should be credit if the amount is positive, and debit if amount is negative
Steps To Reproduce. Financial Management || Accounting || Setup || G/L Item || G/L Item
 new record
  Enable in Cash checked
  name test

.Financial Management || Accounting || Setup || G/L Item || G/L Item >> Accounting
 Glitem debit acct 6000
 Glitem credit acct 6100

. Financial Management || Receivables & Payables || Transactions || Cash Journal || Header
 new record

. Financial Management || Receivables & Payables || Transactions || Cash Journal || Lines
 new line:
   cash type gl/item
   gl/item test
   amount 100

. Financial Management || Receivables & Payables || Transactions || Cash Journal || Lines
 new line:
   cash type gl/item
   gl/item test
   amount -200

. process and post

accountring entry generated is:
  account debit credit
  610 -100 0
  610 200 0
  570 0 100

the accounting entry should be:
acct debit credit
600 -100 0
610 200 0
570 0 100
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng Acct entries.PNG (106,410) 2010-10-22 07:44
https://issues.openbravo.com/file_download.php?file_id=3264&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2010-09-30 09:18networkbNew Issue
2010-09-30 09:18networkbAssigned To => dalsasua
2010-10-18 09:05sathiyanStatusnew => scheduled
2010-10-18 09:05sathiyanfix_in_branch => pi
2010-10-18 09:06sathiyanAssigned Todalsasua => sathiyan
2010-10-18 10:33sathiyanNote Added: 0031897
2010-10-18 10:35sathiyanStatusscheduled => feedback
2010-10-18 12:18networkbfix_in_branchpi =>
2010-10-18 12:18networkbSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=1078#r1078
2010-10-18 12:43networkbSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=1081#r1081
2010-10-18 12:44networkbNote Added: 0031905
2010-10-18 12:45networkbStatusfeedback => new
2010-10-18 14:49sathiyanNote Added: 0031910
2010-10-18 14:49sathiyanStatusnew => feedback
2010-10-18 15:54networkbNote Added: 0031914
2010-10-18 15:55networkbStatusfeedback => new
2010-10-18 15:55networkbSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=1088#r1088
2010-10-19 06:27hgbotCheckin
2010-10-19 06:27hgbotNote Added: 0031945
2010-10-19 06:27hgbotStatusnew => resolved
2010-10-19 06:27hgbotResolutionopen => fixed
2010-10-19 06:27hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/029b1eeaade05d602cc0658b87951fb83441d8a0 [^]
2010-10-19 12:57hudsonbotCheckin
2010-10-19 12:57hudsonbotNote Added: 0031967
2010-10-22 07:44sureshbabuNote Added: 0032092
2010-10-22 07:44sureshbabuStatusresolved => closed
2010-10-22 07:44sureshbabuFile Added: Acct entries.PNG
2010-10-30 11:24anonymoussf_bug_id0 => 3098738

Notes
(0031897)
sathiyan   
2010-10-18 10:33   
However I have got accounting entry like below:
61000 -100.00 (see the difference here in sign)
61000 200.00 (see the difference here in sign)
57000 100.00
(0031905)
networkb   
2010-10-18 12:44   
sorry, the steps to reproduce was wrong.
I have updated it.
(0031910)
sathiyan   
2010-10-18 14:49   
Thank you very much for my previous query clarification.
just make sure the following
option 1:
the accounting entry should be(your expectation):
  account debit credit
  610 -100 0
  600 0 -200
  570 0 100
option 2(accounting id for gl item cash in existing system) :
60000 -100.00 0 (see the difference in account id)
61000 0 -200.00 (see the difference in account id)
57000 0 100.00

Are you very much sure you are expecting option 1. I want to avoid regression, So that I want to get very clear confirmation before pushing my fix.

Regards
(0031914)
networkb   
2010-10-18 15:54   
Ok, again, the steps to reproduce is not correct.
the result expected should be:
acct debit credit
600 -100 0
610 200 0
570 0 100

The error is in account selected (610) in first line, the correct is 600. the sign is OK.
(0031945)
hgbot   
2010-10-19 06:27   
Repository: erp/devel/pi
Changeset: 029b1eeaade05d602cc0658b87951fb83441d8a0
Author: Sathiyan Sivaprakasam <sathiyan.sivaprakasam <at> openbravo.com>
Date: Tue Oct 19 09:56:45 2010 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/029b1eeaade05d602cc0658b87951fb83441d8a0 [^]

Fixes Issue 14734: the accounting entries generated by a cash with glitem is wrong

---
M src/org/openbravo/erpCommon/ad_forms/DocCash.java
---
(0031967)
hudsonbot   
2010-10-19 12:57   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/029b1eeaade0 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/47154c0fec32 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18561.obx [^]
(0032092)
sureshbabu   
2010-10-22 07:44   
retested, and i am getting the entries as per the attached screen shot