Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0014730Openbravo ERP07. Sales managementpublic2010-09-29 19:152010-10-26 13:56
Reporterpsarobe 
Assigned Toadrianromero 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version2.50MP23Fixed in Version2.50MP23 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0014730: CreateLines from is not working well: Lines with 0.00 can be selected
DescriptionIn the create lines from you can select lines with quantity 0.00 and this is wrong.
Steps To Reproduce1. Create a standard order with two lines
2. Create a goods shipment based on the above sales order and just with one of the lines using the button "Create lines from. Complete the document
3. Create a goods shipment based on the above sales order using the button "Create lines from". You will see that you can select the line you selected before but the quantity is 0.00. This is wrong

Expected behaviour: You only can select the pending line

This is a regression

See attach
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00150352.50MP23 closed adrianromero Not able to create Goods receipt, for a order which is created with -ve quantity using create line from button in Good receipt 
Attached Filespng Createlinesfrom.PNG (42,410) 2010-09-29 19:15
https://issues.openbravo.com/file_download.php?file_id=3139&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2010-09-29 19:15psarobeNew Issue
2010-09-29 19:15psarobeAssigned To => adrianromero
2010-09-29 19:15psarobeFile Added: Createlinesfrom.PNG
2010-09-29 19:16psarobeTag Attached: Regression QA
2010-09-29 19:16psarobeStatusnew => scheduled
2010-09-29 19:16psarobefix_in_branch => pi
2010-10-01 11:20hgbotCheckin
2010-10-01 11:20hgbotNote Added: 0031537
2010-10-01 11:20hgbotStatusscheduled => resolved
2010-10-01 11:20hgbotResolutionopen => fixed
2010-10-01 11:20hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/331c9ca70ae97a9eb00790b86cfc2369ef7d032c [^]
2010-10-01 11:22adrianromeroNote Added: 0031538
2010-10-08 20:59hudsonbotCheckin
2010-10-08 20:59hudsonbotNote Added: 0031712
2010-10-13 16:26psarobeNote Added: 0031814
2010-10-13 16:26psarobeStatusresolved => closed
2010-10-13 16:26psarobeFixed in Version => 2.50MP23
2010-10-14 00:00anonymoussf_bug_id0 => 3086974
2010-10-26 13:56psarobeTag Detached: Regression QA
2010-10-26 13:56psarobeRelationship addedrelated to 0015035

Notes
(0031537)
hgbot   
2010-10-01 11:20   
Repository: erp/devel/pi
Changeset: 331c9ca70ae97a9eb00790b86cfc2369ef7d032c
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Fri Oct 01 11:19:40 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/331c9ca70ae97a9eb00790b86cfc2369ef7d032c [^]

Fixes issue 0014730: CreateLines from is not working well: Lines with 0.00 can be selected
It has been added a filter to the SQL sentence that retrieves the lines to not get lines with remaining quantity to deliver equals to 0

---
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Shipment_data.xsql
---
(0031538)
adrianromero   
2010-10-01 11:22   
* Steps to test

Just follow the steps to test and notice that now lines with quantity equals to 0 do not appear

* Other areas affected

No other areas affected.
(0031712)
hudsonbot   
2010-10-08 20:59   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/331c9ca70ae9 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/f476e192559f [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18505.obx [^]
(0031814)
psarobe   
2010-10-13 16:26   
Tested working fine. Additional test cases executed to ensure the flow works fine