Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001472Openbravo ERP00. Application dictionarypublic2007-06-29 17:312008-07-08 12:08
Reporterjaimetorre 
Assigned Tocromero 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version2.40alpha-r2 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0001472: Incorrect default values when Creating From DB in PostgreSQL
DescriptionDescription:
The process 'Create Columns from DB' doesn't get correct default values for the different data types (in PostgreSQL).

For example, in Oracle, the fields 'char(1 byte)' are imported as 'Yes/No' columns. In PostgreSQL, they are imported as 'String' with length -1. The 'Mandatory' check is also incorrectly selected. All these default valules should be revised.

Enviroment:
OS: Linux
DB: PostgreSQL
Browser: FF2
Openbravo: 2.31 beta
Language: English

Steps:
1. Create a table in database.
2. As System Administrator go to 'Application Dictionary > Table and Column'
3. Define a new table in this window.
4. Press the 'Create Columns from DB' button.
5. Navigate to the 'Column' tab and check for each column the fields: length, reference, mandatory, updateable
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2008-07-08 12:08psarobeStatusresolved => closed

Notes
(0005061)
user71   
2005-06-01 00:00   
(edited on: 2008-06-12 09:43)
This bug was originally reported in SourceForge bug tracker and then migrated to Mantis.

You can see the original bug report in:
https://sourceforge.net/support/tracker.php?aid=1745386 [^]
(0001381)
cromero   
2007-07-04 11:41   
(edited on: 2008-06-12 09:19)
Logged In: YES
user_id=1500614
Originator: NO

It's a problem of our implementation of view USER_TAB_COLUMNS that doesn't exit in Postgre.
When the attribute type is varying, PG_ATTRIBUTE.ATTLEN returns -1.
We have modified the view in order to return a correct value for that casses.
Here is the new code. It will be included in future releases.

Carlos Romero
Openbravo Team

CREATE OR REPLACE VIEW USER_TAB_COLUMNS
(TABLE_NAME, COLUMN_NAME, DATA_TYPE, DATA_LENGTH, DATA_PRECISION, DATA_SCALE, DATA_DEFAULT, NULLABLE, COLUMN_ID)
AS
SELECT UPPER(PG_CLASS.RELNAME), UPPER(PG_ATTRIBUTE.ATTNAME), UPPER(PG_TYPE.TYPNAME), CASE PG_ATTRIBUTE.ATTLEN WHEN -1 THEN PG_ATTRIBUTE.ATTTYPMOD-4 ELSE PG_ATTRIBUTE.ATTLEN END,10, 0, CASE PG_ATTRIBUTE.ATTHASDEF WHEN TRUE THEN(SELECT PG_ATTRDEF.ADSRC FROM PG_ATTRDEF WHERE PG_ATTRDEF.ADRELID = PG_CLASS.OID AND PG_ATTRDEF.ADNUM = PG_ATTRIBUTE.ATTNUM) ELSE NULL END, PG_ATTRIBUTE.ATTNOTNULL, PG_ATTRIBUTE.ATTNUM
FROM PG_CLASS, PG_NAMESPACE, PG_ATTRIBUTE, PG_TYPE
WHERE PG_ATTRIBUTE.ATTRELID = PG_CLASS.OID
AND PG_ATTRIBUTE.ATTTYPID = PG_TYPE.OID
AND PG_CLASS.RELNAMESPACE = PG_NAMESPACE.OID
AND PG_NAMESPACE.NSPNAME = CURRENT_SCHEMA()
AND PG_ATTRIBUTE.ATTNUM>0;
(0001382)
plujan   
2007-11-06 16:37   
(edited on: 2008-06-12 09:19)
Logged In: YES
user_id=1759992
Originator: NO

This bug seems to be present on R2.35
(0001383)
cromero   
2007-11-06 18:14   
(edited on: 2008-06-12 09:19)
Logged In: YES
user_id=1500614
Originator: NO

Correction has been lost in r2.33.
We have recovered it and it's now available in SVN repository.

Carlos Romero
Openbravo Team