Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0014580Openbravo ERPA. Platformpublic2010-09-15 19:162022-02-01 08:08
Reporterjpabloae 
Assigned ToTriage Platform Base 
PrioritynormalSeverityminorReproducibilityalways
StatusacknowledgedResolutionopen 
PlatformOS20OS VersionCommunity Appliance
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0014580: Packaging a template should consider the MAJOR end-version enforcements
DescriptionWhen packaging a template, if the included modules have a end-version with a MAJOR enforcement then it should take this into account when running version validations.

Example:

$ ant package.module -Dmodule=org.openbravo.v3
Buildfile: build.xml

package.module:
     [echo] Validating Module...
[validateModules] 0 [main] ERROR SystemValidation -
[validateModules]
[validateModules] +++++++++++++++++++++++++++++++++++++++++++++++++++
[validateModules] Errors for Validation type: MODULE_ERROR
[validateModules] +++++++++++++++++++++++++++++++++++++++++++++++++++
[validateModules] Openbravo 3.0 Framework defines dependency on core end version 3.0.8291, but actual version in DB is 3.0.8293
[validateModules] User Interface Application defines dependency on core end version 3.0.8291, but actual version in DB is 3.0.8293
[validateModules] User Interface Selector defines dependency on core end version 3.0.8291, but actual version in DB is 3.0.8293
[validateModules] User Interface Freemarker defines dependency on core end version 3.0.8291, but actual version in DB is 3.0.8293
[validateModules] JSON Datasource defines dependency on core end version 3.0.8291, but actual version in DB is 3.0.8293
[validateModules] Seam defines dependency on core end version 3.0.8291, but actual version in DB is 3.0.8293
[validateModules] Smartclient defines dependency on core end version 3.0.8291, but actual version in DB is 3.0.8293
[validateModules] Openbravo 3.0 Navigation Bar Components defines dependency on core end version 3.0.8291, but actual version in DB is 3.0.8293
[validateModules] 2.50 to 3.00 Compatibility Skin defines dependency on core end version 3.0.8291, but actual version in DB is 3.0.8293
[validateModules] User Interface Client Kernel defines dependency on core end version 3.0.8291, but actual version in DB is 3.0.8293
[validateModules] JSON REST Webservice defines dependency on core end version 3.0.8291, but actual version in DB is 3.0.8293

obx.export.database:

obx.export.config.script:

BUILD SUCCESSFUL
Total time: 23 seconds
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0014724 closed alostale Error message should be warning when package a module. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-09-15 19:16jpabloaeNew Issue
2010-09-15 19:16jpabloaeAssigned To => alostale
2010-09-15 19:16jpabloaeOBNetwork customer => No
2010-09-15 19:18shuehnerIssue Monitored: shuehner
2010-10-04 08:42alostaleRelationship addedrelated to 0014724
2010-10-04 08:42alostaleStatusnew => scheduled
2010-10-04 08:42alostalefix_in_branch => pi
2012-09-18 09:58alostaleNote Added: 0052186
2012-09-18 09:58alostaleTypedefect => design defect
2012-09-18 09:58alostalefix_in_branchpi =>
2017-03-31 14:36alostaleStatusscheduled => acknowledged
2017-04-10 14:34alostaleAssigned Toalostale => platform
2022-02-01 08:08alostaleAssigned Toplatform => Triage Platform Base

Notes
(0052186)
alostale   
2012-09-18 09:58   
It is designed to work in this way in case of inclusion to ensure included obx are the same as the defined ones in the dependencies.

It might be reconsidered this practice.

This is the code in ModuleValidator:
 // for inclusions check the dependency matches exactly with the defined one
        if (!depActualVersion.equals(firstVer)) {
          result.addWarning(SystemValidationType.MODULE_ERROR, module.getName()
              + " defines inclussion of module " + dependentModule.getDependentModule().getName()
              + " in version " + firstVer + ", but actual version in DB is " + depActualVersion
              + ". They must exactly match.");