Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0014531Openbravo ERP07. Sales managementpublic2010-09-13 20:012010-10-13 18:57
Reportertgarcia 
Assigned Tomohankumar 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Version 
Target VersionFixed in Version2.50MP23 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0014531: Using Comma as decimal separator causes malfunctions on Sales Invoice Lines
Description- Change all "decimal" fields in config/Format.xml to "," and all "grouping" fields to ".".
- Smartbuild => war => deploy.context
- Create a Sales invoice and a line inside of it;
- Select a product with a default price != 0 associated with it from the product popup box, in the sales invoice line window.
- Should that product's default price be 12,345, the imported "net unit price" is 12345,000 and the imported "Net List Price" is 12,000.
Steps To Reproduce- Change all "decimal" fields in config/Format.xml to "," and all "grouping" fields to ".".
- Smartbuild => war => deploy.context
- Create a Sales invoice and a line inside of it;
- Select a product with a default price != 0 associated with it from the product popup box, in the sales invoice line window.
- Should that product's default price be 12,345, the imported "net unit price" is 12345,000 and the imported "Net List Price" is 12,000.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00133202.50MP18 closed adrianromero Different behaviour when changing decimal separator 
related to defect 00133252.50MP18 closed harikrishnan The application does not work properly depending Format's and PostgreSQL's configuration 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-09-13 20:01tgarciaNew Issue
2010-09-13 20:01tgarciaAssigned To => adrianromero
2010-09-14 11:56adrianromeroRelationship addedrelated to 0013320
2010-09-14 11:57adrianromeroRelationship addedrelated to 0013325
2010-09-14 12:03adrianromeroRelationship replacedduplicate of 0013325
2010-09-14 12:03adrianromeroNote Added: 0031029
2010-09-14 12:03adrianromeroStatusnew => closed
2010-09-14 12:03adrianromeroResolutionopen => duplicate
2010-09-14 18:30tgarciaNote Added: 0031062
2010-09-15 00:00anonymoussf_bug_id0 => 3066293
2010-09-16 11:31adrianromeroRelationship replacedrelated to 0013325
2010-09-16 11:33adrianromeroNote Added: 0031147
2010-09-16 11:33adrianromeroStatusclosed => new
2010-09-16 11:33adrianromeroResolutionduplicate => open
2010-10-11 10:37mohankumarAssigned Toadrianromero => mohankumar
2010-10-11 13:10hgbotCheckin
2010-10-11 13:10hgbotNote Added: 0031753
2010-10-11 13:10hgbotStatusnew => resolved
2010-10-11 13:10hgbotResolutionopen => fixed
2010-10-11 13:10hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/346733f763b750d4fbbf1b596194cd28edbca1d4 [^]
2010-10-11 22:21hudsonbotCheckin
2010-10-11 22:21hudsonbotNote Added: 0031769
2010-10-12 07:37mohankumarNote Added: 0031777
2010-10-13 18:57psarobeNote Added: 0031827
2010-10-13 18:57psarobeStatusresolved => closed
2010-10-13 18:57psarobeFixed in Version => 2.50MP23

Notes
(0031029)
adrianromero   
2010-09-14 12:03   
Hello.

This issue is a duplicate of issue 13325. In 13325 after changing the file Format.xml, the net unit price calculated is wrong.

Kindly test the issue with in the latest Openbravo ERP version. If you find differences between your issue and the issue fixed in 13325 and you still can reproduce the issue in the latest Openbravo ERP version. Feel free to reopen the issue.

Thanks for reporting the issue.
(0031062)
tgarcia   
2010-09-14 18:30   
Hello,

Sorry for reporting a duplicate issue :(

Just did some tests on 2.50MP21. "Net unit price" is ok, but "Net List Price" is still displays the incorrect behaviour described initially on this bug report.
(0031147)
adrianromero   
2010-09-16 11:33   
The field that has to be fixed is "Net unit price". The fix will be similar to the fix done in issue 13325 for field "Net list price"
(0031753)
hgbot   
2010-10-11 13:10   
Repository: erp/devel/pi
Changeset: 346733f763b750d4fbbf1b596194cd28edbca1d4
Author: Mohankumar Swaminathan <mohankumar.swaminathan <at> gmail.com>
Date: Mon Oct 11 15:57:32 2010 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/346733f763b750d4fbbf1b596194cd28edbca1d4 [^]

Fixes Issue 14531: Using Comma as decimal separator causes malfunctions on Sales Invoice Lines

---
M src/org/openbravo/erpCommon/ad_callouts/SL_Invoice_Product.java
---
(0031769)
hudsonbot   
2010-10-11 22:21   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/346733f763b7 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/68694c340492 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18513.obx [^]
(0031777)
mohankumar   
2010-10-12 07:37   
Steps to Test

1.Change all "decimal" fields in config/Format.xml to "," and all "grouping" fields to ".".
2.ant Smartbuild
3.select Master Data Management || Product || Product >> Price >> select standard price of a product(example: Food) to 40.00
4.select Sales Management || Transactions || Sales Invoice || Header >> Lines >> select the product Food
5.Then the imported "net unit price" is 40.00 and the imported "Line Net Amount" is 80.00.
6.And verify the net unit price and Line Net Amount
(0031827)
psarobe   
2010-10-13 18:57   
Tested working fine