Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0014509Openbravo ERP04. Warehouse managementpublic2010-09-09 18:152010-09-29 11:57
Reporternetworkb 
Assigned Toharikrishnan 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version2.50MP21 
Target Version2.50MP22Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0014509: The fields of the 'Product Complete' selector does not work
DescriptionWhen you complete a purchase order the fields 'Quant. of order','order no.' of the productor don't show this change.
Steps To Reproduce- As Openbravo Admin go to Procurement Management || Transactions || Purchase Order
- Create a new one
- Go to Lines (product wood slice: hammer; quantity:100)
- Complete the order

- Go to Warehouse Management || Transactions || Physical Inventory || Header >> Lines
- Open de product's selector
- select hammer
- realize that the fields does not show anything
Proposed SolutionModify the labels of this selector according the note posted by gorkaion.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0015303 closed adrianromero Localization Pack: Spain The columns of the Product Complete are not translated properly 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-09-09 18:15networkbNew Issue
2010-09-09 18:15networkbAssigned To => adrianromero
2010-09-09 18:20psarobeNote Added: 0030907
2010-09-09 18:20psarobeStatusnew => feedback
2010-09-09 18:26networkbNote Added: 0030908
2010-09-09 18:31networkbStatusfeedback => new
2010-09-09 19:07psarobeNote Added: 0030910
2010-09-13 11:17adrianromeroStatusnew => scheduled
2010-09-13 11:17adrianromerofix_in_branch => pi
2010-09-13 13:40gorkaionNote Added: 0030990
2010-09-13 15:52adrianromerofix_in_branchpi =>
2010-09-13 15:52adrianromeroProposed Solution updated
2010-09-21 08:11harikrishnanAssigned Toadrianromero => harikrishnan
2010-09-21 08:11hgbotCheckin
2010-09-21 08:11hgbotNote Added: 0031248
2010-09-21 08:11hgbotStatusscheduled => resolved
2010-09-21 08:11hgbotResolutionopen => fixed
2010-09-21 08:11hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/8511be48f0f87b6d1186b5a872a9dba80334bd16 [^]
2010-09-21 08:14harikrishnanNote Added: 0031249
2010-09-23 13:25sureshbabuNote Added: 0031326
2010-09-23 13:25sureshbabuStatusresolved => closed
2010-09-24 00:00anonymoussf_bug_id0 => 3074390
2010-09-29 11:57hudsonbotCheckin
2010-09-29 11:57hudsonbotNote Added: 0031448
2011-01-27 13:50dalsasuaRelationship addedrelated to 0015303

Notes
(0030907)
psarobe   
2010-09-09 18:20   
Which is the expected behaviour? A Link to the documentation would be appreciate in order to analyse whether it is an issue or not

Thanks
(0030908)
networkb   
2010-09-09 18:26   
There is not documentation about the fields of the selector.
The behaviour expected is the following:

- If we have two order (15 hammers + 30 hammers) completed in the field 'Quant. of order' should be appear 45.
(0030910)
psarobe   
2010-09-09 19:07   
Ok, thanks but we still need to know whether it is an issue or not.

Adrian you need to talk with Gorka to know what is the expected behaviour here. Until then we must not do anything
(0030990)
gorkaion   
2010-09-13 13:40   
The labels of the columns of this selector are not helpful at all.

I've checked what is shown. The quantities are retrieved from the M_Storage_detail table when the 'With stock' flag is checked. If not they are defaulted to 0.

* Key, Name, Warehouse, Quantity, Unit and Attribute are clear.
* Quant. of order: This is the stocked quantity on the Order UOM.
* Order No.: This is the Order UOM, shown only in the case that the product is using it.
* Quant. Served: This is the PreQtyOnHand column of the m_storage_detail table. It is loaded with the quantity of the product on transactions that are on 'Draft' status.
* Quant. of order delivered: Same as the previous one but on the Order UOM.

The labels should be fixed to indicate properly what is shown on each column, specially the 'Order No.'.

These are my proposals, I've taken them from the element's names of the related columns (current label, related column on m_storage_detail, proposed label)
* Quantity, QtyOnHand, Quantity on Hand
* Quant. of order, QtyOrderOnHand, On Hand Quantity order
* Order No., M_Product_UOM_Id, Order UOM
* Quant. Served, PreQtyOnHand, Quantity in draft transactions
* Quant. of order delivered, PreQtyOrderOnHand, Quantity Order in draft transactions

The quantities that are shown are working as expected.
(0031248)
hgbot   
2010-09-21 08:11   
Repository: erp/devel/pi
Changeset: 8511be48f0f87b6d1186b5a872a9dba80334bd16
Author: Harikrishnan Raja <harikrishnan.raja <at> openbravo.com>
Date: Tue Sep 21 11:40:58 2010 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/8511be48f0f87b6d1186b5a872a9dba80334bd16 [^]

Fixes Issue 14509: The fields of the 'Product Complete' selector does not work

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/erpCommon/info/ProductComplete.java
---
(0031249)
harikrishnan   
2010-09-21 08:14   
Steps to test:

*The labels of the selector are changed according to the solution given by Gorka Ion.
These are the changes:
* Quantity ==> Quantity on Hand
* Quant. of order==> On Hand Quantity order
* Order No.==> Order UOM
* Quant. Served==>Quantity in draft transactions
* Quant. of order delivered==> Quantity Order in draft transactions

Impact:
Their is no impact because of this fix.
(0031326)
sureshbabu   
2010-09-23 13:25   
following changes are made in product selector window

* Quantity ==> Quantity on Hand
* Quant. of order==> On Hand Quantity order
* Order No.==> Order UOM
* Quant. Served==>Quantity in draft transactions
* Quant. of order delivered==> Quantity Order in draft transactions
(0031448)
hudsonbot   
2010-09-29 11:57   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/8511be48f0f8 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/51c2c2967221 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18452.obx [^]