Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0014448Openbravo ERP09. Financial managementpublic2010-09-06 14:162012-04-28 02:31
Reportersureshbabu 
Assigned Tovmromanos 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version2.50 
Target VersionFixed in Version3.0MP11 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0014448: Inconsistency in Add payment window
DescriptionInconsistency in Add payment window appears when i click "Add Payment" button from 'sales invoice' window and when i click "Add payment Details" button from 'Receive payment' window
Steps To Reproduce1) From Sales invoice when i click "Add Payment" button

Defect 1: Above the "Transaction Type" field there is a Text label appears "Select additional sales invoices or sales orders that you want to add to this payment" but this text label is missing in Add payment window which appears when i click Add payment details button from Payment Receivables window

Defect 2: From sales invoice window when i click Add payment button, in Add payment window, "Payment date" field appears but not in other window

Defect 3: From sales invoice window when i click Add payment button, in Add payment window, Label "Actual payment" is referred for current payment whereas in other window it is referred as Amount field

Defect 4: From sales invoice window when i click Add payment button, in Add payment window, "Received From" label is referred here but in other window it is referred as "Receiving From"

Defect 5: From sales invoice window when i click Add payment button, in Add payment window, "Customer balance" field appears but not in other window

Defect 6: From sales invoice window when i click Add payment button, in Add payment window, fields "Payment method", "Deposit To", "Currency" fields appears but not in other window
Proposed Solution
Additional Information
TagsMIR-Reviewed, OB3-Reviewed
Relationships
Attached Filespng Inconsistency in Add payment window.PNG (70,655) 2010-09-06 14:16
https://issues.openbravo.com/file_download.php?file_id=3032&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2010-09-06 14:16sureshbabuNew Issue
2010-09-06 14:16sureshbabuAssigned To => gorkaion
2010-09-06 14:16sureshbabuFile Added: Inconsistency in Add payment window.PNG
2010-09-06 19:30hgbotCheckin
2010-09-06 19:30hgbotNote Added: 0030666
2010-09-07 17:08gorkaionNote Added: 0030773
2010-09-07 18:03hgbotCheckin
2010-09-07 18:03hgbotNote Added: 0030774
2010-10-07 17:03miruritaNote Added: 0031648
2010-10-07 17:03miruritaStatusnew => feedback
2011-01-26 14:06rmorleyNote Added: 0033878
2011-01-26 16:06gorkaionNote Added: 0033879
2011-01-26 16:06gorkaionStatusfeedback => new
2011-02-03 11:19rgorisNote Added: 0034022
2011-02-11 17:16miruritaNote Added: 0034154
2011-09-16 18:51psarobeAssigned Togorkaion => mirurita
2011-09-16 18:51psarobeStatusnew => scheduled
2011-09-16 18:51psarobeCategoryZ. Others => 09. Financial management
2011-10-29 21:31psarobeAssigned Tomirurita => rgoris
2011-10-29 21:31psarobeTag Attached: OB3-Reviewed
2012-04-18 11:04alostaleAssigned Torgoris => vmromanos
2012-04-19 18:44miruritaTag Attached: MIR-Reviewed
2012-04-26 12:45miruritaNote Added: 0048015
2012-04-26 17:51hgbotCheckin
2012-04-26 17:51hgbotNote Added: 0048060
2012-04-26 17:51hgbotStatusscheduled => resolved
2012-04-26 17:51hgbotResolutionopen => fixed
2012-04-26 17:51hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/567eea69e702ac8bfb1b6016baf485e12c7570ac [^]
2012-04-26 17:52vmromanosNote Added: 0048061
2012-04-26 17:52vmromanosStatusresolved => closed
2012-04-26 17:52vmromanosFixed in Version => 3.0MP11
2012-04-28 02:31hudsonbotCheckin
2012-04-28 02:31hudsonbotNote Added: 0048163

Notes
(0030666)
hgbot   
2010-09-06 19:30   
Repository: erp/pmods/org.openbravo.advpaymentmngt
Changeset: e732e70a866ac32c76b7397ba19eec5df37e9adb
Author: Gorka Ion Damián <gorkaion.damian <at> openbravo.com>
Date: Mon Sep 06 19:29:28 2010 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.advpaymentmngt/rev/e732e70a866ac32c76b7397ba19eec5df37e9adb [^]

Related to issue 14448.Fixed name to show text only on not receipt case.

---
M src/org/openbravo/advpaymentmngt/ad_actionbutton/AddOrderOrInvoice.html
---
(0030773)
gorkaion   
2010-09-07 17:08   
Hi Suresh,

There are some expected differences on this popup windows as the window they are opened are also different. When the popup is opened from the Receive / Make Payment window most of the fields are already set on the header, so there is no need to add them again in the popup.

The differences on the label should be reviewed by Rob Goris to decide which is the correct term.

Defect 1: Fixed.
Defect 2 and 6: Those are fields that are already on the header of the payment, so no need to add them in the popup.
Defect 3 and 4: Rob should decide which is the desired term.
Defect 5: Pending to fix.
(0030774)
hgbot   
2010-09-07 18:03   
Repository: erp/pmods/org.openbravo.advpaymentmngt
Changeset: aa5dbcaf82917c1fd2ddc5b5d61f562fc042155d
Author: Gorka Ion Damián <gorkaion.damian <at> openbravo.com>
Date: Tue Sep 07 17:57:19 2010 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.advpaymentmngt/rev/aa5dbcaf82917c1fd2ddc5b5d61f562fc042155d [^]

Related to issue 14448.Added customer balance to add details on receive payment window.

---
M src/org/openbravo/advpaymentmngt/ad_actionbutton/AddOrderOrInvoice.html
M src/org/openbravo/advpaymentmngt/ad_actionbutton/AddOrderOrInvoice.java
M src/org/openbravo/advpaymentmngt/ad_actionbutton/AddOrderOrInvoice.xml
---
(0031648)
mirurita   
2010-10-07 17:03   
@Suresh: could you please ask Rob about this two issues? and if he thinks no changes are needed could you please close the issue.
If he suggest other naming, please add a note with the proposed solution.

Defect 3: From sales invoice window when i click Add payment button, in Add payment window, Label "Actual payment" is referred for current payment whereas in other window it is referred as Amount field

Defect 4: From sales invoice window when i click Add payment button, in Add payment window, "Received From" label is referred here but in other window it is referred as "Receiving From"
(0033878)
rmorley   
2011-01-26 14:06   
".....but in other window it is referred as..."
Which "other window" is being referred to here? Please clarify.
(0033879)
gorkaion   
2011-01-26 16:06   
Hi Richard,

The "other window" is the Receive Payment, which is now known as "Payment In"
(0034022)
rgoris   
2011-02-03 11:19   
I would like to postpone this one. For 3.0 GA i suggest to do some housekeeping in the APAR windows, also for layout and labeling. We can then include this issue.
(0034154)
mirurita   
2011-02-11 17:16   
Agree,
Thanks.
(0048015)
mirurita   
2012-04-26 12:45   
Testing Plan
1) Go to Payment In window
2) Create a new Payment In header
3) Click on Add Details button
4) Check the labels:
    - Actual Payment In
    - Received From


1) Go to Payment Out window
2) Create a new Payment Out header
3) Click on Add Details button
4) Check the labels:
    - Actual Payment Out
    - To Be Paid To
(0048060)
hgbot   
2012-04-26 17:51   
Repository: erp/devel/pi
Changeset: 567eea69e702ac8bfb1b6016baf485e12c7570ac
Author: Mikel Irurita <mikel.irurita <at> openbravo.com>
Date: Thu Apr 26 12:05:29 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/567eea69e702ac8bfb1b6016baf485e12c7570ac [^]

Fixes issue 14448: consistency in Add payment window labels
Amount --> Actual Payment In/Out
Receiving From --> Received From
Paying To --> To Be Paid To

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_TEXTINTERFACES.xml
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddOrderOrInvoice.html
---
(0048061)
vmromanos   
2012-04-26 17:52   
Code review + testing OK
(0048163)
hudsonbot   
2012-04-28 02:31   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cd923b317af4 [^]

Maturity status: Test