Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0014432Openbravo ERPA. Platformpublic2010-09-03 19:142010-09-13 12:38
Reporterpsarobe 
Assigned Toalostale 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionmain 
Target Version2.50MP21Fixed in Version2.50MP21 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0014432: Packs modules cannot be installed through file system
DescriptionPacks modules cannot be installed through file system.
Steps To Reproduce1. Login as Openbravo/openbravo
2. Go to General Setup || Application || Module Management || Add modules
3. Click Browse file system
4. Select SLP 1.4.3

Proposed Solution
Additional Information
TagsRegression QA
Relationships
Attached Filesdiff 14432_proposed_fix.diff (1,012) 2010-09-03 20:15
https://issues.openbravo.com/file_download.php?file_id=3027&type=bug
Issue History
Date ModifiedUsernameFieldChange
2010-09-03 19:14psarobeNew Issue
2010-09-03 19:14psarobeAssigned To => shuehner
2010-09-03 19:15psarobeStatusnew => scheduled
2010-09-03 19:15psarobefix_in_branch => pi
2010-09-03 19:46psarobeTag Attached: Regression QA
2010-09-03 20:12shuehnerNote Added: 0030611
2010-09-03 20:12shuehnerAssigned Toshuehner => alostale
2010-09-03 20:12shuehnerStatusscheduled => acknowledged
2010-09-03 20:15shuehnerNote Added: 0030612
2010-09-03 20:15shuehnerFile Added: 14432_proposed_fix.diff
2010-09-04 09:23jpabloaeIssue Monitored: jpabloae
2010-09-05 15:37hgbotCheckin
2010-09-05 15:37hgbotNote Added: 0030617
2010-09-05 15:37hgbotStatusacknowledged => resolved
2010-09-05 15:37hgbotResolutionopen => fixed
2010-09-05 15:37hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a14b8f864fb41cf3740d2a19372e65852a2bc602 [^]
2010-09-06 13:09psarobeNote Added: 0030643
2010-09-06 13:09psarobeStatusresolved => closed
2010-09-06 13:09psarobeFixed in Version => 2.50MP21
2010-09-07 09:18hudsonbotCheckin
2010-09-07 09:18hudsonbotNote Added: 0030718
2010-09-13 12:38anonymoussf_bug_id0 => 3065199

Notes
(0030611)
shuehner   
2010-09-03 20:12   
Verified, problem happens. From debugging all install from local obx file including other modules (Includes='Y', Packs) do not work correctly.
(0030612)
shuehner   
2010-09-03 20:15   
Attaching proposed bugfix:
When installing from local system the function modules2mods in VersionUtility.java calculates availableMinVer & availableMaxVer for all modules in the set.
Because of a wrong logic the availableMaxVer was never filled in, which breaks logic using that field later.
(0030617)
hgbot   
2010-09-05 15:37   
Repository: erp/devel/pi
Changeset: a14b8f864fb41cf3740d2a19372e65852a2bc602
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Sun Sep 05 11:32:56 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/a14b8f864fb41cf3740d2a19372e65852a2bc602 [^]

fixed bug 14432: Packs modules cannot be installed through file system

  Set current version as max and min available in case there are no other
  versions.

---
M src/org/openbravo/erpCommon/modules/VersionUtility.java
---
(0030643)
psarobe   
2010-09-06 13:09   
Tested working fine
(0030718)
hudsonbot   
2010-09-07 09:18   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/a14b8f864fb4 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/4390fe5213a4 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18274.obx [^]