Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0014382Openbravo ERP07. Sales managementpublic2010-08-30 20:112010-09-21 00:00
Reporternetworkb 
Assigned Toadrianromero 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version2.50MP20 
Target Version2.50MP22Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0014382: The filters 'all selected' and 'not selected' are too confusing
DescriptionIn some screens there are filters with the values 'all selected' and 'not selected'

This is always causing confusion to people, as well as in training as well as now in the support queue where we someone reporting a problem about.

The problem is the 'all selected' means 'you have to select some values and only those values will be included'. However, people read 'all selected' as that all values will be included.
The value 'not selected' means that you won't filter and that all values will be included, but again, people do not read it this way.
Steps To ReproduceThis is applicable to the following screens:

Sales Management || Setup || External Point of Sales || External Point of Sales
See the fields 'included product' and 'included product categories'

Master Data Management || Pricing || Price Adjustments || Adjustments
See the fields 'included BP categories', 'included Business Partners', 'included product categories', 'included products', 'include pricelists'
Proposed Solutionsuggestion to change the labels of the values
'all selected' could be 'selected values'
'not selected' could be 'all values'
but I'm sure that Rob Goris can comment about the best solution for this
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-08-30 20:11RenateNieuwkoopNew Issue
2010-08-30 20:11RenateNieuwkoopAssigned To => adrianromero
2010-08-30 20:11RenateNieuwkoopOBNetwork customer => Yes
2010-08-30 20:12RenateNieuwkoopReporterRenateNieuwkoop => networkb
2010-08-30 20:25RenateNieuwkoopNote Added: 0030484
2010-09-09 09:34jonalegriaesarteTarget Version => 2.50MP22
2010-09-09 11:56adrianromeroStatusnew => scheduled
2010-09-09 11:56adrianromerofix_in_branch => pi
2010-09-10 09:19dmitry_mezentsevNote Added: 0030923
2010-09-13 15:07rgorisNote Added: 0030993
2010-09-14 16:44hgbotCheckin
2010-09-14 16:44hgbotNote Added: 0031047
2010-09-14 16:44hgbotStatusscheduled => resolved
2010-09-14 16:44hgbotResolutionopen => fixed
2010-09-14 16:44hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/dc6c5efef83b9b2cdd8fae14904f52b298471656 [^]
2010-09-14 16:47adrianromeroNote Added: 0031048
2010-09-15 11:59rgorisNote Added: 0031076
2010-09-15 15:38hgbotCheckin
2010-09-15 15:38hgbotNote Added: 0031085
2010-09-15 15:38hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/dc6c5efef83b9b2cdd8fae14904f52b298471656 [^] => http://code.openbravo.com/erp/devel/pi/rev/71cf3dcc3b335135544ac920b5ea14bbf80b1e6d [^]
2010-09-15 20:55hudsonbotCheckin
2010-09-15 20:55hudsonbotNote Added: 0031119
2010-09-15 20:55hudsonbotCheckin
2010-09-15 20:55hudsonbotNote Added: 0031132
2010-09-20 08:53sureshbabuNote Added: 0031208
2010-09-20 08:53sureshbabuStatusresolved => closed
2010-09-21 00:00anonymoussf_bug_id0 => 3072191

Notes
(0030484)
RenateNieuwkoop   
2010-08-30 20:25   
In Spanish the values are labelled:

Todos los seleccionados
Los no seleccionados

Which is equally confusing
(0030923)
dmitry_mezentsev   
2010-09-10 09:19   
My proposal is

'all selected' could be 'Only selected'
'not selected' could be 'All' (while I would check just in case that it does not work like 'All excluding selected'.
(0030993)
rgoris   
2010-09-13 15:07   
I´d go along the lines of Dmitry´s proposal but I do not like the term "selected" as the user has not selected anything. In fact, it is about all child records that were created/defined.

So:

'all selected' becomes 'Only those defined' (I´d almost add "below" to make people understand the definition takes place in the child records, anything against this?)
'not selected' becomes 'All'

(while I would check just in case that it does not work like 'All excluding defined'.
(0031047)
hgbot   
2010-09-14 16:44   
Repository: erp/devel/pi
Changeset: dc6c5efef83b9b2cdd8fae14904f52b298471656
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Tue Sep 14 16:43:30 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/dc6c5efef83b9b2cdd8fae14904f52b298471656 [^]

Fixes issue 0014382: The filters 'all selected' and 'not selected' are too confusing
It has been modified the literals as agreed by *All* and *Only those defined*

---
M src-db/database/sourcedata/AD_REF_LIST.xml
---
(0031048)
adrianromero   
2010-09-14 16:47   
* Testing the issue

Go for example to Master Data Management || Pricing || Price Adjustments || Adjustments and verify that the possible values for fields Included BP Categories, Included Product Categories etc are All and Only those defined as agreed

* Other areas affected

It has only been modified the names of the possible values for the reference list "Offers" no other area affected.
(0031076)
rgoris   
2010-09-15 11:59   
As discussed over email:
Final solution must be:
[Only those defined]
[All excluding defined]
(0031085)
hgbot   
2010-09-15 15:38   
Repository: erp/devel/pi
Changeset: 71cf3dcc3b335135544ac920b5ea14bbf80b1e6d
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Wed Sep 15 15:38:15 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/71cf3dcc3b335135544ac920b5ea14bbf80b1e6d [^]

Fixes issue 0014382: The filters 'all selected' and 'not selected' are too confusing
As agreed in the last discussion, the literals are *Only those defined* and *All excluding defined*

---
M src-db/database/sourcedata/AD_REF_LIST.xml
---
(0031119)
hudsonbot   
2010-09-15 20:55   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/dc6c5efef83b [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/80bfed94a6e8 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18410.obx [^]
(0031132)
hudsonbot   
2010-09-15 20:55   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/71cf3dcc3b33 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/80bfed94a6e8 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18410.obx [^]
(0031208)
sureshbabu   
2010-09-20 08:53   
Now its changed to
 Only those defined
All excluding defined