0014354: If ',' character is the decimal separator, then invoice line do not populate amounts and tax values when selecting a product

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0014354

Openbravo ERP

03. Procurement management

public

2010-08-27 13:40

2010-09-13 12:38

Reporter

dalsasua

Assigned To

adrianromero

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

duplicate

Platform

OS Version

Ubuntu 9.04

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0014354: If ',' character is the decimal separator, then invoice line do not populate amounts and tax values when selecting a product

Description

If ',' character is the decimal separator, then invoice line do not populate amounts and tax values when selecting a product

Steps To Reproduce

Apply this patch to Format.xml file:
28c28
< decimal="." grouping="," formatOutput="#,##0.00" formatInternal="#0.00" />
---
> decimal="," grouping="." formatOutput="#,##0.00" formatInternal="#0.00" />
30c30
< decimal="." grouping="," formatOutput="#0.00" formatInternal="#0.00" />
---
> decimal="," grouping="." formatOutput="#0.00" formatInternal="#0.00" />
36c36
< decimal="." grouping="," formatOutput="#,##0.00" formatInternal="#0.00" />
---
> decimal="," grouping="." formatOutput="#,##0.00" formatInternal="#0.00" />
38c38
< decimal="." grouping="," formatOutput="#0.00" formatInternal="#0.00" />
---
> decimal="," grouping="." formatOutput="#0.00" formatInternal="#0.00" />
42c42
< decimal="." grouping="," formatOutput="#,##0" formatInternal="#0" />
---
> decimal="," grouping="." formatOutput="#,##0" formatInternal="#0" />
44c44
< decimal="." grouping="," formatOutput="#0" formatInternal="#0" />
---
> decimal="," grouping="." formatOutput="#0" formatInternal="#0" />
50c50
< decimal="." grouping="," formatOutput="#,##0.###" formatInternal="#0.000" />
---
> decimal="," grouping="." formatOutput="#,##0.###" formatInternal="#0.000" />
52c52
< decimal="." grouping="," formatOutput="#0.###" formatInternal="#0.000" />
---
> decimal="," grouping="." formatOutput="#0.###" formatInternal="#0.000" />
56c56
< decimal="." grouping="," formatOutput="#,##0.######" formatInternal="#0.000000" />
---
> decimal="," grouping="." formatOutput="#,##0.######" formatInternal="#0.000000" />
58c58
< decimal="." grouping="," formatOutput="#0.######" formatInternal="#0.000000" />
---
> decimal="," grouping="." formatOutput="#0.######" formatInternal="#0.000000" />

Then re-compile application and go to an invoice (sales or purchase) line, and choose a product. Nothing happens, and an error is shown while executing

strPriceActual = SLOrderProductData.getOffersPriceInvoice(this, dataInvoice[0].dateinvoiced, dataInvoice[0].cBpartnerId, strMProductID, strPriceStd.replace("\"", ""), strQty, dataInvoice[0].mPricelistId, dataInvoice[0].id);

Proposed Solution

diff --git a/src/org/openbravo/erpCommon/ad_callouts/SL_Invoice_Product.java b/src/org/openbravo/erpCommon/ad_callouts/SL_Invoice_Product.java
--- a/src/org/openbravo/erpCommon/ad_callouts/SL_Invoice_Product.java
+++ b/src/org/openbravo/erpCommon/ad_callouts/SL_Invoice_Product.java
@@ -54,7 +54,7 @@
         log4j.debug("CHANGED: " + strChanged);
       String strUOM = vars.getStringParameter("inpmProductId_UOM");
       String strPriceList = vars.getStringParameter("inpmProductId_PLIST");
- String strPriceStd = vars.getStringParameter("inpmProductId_PSTD");
+ String strPriceStd = vars.getNumericParameter("inpmProductId_PSTD");
       String strPriceLimit = vars.getStringParameter("inpmProductId_PLIM");
       String strCurrency = vars.getStringParameter("inpmProductId_CURR");
       String strQty = vars.getNumericParameter("inpqtyinvoiced");

Additional Information