Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0014254Openbravo ERPY. DBSourceManagerpublic2010-08-20 12:342010-09-18 00:00
Reporternetworkb 
Assigned Tomarvintm 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Version2.50MP20 
Target Version2.50MP22Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0014254: update.database error if the name of function finish equal than other core function
Descriptionif name of function finish equal than other core function, and there is a new function that call to this function, to run update.database of this function, error is returned
Steps To Reproduce. create a new module with dbprefix = TEST
. create a new function
   test_c_invoice_create(character varying, character varying)
. create a new function test_c_invoice_create0(character varying):
 this function calls to test_c_invoice_create:

CREATE OR REPLACE FUNCTION test_c_invoice_create0(p_pinstance_id character varying) RETURNS void AS
$BODY$ DECLARE
  v_Test VARCHAR(32); --OBTG:varchar2--
BEGIN
  SELECT * INTO v_Test FROM TEST_C_Invoice_Create(p_PInstance_ID, NULL) ;
END ; $BODY$
  LANGUAGE 'plpgsql' VOLATILE
  COST 100;
ALTER FUNCTION test_c_invoice_create0_test(character varying) OWNER TO TAD;

. run export.database
. run update.database

Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-08-20 12:34networkbNew Issue
2010-08-20 12:34networkbAssigned To => marvintm
2010-08-20 12:34networkbOBNetwork customer => Yes
2010-08-30 08:53alostaleStatusnew => scheduled
2010-08-30 08:53alostalefix_in_branch => pi
2010-09-06 13:39marvintmNote Added: 0030646
2010-09-06 13:39marvintmStatusscheduled => feedback
2010-09-10 09:56marvintmStatusfeedback => scheduled
2010-09-10 09:56marvintmNote Added: 0030925
2010-09-10 18:18hgbotCheckin
2010-09-10 18:18hgbotNote Added: 0030946
2010-09-10 18:18hgbotStatusscheduled => resolved
2010-09-10 18:18hgbotResolutionopen => fixed
2010-09-10 18:18hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/dbsm-main/rev/0463efb4b4593b3a8a6c7fb56136731e3cc5fedf [^]
2010-09-10 18:21hgbotCheckin
2010-09-10 18:21hgbotNote Added: 0030948
2010-09-10 18:21hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/dbsm-main/rev/0463efb4b4593b3a8a6c7fb56136731e3cc5fedf [^] => http://code.openbravo.com/erp/devel/pi/rev/3f276cad5c27a03faccf548741e471c26f3f63d5 [^]
2010-09-11 07:19hudsonbotCheckin
2010-09-11 07:19hudsonbotNote Added: 0030958
2010-09-17 18:34shuehnerNote Added: 0031199
2010-09-17 18:34shuehnerStatusresolved => closed
2010-09-18 00:00anonymoussf_bug_id0 => 3069534

Notes
(0030646)
marvintm   
2010-09-06 13:39   
I couldn't reproduce the issue with the steps provided.

I created the module, and the two functions, and did export.database. The function XML files look fine, and an update.database was run without problems.

Maybe there is something not taken into account in the steps to reproduce?
(0030925)
marvintm   
2010-09-10 09:56   
Now I've been able to reproduce the issue, and I will be fixing it soon.
(0030946)
hgbot   
2010-09-10 18:18   
Repository: erp/devel/dbsm-main
Changeset: 0463efb4b4593b3a8a6c7fb56136731e3cc5fedf
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Fri Sep 10 15:12:31 2010 +0200
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/0463efb4b4593b3a8a6c7fb56136731e3cc5fedf [^]

Fixed issue 14254. plsql translation will work correctly with functions whose name end like a different function

---
M src/org/apache/ddlutils/platform/postgresql/FunctionWithOutputTranslation.java
---
(0030948)
hgbot   
2010-09-10 18:21   
Repository: erp/devel/pi
Changeset: 3f276cad5c27a03faccf548741e471c26f3f63d5
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Fri Sep 10 13:24:43 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/3f276cad5c27a03faccf548741e471c26f3f63d5 [^]

Fixed issue 14254. plsql translation will work correctly with functions whose name end like a different function

---
M src-db/database/lib/dbsourcemanager.jar
---
(0030958)
hudsonbot   
2010-09-11 07:19   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/3f276cad5c27 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/06ead0b24d2d [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18370.obx [^]
(0031199)
shuehner   
2010-09-17 18:34   
Tested on pi/pgsql. Specified testcase is now working fine with export/update cycle. No errors on those tasks and function in db looks correct. Changeset is in postgres specific file -> No extra test needed on oracle. hudson is fine with db-consistency/translation-consistency. Review of diff looks ok. > Closing