Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0014202Openbravo ERP04. Warehouse managementpublic2010-08-16 13:262010-09-17 00:00
Reporternetworkb 
Assigned Toadrianromero 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version2.50MP20 
Target Version2.50MP22Fixed in Version2.50MP22 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0014202: Product Movements Report appears in spanish when it is executed in english
DescriptionIf you execute Product Movements Report in Spanish and then you switch to English language and execute it again in English, some labels appear in Spanish.

See screenshot attached.
Steps To Reproduce1. Install Spanish Translation Module
2. Log in Spanish language and run Warehouse Management || Analysis Tools || Product Movements Report
3. Log in English language and run Warehouse Management || Analysis Tools || Product Movements Report
Realize that labels are in Spanish
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filesjpg Movimientoproductosinglés.JPG (108,351) 2010-08-16 13:26
https://issues.openbravo.com/file_download.php?file_id=2870&type=bug
jpg
Issue History
Date ModifiedUsernameFieldChange
2010-08-16 13:26networkbNew Issue
2010-08-16 13:26networkbAssigned To => adrianromero
2010-08-16 13:26networkbFile Added: Movimientoproductosinglés.JPG
2010-08-20 09:48adrianromeroStatusnew => scheduled
2010-08-20 09:48adrianromerofix_in_branch => pi
2010-08-25 13:15hgbotCheckin
2010-08-25 13:15hgbotNote Added: 0030313
2010-08-25 13:15hgbotCheckin
2010-08-25 13:15hgbotNote Added: 0030314
2010-08-25 13:15hgbotStatusscheduled => resolved
2010-08-25 13:15hgbotResolutionopen => fixed
2010-08-25 13:15hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/dfeacf18d7185368618e25d0fb64ddb71c9f3d22 [^]
2010-08-25 13:15hgbotCheckin
2010-08-25 13:15hgbotNote Added: 0030315
2010-08-25 13:45adrianromeroNote Added: 0030316
2010-08-26 11:05adrianromeroNote Added: 0030342
2010-08-26 15:00hgbotCheckin
2010-08-26 15:00hgbotNote Added: 0030365
2010-08-26 15:00hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/dfeacf18d7185368618e25d0fb64ddb71c9f3d22 [^] => http://code.openbravo.com/erp/devel/pi/rev/71ebc702ee0b1eb8022ab66ea60d7cdad0c8404d [^]
2010-08-26 15:01hgbotCheckin
2010-08-26 15:01hgbotNote Added: 0030366
2010-08-26 15:01hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/71ebc702ee0b1eb8022ab66ea60d7cdad0c8404d [^] => http://code.openbravo.com/erp/devel/pi/rev/dd9fdaa8fef65f48478def02b726cc79e7f54d02 [^]
2010-08-26 15:01hgbotCheckin
2010-08-26 15:01hgbotNote Added: 0030367
2010-08-26 15:01hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/dd9fdaa8fef65f48478def02b726cc79e7f54d02 [^] => http://code.openbravo.com/erp/devel/pi/rev/b816f9aa12fe508ab72bd9706e51f567b3f3c1ed [^]
2010-08-26 15:01hgbotCheckin
2010-08-26 15:01hgbotNote Added: 0030368
2010-08-26 15:01hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/b816f9aa12fe508ab72bd9706e51f567b3f3c1ed [^] => http://code.openbravo.com/erp/devel/pi/rev/28ab43581b8307da39bd21d44554688c10572c08 [^]
2010-08-26 15:01hgbotCheckin
2010-08-26 15:01hgbotNote Added: 0030369
2010-08-26 15:01hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/28ab43581b8307da39bd21d44554688c10572c08 [^] => http://code.openbravo.com/erp/devel/pi/rev/d37d5a8b1a59c5419e23a5be817b6c4ad65629cd [^]
2010-09-07 09:17hudsonbotCheckin
2010-09-07 09:17hudsonbotNote Added: 0030671
2010-09-07 09:17hudsonbotCheckin
2010-09-07 09:17hudsonbotNote Added: 0030672
2010-09-07 09:17hudsonbotCheckin
2010-09-07 09:17hudsonbotNote Added: 0030673
2010-09-07 09:17hudsonbotCheckin
2010-09-07 09:17hudsonbotNote Added: 0030679
2010-09-07 09:17hudsonbotCheckin
2010-09-07 09:17hudsonbotNote Added: 0030680
2010-09-07 09:17hudsonbotCheckin
2010-09-07 09:17hudsonbotNote Added: 0030681
2010-09-07 09:17hudsonbotCheckin
2010-09-07 09:17hudsonbotNote Added: 0030682
2010-09-07 09:17hudsonbotCheckin
2010-09-07 09:17hudsonbotNote Added: 0030683
2010-09-16 13:46psarobeNote Added: 0031159
2010-09-16 13:46psarobeStatusresolved => closed
2010-09-16 13:47psarobeFixed in Version => 2.50MP22
2010-09-17 00:00anonymoussf_bug_id0 => 3068047

Notes
(0030313)
hgbot   
2010-08-25 13:15   
Repository: erp/devel/pi
Changeset: 33315a869d2f4eddc1b4895ebadd98e9ee5f2381
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Tue Aug 24 12:21:18 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/33315a869d2f4eddc1b4895ebadd98e9ee5f2381 [^]

Issue 14202: Product Movements Report appears in spanish when it is executed in english
XmlDocument.translateDataValue: Refactor:
- Simplify loops
- Reduce nesting level with an early return-
- Check if translations exist out of the loop
- Reduce casting using generics
- Extract translation of XmlVectorTemplate into helper function
- Inline only used once variable

---
M src-core/src/org/openbravo/xmlEngine/DataTemplate.java
M src-core/src/org/openbravo/xmlEngine/DataValue.java
M src-core/src/org/openbravo/xmlEngine/XmlDocument.java
---
(0030314)
hgbot   
2010-08-25 13:15   
Repository: erp/devel/pi
Changeset: dfeacf18d7185368618e25d0fb64ddb71c9f3d22
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Tue Aug 24 12:48:19 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/dfeacf18d7185368618e25d0fb64ddb71c9f3d22 [^]

Fixes issue 14202: Product Movements Report appears in spanish when it is executed in english
Translate the current xmlDocument values and not the (cached) template

---
M src-core/src/org/openbravo/xmlEngine/DataValue.java
M src-core/src/org/openbravo/xmlEngine/XmlDocument.java
---
(0030315)
hgbot   
2010-08-25 13:15   
Repository: erp/devel/pi
Changeset: 8badd5d23b5966da70be4921fb33bbbcbdf18923
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Tue Aug 24 14:30:21 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/8badd5d23b5966da70be4921fb33bbbcbdf18923 [^]

Issue 14202: Product Movements Report appears in spanish when it is executed in english
Removing not needed castings

---
M src-core/src/org/openbravo/xmlEngine/SectionValue.java
M src-core/src/org/openbravo/xmlEngine/XmlDocument.java
---
(0030316)
adrianromero   
2010-08-25 13:45   
* Testing the issue

Follow the steps to reproduce and notice that now when logging in English, all labels are in English, not in Spanish.

* Other areas affected.

Because the changes affects the translation functionality of the XMLEngine and this area is a core area of Openbravo ERP more tests need to be tested:

Having the Spanish Translation Module test also the following reports in Spanish and in English. All labels must appear in the selected language. Change from Spanish to English and from English to Spanish a couple of times.

** Warehouse Management || Analysis Tools || Valued Stock Report || Valued Stock Report
** Warehouse Management || Analysis Tools || Warehouse Control Report || Warehouse Control Report
** Warehouse Management || Analysis Tools || Pareto Product Report || Pareto Product Report
** Financial Management || Accounting || Analysis Tools || Trial Balance Report || Trial Balance Report
** Financial Management || Accounting || Analysis Tools || General Ledger Report || General Ledger Report
** Financial Management || Accounting || Analysis Tools || General Ledger Journal || General Ledger Journal
(0030342)
adrianromero   
2010-08-26 11:05   
* Other areas affected (Cont.)

There are also issues related to translations in the XMLEngine that needs too be reviewed that the fixes done in these issues are not broken with this fix. The related issues are: 9653, 9353 and 9659
(0030365)
hgbot   
2010-08-26 15:00   
Repository: erp/devel/pi
Changeset: 71ebc702ee0b1eb8022ab66ea60d7cdad0c8404d
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Aug 26 14:49:25 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/71ebc702ee0b1eb8022ab66ea60d7cdad0c8404d [^]

Fixes issue 0014202: Product Movements Report appears in spanish when it is executed in english
Updating properly copyright notice

---
M src-core/src/org/openbravo/xmlEngine/DataTemplate.java
M src-core/src/org/openbravo/xmlEngine/DataValue.java
M src-core/src/org/openbravo/xmlEngine/SectionValue.java
M src-core/src/org/openbravo/xmlEngine/XmlDocument.java
---
(0030366)
hgbot   
2010-08-26 15:01   
Repository: erp/devel/pi
Changeset: dd9fdaa8fef65f48478def02b726cc79e7f54d02
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Aug 26 14:51:25 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/dd9fdaa8fef65f48478def02b726cc79e7f54d02 [^]

Fixes issue 0014202: Product Movements Report appears in spanish when it is executed in english
Refactoring loop

---
M src-core/src/org/openbravo/xmlEngine/DataValue.java
---
(0030367)
hgbot   
2010-08-26 15:01   
Repository: erp/devel/pi
Changeset: b816f9aa12fe508ab72bd9706e51f567b3f3c1ed
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Aug 26 14:52:36 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b816f9aa12fe508ab72bd9706e51f567b3f3c1ed [^]

Fixes issue 0014202: Product Movements Report appears in spanish when it is executed in english
Removing unused import

---
M src-core/src/org/openbravo/xmlEngine/XmlDocument.java
---
(0030368)
hgbot   
2010-08-26 15:01   
Repository: erp/devel/pi
Changeset: 28ab43581b8307da39bd21d44554688c10572c08
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Aug 26 14:53:25 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/28ab43581b8307da39bd21d44554688c10572c08 [^]

Fixes issue 0014202: Product Movements Report appears in spanish when it is executed in english
Removing unnecessary assignment

---
M src-core/src/org/openbravo/xmlEngine/XmlDocument.java
---
(0030369)
hgbot   
2010-08-26 15:01   
Repository: erp/devel/pi
Changeset: d37d5a8b1a59c5419e23a5be817b6c4ad65629cd
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Aug 26 14:55:00 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d37d5a8b1a59c5419e23a5be817b6c4ad65629cd [^]

Fixes issue 0014202: Product Movements Report appears in spanish when it is executed in english
Renaming properly new internal method.

---
M src-core/src/org/openbravo/xmlEngine/XmlDocument.java
---
(0030671)
hudsonbot   
2010-09-07 09:17   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/33315a869d2f [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/4390fe5213a4 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18274.obx [^]
(0030672)
hudsonbot   
2010-09-07 09:17   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/dfeacf18d718 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/4390fe5213a4 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18274.obx [^]
(0030673)
hudsonbot   
2010-09-07 09:17   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/8badd5d23b59 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/4390fe5213a4 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18274.obx [^]
(0030679)
hudsonbot   
2010-09-07 09:17   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/71ebc702ee0b [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/4390fe5213a4 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18274.obx [^]
(0030680)
hudsonbot   
2010-09-07 09:17   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/dd9fdaa8fef6 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/4390fe5213a4 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18274.obx [^]
(0030681)
hudsonbot   
2010-09-07 09:17   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/b816f9aa12fe [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/4390fe5213a4 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18274.obx [^]
(0030682)
hudsonbot   
2010-09-07 09:17   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/28ab43581b83 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/4390fe5213a4 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18274.obx [^]
(0030683)
hudsonbot   
2010-09-07 09:17   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/d37d5a8b1a59 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/4390fe5213a4 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18274.obx [^]
(0031159)
psarobe   
2010-09-16 13:46   
Tested working fine