Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0014153Openbravo ERPZ. Otherspublic2010-08-10 10:222010-12-09 16:04
Reporterrgoris 
Assigned Tomtaal 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version2.50 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesUser Interface Application
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0014153: Re-login after time out results in double tab rows
Description3.0-RC1-demo instance
When you let the session expire, then click any classic tab or link, you are forced to log in again. Doing so, the window will then be opened WITHIN the iFrame below the new tabs, hereby showing the tabs again.
Steps To ReproduceSee above
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
duplicate of defect 0014381 closed dbaz Problems with deactivated/timed-out sessions and layout 
related to defect 00144813.0RC3 closed dbaz The Tomcat process restart keeps the upper menu frame 
related to defect 0014486 closed mtaal Problem with session timeout/invalidation & seam 
Attached Filespng WindowInFrame-1.png (200,922) 2010-08-10 10:22
https://issues.openbravo.com/file_download.php?file_id=2829&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2010-08-10 10:22rgorisNew Issue
2010-08-10 10:22rgorisAssigned To => mtaal
2010-08-10 10:22rgorisFile Added: WindowInFrame-1.png
2010-08-16 11:32mtaalAssigned Tomtaal => dbaz
2010-08-26 13:12dbazNote Added: 0030349
2010-08-31 11:53dbazRelationship addedduplicate of 0014185
2010-08-31 11:53dbazRelationship deleted0014185
2010-08-31 11:53dbazRelationship addedduplicate of 0014381
2010-08-31 13:39hgbotCheckin
2010-08-31 13:39hgbotNote Added: 0030540
2010-09-05 14:19mtaalAssigned Todbaz => mtaal
2010-09-05 22:34hgbotCheckin
2010-09-05 22:34hgbotNote Added: 0030623
2010-09-05 22:34hgbotStatusnew => resolved
2010-09-05 22:34hgbotResolutionopen => fixed
2010-09-05 22:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/mods/org.openbravo.client.application/rev/5672a9ce2ca1431f0a9d8024478f293122c12b19 [^]
2010-09-07 18:19shuehnerNote Added: 0030782
2010-09-07 18:19shuehnerStatusresolved => new
2010-09-07 18:19shuehnerResolutionfixed => open
2010-09-08 10:26hgbotCheckin
2010-09-08 10:26hgbotNote Added: 0030823
2010-09-08 10:26hgbotStatusnew => resolved
2010-09-08 10:26hgbotResolutionopen => fixed
2010-09-08 10:26hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/mods/org.openbravo.client.application/rev/5672a9ce2ca1431f0a9d8024478f293122c12b19 [^] => http://code.openbravo.com/erp/mods/org.openbravo.client.application/rev/85b11893f4ed824dd6149a4247937778513be679 [^]
2010-09-08 15:41dbazRelationship addedrelated to 0014481
2010-09-08 17:25shuehnerRelationship addedrelated to 0014486
2010-09-08 17:26shuehnerNote Added: 0030855
2010-09-08 17:26shuehnerStatusresolved => closed
2010-12-09 16:04anonymoussf_bug_id0 => 3133352

Notes
(0030349)
dbaz   
2010-08-26 13:12   
Once the session is expired, or if you paste in the browser's url directly an deep linking url (and the user is not logged in) this is which should happen:
* The system redirects to the login screen (and saves in the cache the desired url)
* Once the login is successful the saved desired url is loaded

Notice that a nice feature would be that in the dynamic url, also there should be an ID to specify in which Role we are, in order to login directly as the desired role (to avoid tabs with an 'Error: no permissions' msgbox once you hace logged in)
(0030540)
hgbot   
2010-08-31 13:39   
Repository: erp/mods/org.openbravo.client.kernel
Changeset: dd6ce6ef6d6657e16d3e1a976e04e84068e6b4e9
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Aug 31 13:39:23 2010 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.client.kernel/rev/dd6ce6ef6d6657e16d3e1a976e04e84068e6b4e9 [^]

Rollback change, related to issue 14153: Re-login after time out results in double tab rows

---
M src/org/openbravo/client/kernel/templates/application_js.ftl
---
(0030623)
hgbot   
2010-09-05 22:34   
Repository: erp/mods/org.openbravo.client.application
Changeset: 5672a9ce2ca1431f0a9d8024478f293122c12b19
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Sep 05 22:34:05 2010 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.client.application/rev/5672a9ce2ca1431f0a9d8024478f293122c12b19 [^]

Fixes issue 14153: Re-login after time out results in double tab rows

---
M src/org/openbravo/client/application/templates/layout.js.ftl
---
(0030782)
shuehner   
2010-09-07 18:19   
Reopening as the related 14381 is not solved completely and the cset's were mixed between those issues (see details for still broken behavior in 14381)

When resolving please also mark the related 14381 as resolved, too.
(0030823)
hgbot   
2010-09-08 10:26   
Repository: erp/mods/org.openbravo.client.application
Changeset: 85b11893f4ed824dd6149a4247937778513be679
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Sep 08 10:26:27 2010 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.client.application/rev/85b11893f4ed824dd6149a4247937778513be679 [^]

Fixes issue 14381: Problems with deactivated/timed-out sessions and layout, Fixes issue 14153: Re-login after time out results in double tab rows

---
M src/org/openbravo/client/application/templates/layout.js.ftl
---
(0030855)
shuehner   
2010-09-08 17:26   
Testing working ok now. The login page does reload itself in the main windows(in pi, post MP21) if it has been opened in a tab. Additionally the new layout has a similar check to not show itself inside a tab.