Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0014151Openbravo ERPZ. Otherspublic2010-08-10 08:542013-01-23 14:17
ReporterRareworld 
Assigned Tomtaal 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutioninvalid 
PlatformOS10OS VersionXP 32 Bit
Product Version2.50 
Target VersionFixed in Version 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerNo
Web browser
ModulesUser Interface Selector
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0014151: UI Selector issues
DescriptionWe are currently trying to integrate the UI selector in our application; we have upgraded the application to MP 20 and were successful in compiling selector with MP 20 and our module.

We have started converting a few of the columns from TableDir reference to UI Selector type references, it ran successfully on a few of columns but there are certain issues that are keeping us from moving ahead with other columns. They are being listed under:


1. If we are having any list reference as an identifier then the selector does not show it in the identifiers (in the edit mode for suggestion box); while it does show only the SEARCH KEYS of the list items NOT the name of list items, in the grid view.

Steps to reproduce:

For this problem to appear, we require a table (say t1) which has an identifier column (say c1) set as a list reference (say l1);

i. Define a selector reference (say s1) having "OBUISEL_Selectore_Reference" as its parent reference
ii. Under "Defined Selector" select table name (t1) and template as "Selector Template"
iii. Under "Defined Selector Field" select the field / column (c1) from the table that has reference type set as list
iv. Set the reference type for a column (say cN1) that will be used to have selector (for records of t1) - by setting reference as "OBUISEL_Selectore_Reference" and reference search key set to the newly defined selector (s1).
v. Compile the related window
vi. After compilation the results can be seen by going to the window for which the selector was defined


2. When we set the reference for a column of type UI selector, then after compilation of that window; the selector’s suggestion box shown is NOT proper, the sequence of the fields for selector changes and as soon as some one types some value (in suggestion box) for the selector, then it throws a Null Pointer Exception, showing the HQL generated.

Steps to reproduce:

For this problem to appear, we require a table (say t2) which has 2 columns (say c2 and c3) set as a identifier;

i. Define a selector reference (say s2) having "OBUISEL_Selectore_Reference" as its parent reference
ii. Under "Defined Selector" select table name (t2) and template as "Selector Template"
iii. DO NOT select the column (c2) that is set as identifier for the table Under "Defined Selector Field".
iv. Set the reference type for the column (cN2) that will be used to have selector (for records of t2) - by setting reference as "OBUISEL_Selectore_Reference" and reference search key set to the newly defined selector (s2).
v. Compile the related window
vi. After compilation the results can be seen by going to the window for which the selector was defined


3. Once a column in a table has been set as having reference type UI Selector then whereever that table is referred the screen starts throwing "NumberFormatException"
Steps to reproduce:

For this problem to appear, we require a table (say t3) which has one or more columns having reference type set as UI Selector;

i. Refer (t3) as TableDir reference in another table (say t4)
ii. Compile the related window (having t4 as table for one of its tabs)
iii. After compilation the results can be seen by going to the window for whose field the TableDir reference was defined.


Screen shots (in ZIP format) are attached for further reference.

Please suggest a solution for the above mentioned problems.
Steps To ReproduceCovered in description
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0014136 closed mtaal List reference values should show translated and readable values. 
depends on defect 0014255 closed alostale New references cannot be used as record identifier 
depends on defect 0014195 closed mtaal If the selector is associated with a key column the behaviour is not properly 
depends on defect 0014457 closed mtaal Selector field can not be used in vaidations of other fields 
related to defect 0014492 closed mtaal Problems with column of type ui selector 
Attached Fileszip UI Selector issues.zip (331,341) 2010-08-10 08:54
https://issues.openbravo.com/file_download.php?file_id=2824&type=bug
log Log during compile-complete-development (25-08-2010) .log (371,124) 2010-08-26 07:12
https://issues.openbravo.com/file_download.php?file_id=2955&type=bug
zip new changes in selector.zip (112,755) 2010-08-31 08:49
https://issues.openbravo.com/file_download.php?file_id=2990&type=bug
png Error (TableDir Showing Id only).PNG (70,073) 2010-09-03 10:30
https://issues.openbravo.com/file_download.php?file_id=3020&type=bug
png

png obuiselector error_1.PNG (73,706) 2010-09-09 08:36
https://issues.openbravo.com/file_download.php?file_id=3055&type=bug
png

png obuiselector error_2.PNG (68,323) 2010-09-09 08:36
https://issues.openbravo.com/file_download.php?file_id=3056&type=bug
png

png obuiselector error_3.PNG (97,475) 2010-09-09 08:36
https://issues.openbravo.com/file_download.php?file_id=3057&type=bug
png

zip Changed Files in Selector Module till 28-09-2010.zip (29,230) 2010-10-01 06:57
https://issues.openbravo.com/file_download.php?file_id=3147&type=bug
Issue History
Date ModifiedUsernameFieldChange
2010-08-10 08:54RareworldNew Issue
2010-08-10 08:54RareworldAssigned To => mtaal
2010-08-10 08:54RareworldFile Added: UI Selector issues.zip
2010-08-10 09:00RareworldIssue Monitored: Rareworld
2010-08-23 10:23mtaalRelationship addeddepends on 0014136
2010-08-23 10:26mtaalRelationship addeddepends on 0014255
2010-08-23 16:16mtaalRelationship addeddepends on 0014195
2010-08-23 16:17mtaalNote Added: 0030229
2010-08-23 17:21mtaalNote Added: 0030233
2010-08-23 17:21mtaalStatusnew => feedback
2010-08-25 14:08RareworldNote Added: 0030318
2010-08-25 16:12RareworldNote Added: 0030321
2010-08-26 02:30mtaalNote Added: 0030329
2010-08-26 07:12RareworldFile Added: Log during compile-complete-development (25-08-2010) .log
2010-08-26 07:17RareworldNote Added: 0030331
2010-08-26 10:27mtaalNote Added: 0030341
2010-08-30 14:10RareworldNote Added: 0030464
2010-08-30 14:11mtaalNote Added: 0030465
2010-08-31 08:49RareworldFile Added: new changes in selector.zip
2010-08-31 09:00RareworldNote Added: 0030500
2010-09-02 09:45RareworldNote Added: 0030566
2010-09-03 10:30RareworldFile Added: Error (TableDir Showing Id only).PNG
2010-09-03 10:33RareworldNote Added: 0030591
2010-09-03 10:42mtaalNote Added: 0030592
2010-09-07 10:52mtaalRelationship addeddepends on 0014457
2010-09-07 10:52mtaalNote Added: 0030731
2010-09-07 10:59mtaalOBNetwork customer => No
2010-09-07 10:59mtaalTypedefect => feature request
2010-09-07 11:01mtaalNote Added: 0030734
2010-09-09 08:36RareworldFile Added: obuiselector error_1.PNG
2010-09-09 08:36RareworldFile Added: obuiselector error_2.PNG
2010-09-09 08:36RareworldFile Added: obuiselector error_3.PNG
2010-09-09 08:43RareworldNote Added: 0030876
2010-09-09 10:36mtaalRelationship addedrelated to 0014492
2010-09-09 10:46mtaalNote Added: 0030888
2010-09-09 10:58mtaalNote Added: 0030889
2010-10-01 06:57RareworldFile Added: Changed Files in Selector Module till 28-09-2010.zip
2010-10-01 06:58RareworldNote Added: 0031529
2012-02-09 15:29mtaalNote Added: 0044965
2013-01-23 14:17mtaalReview Assigned To => AugustoMauch
2013-01-23 14:17mtaalNote Added: 0055772
2013-01-23 14:17mtaalStatusfeedback => closed
2013-01-23 14:17mtaalResolutionopen => invalid

Notes
(0030229)
mtaal   
2010-08-23 16:17   
Update:
- topic 1 has been solved as part of issue 14136
- topic 3 has been solved as part of issue 14255, but another related issue is still open: 14195
- working on topic 2 at the moment
(0030233)
mtaal   
2010-08-23 17:21   
I tried to replicate topic 2 by creating a selector reference which references a table with an identifier consisting of 2 columns. This worked fine for me without problems.

Which version of the selector module are you using?

Are there other specific things with your case?
(0030318)
Rareworld   
2010-08-25 14:08   
1.0.11 is the version of selector module being used at our end.
(0030321)
Rareworld   
2010-08-25 16:12   
We have tried to integrate the latest code for selector module 1.0.11 (having change sets already applied by you) to solve the topics in this issue.

We used
  ant core.lib
  ant update.database -Dforce=yes
  ant trl.lib
  ant wad.lib
which all ran successfully, and then used
  ant compile.complete.development
to get the instance compiled, but the process failed. A log of compilation is being attached for your reference.
(0030329)
mtaal   
2010-08-26 02:30   
I did not see an attachment, but, the latest selector code also requires the latest version of Openbravo Core. So if you did not update Openbravo core then you will surely get compile errors. The changes in Openbravo Core will be released as MP21 which will be released as the next MP.

gr. Martin
(0030331)
Rareworld   
2010-08-26 07:17   
Mr. Martin,

Sorry, last time, I did not press "Upload File"; so, here is the log file for your reference.

Please let us know how and when will it be possible for us to have the updated core to get the things working?

Thanks and Regards
Team, Rareworld
(0030341)
mtaal   
2010-08-26 10:27   
Hi,
It will be in MP21, afaik the MP releases are announced in various ways.

gr. Martin
(0030464)
Rareworld   
2010-08-30 14:10   
Hi,

The issues reported so far by us, except the one pertaining to the lists (i.e. topic#1), had been resolved at our end only, and now we have the selectors working on MP20, for that we had to make some changes in the code provided for UI selector, JSON Datasource and JSON REST Webservice modules. The resultant code has reduced the length of (the part of) code that is used to generate the combo boxes, to its 1/10th.

Thanks and Regards

Team, Rareworld Technologies
(0030465)
mtaal   
2010-08-30 14:11   
Nice, if you have the possibility can you attach a diff of your changes to this issue?

gr. Martin
(0030500)
Rareworld   
2010-08-31 09:00   
Hi,

Sorry, we are not uploading diff, rather a zip file having all the changes done by us is being uploaded for your reference.

A new class with the name CustomData has been introduced in the package org.openbravo.service.json.

When these changes are applied:
1. Giving dynamic queries for the filtration of data for a selector is possible,
2. No HQL Error is shown while typing any value in the suggestion box for selector,
3. Suggestion box with proper data values is now being shown,
4. The response time has reduced (as result of code size been reduced).

Thanks & Regards
Team, Rareworld
(0030566)
Rareworld   
2010-09-02 09:45   
Hi,

There is an observation while testing the selector, the selector fails to invoke / apply the validation for the related field:

The existing code for selector does not have any provision for call to apply a validation on a related field in "onchange" (javascript) function. We would like to request, to have that part of code (a call for "reloadComboReloads") integrated in "onchange", and / or tell us the way in which this is possible; so that the validation can be applied to the related field.

Thanks and Regards
Team, Rareworld
(0030591)
Rareworld   
2010-09-03 10:33   
Hi,

With reference to the UI Selector, we face a problem while keeping primary key (field) of a table (that contains selector) as identifier

If we keep OBUI_Selector as reference for a column (say we have a table RWT_Proc_Contract_Id) of a table (say RWT_Proc_Inward), and if the primary key of this table T1, (say RWT_Proc_Inward_Id) is kept as an identifier for the table (say RWT_Proc_Unload), now if this RWT_Proc_Inward_Id is again used in RWT_Proc_GRN, then its resultant combo box shows value of RWT_Proc_Inward_Id not the identifiers of RWT_Proc_Inward table!

The screen shot "Error (TableDir Showing Id only).PNG" is being attached for your reference.

Please suggest a solution for this problem as well.

Thanks and Regards
Team, Rareworld
(0030592)
mtaal   
2010-09-03 10:42   
The last topic has been reported and solved (see the related issues). Related to the comboreloads, we checked the source code, it should work. I will test it myself also later.

gr. Martin
(0030731)
mtaal   
2010-09-07 10:52   
I added a new issue for the validation problem. I am working on it.
(0030734)
mtaal   
2010-09-07 11:01   
The last issue related to validations has been solved and pushed to the repository. See the changeset in the 14457 issue.

Afaics all problems described in this issue have been solved. I have changed the type to feature request to reflect that it can be interesting to see if we can apply the same changes you did related to using dynamic data from the context and other changes.

If you encounter new issues/problems it works best if for those new issues are entered. Thanks!

gr. Martin
(0030876)
Rareworld   
2010-09-09 08:43   
Hi,

We would like to thank you for providing solutions to few of our reported issues, but there are still some issues (topics) that remain unresolved.

After applying MP21 and Updates pertaining to Selector and related modules following is the status:

1. If we are having any list reference as an identifier then the selector does not show it in the identifiers (in the edit mode for suggestion box); while it does show only the SEARCH KEYS of the list items NOT the name of list items, in the grid view.

Status: Popup window fails to open, when we try to launch the Popup then a JavaScript error is thrown- "OB.RemoteCellManager is undefined"

2. When we set the reference for a column of type UI selector, then after compilation of that window; the selector’s suggestion box shown is NOT proper, the sequence of the fields for selector changes and as soon as some one types some value (in suggestion box) for the selector, then it throws a Null Pointer Exception, showing the HQL generated.

Status: The problem remains unresolved with MP

A few screen shots having details of the issue named as obuiselector error_1.PNG, obuiselector error_2.PNG and obuiselector error_3.PNG are being attached

3. Once a column in a table had been set as having reference type UI Selector then whereever that table was referred the screen started throwing "NumberFormatException"

Status: The problem has been solved

4. There was an observation while testing the selector, the selector failed to invoke / apply the validation for the related field

Status: The problem has been solved

5. Primary key field's value shown in place of the qualified identifiers' values

Status: The problem has been solved

Thanks and Regards
Team, Rareworld Technologies
(0030888)
mtaal   
2010-09-09 10:46   
I entered an issue for topic 2:
https://issues.openbravo.com/view.php?id=14492 [^]

For topic 1, does the error manager contain this:
OB.RemoteCellManager
or this:
OB.RemoteCallManager
(see the Cell versus Call part)

If the latter can you try to clear the browser cache? If the first then it is something else.

Regarding list references, there still remains an issue in the grid display I assume, but let's first check the javascript error.

Btw, it is best if you enter new issues for new problems you encounter instead of adding to this issue. We commit/push against an issue and also do qa (code-review) on the basis of the changesets in an issue. For this process we need to have one issue per problem with only related changesets.

gr. Martin
(0030889)
mtaal   
2010-09-09 10:58   
As you are watching this issue, regarding the topic I moved here:
https://issues.openbravo.com/view.php?id=14492 [^]

can you provide a module I can install to reproduce the issue?

gr. Martin
(0031529)
Rareworld   
2010-10-01 06:58   
Here is uploading another set of changes that have been made in UI Selector Module.

Regards
Team, Rareworld Technologies
(0044965)
mtaal   
2012-02-09 15:29   
Hi,
Sorry that we have focused on other issues, this issue is already quite old. Is it still relevant? Considering that the new user interface has been out for almost a year now.
gr. Martin
(0055772)
mtaal   
2013-01-23 14:17   
The issue is quite old and is for the selector in classic windows which are not relevant anymore, closing it therefore.