Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0014120Openbravo ERP00. Application dictionarypublic2010-08-03 17:342010-09-15 00:00
Reportericiordia 
Assigned Toalostale 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Versionany
Product Versionpi 
Target Version2.50MP22Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0014120: Removed entries from AD_Model_Object make the system to fail
DescriptionThis issue was generated by the fix to issue 12426 in which entries in AD_Model_Object linked to disabled tabs were removied from the system (eg. Product customer tab within Product window). After this fix it is not possible to enable those tabs through a configuration script because the entries in the AD_Model_Object are not regenerated after enabling the tab
Steps To Reproduce
Proposed SolutionBest solution is to remove from Openbravo code the AD_Model_Object and AD_Model_Object_Mapping entries automatically generated (so the ones linked to tabs) and read directly from ad_tab instead when generating the web.xml file

It would also solve current redundancy in code: all the info in ad_model_object linked to ad_tab is automatically generated so redundant and should not be persisted in openbravo source code
Additional Information
TagsNo tags attached.
Relationships
related to defect 0012426pi closed iperdomo web.xml clean up 
depends on feature request 0014236 closed alostale AD_Model_Object cleanup for generated tabs 
blocks defect 00140872.50MP22 closed alostale Tab Class should be regenerated when modifying Module field 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-08-03 17:34iciordiaNew Issue
2010-08-03 17:34iciordiaAssigned To => alostale
2010-08-03 17:38iciordiaRelationship addedrelated to 0012426
2010-08-03 17:45alostaleRelationship addedblocks 0014087
2010-08-03 17:45iciordiaNote Added: 0029772
2010-08-09 08:03alostaleStatusnew => scheduled
2010-08-18 15:26alostaleRelationship addeddepends on 0014236
2010-08-18 15:29alostaleNote Added: 0030123
2010-09-01 08:40hgbotCheckin
2010-09-01 08:40hgbotNote Added: 0030552
2010-09-01 08:40hgbotStatusscheduled => resolved
2010-09-01 08:40hgbotResolutionopen => fixed
2010-09-01 08:40hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ff4ecf3d867637c0fe39680981bc50ac12f5060c [^]
2010-09-01 08:40hgbotCheckin
2010-09-01 08:40hgbotNote Added: 0030553
2010-09-07 09:18hudsonbotCheckin
2010-09-07 09:18hudsonbotNote Added: 0030710
2010-09-07 09:18hudsonbotCheckin
2010-09-07 09:18hudsonbotNote Added: 0030712
2010-09-14 11:29marvintmNote Added: 0031028
2010-09-14 11:29marvintmStatusresolved => closed
2010-09-15 00:00anonymoussf_bug_id0 => 3066284

Notes
(0029772)
iciordia   
2010-08-03 17:45   
When fixing the issue be aware that there will be Openbravo modules including entries in ad_model_object linked to tabs in the module. It means that there might be for a while useless entries in ad_model_object. So when generating the web.xml file the system will use to subsets:
-AD_Model_Object EXCLUDING those linked to tabs (there might be some)
-Enabled AD_Tabs

There will be a gradual and not mandatory clean-up process in all openbravo modules to remove useless entries in ad_model_object. Module owners should know that this clean-up can not be done in modules that are compatible with MP's previous to MP22
(0030123)
alostale   
2010-08-18 15:29   
This issue is not going to be fixed by removing ad_model_object entries for generated tabs as this would suppose a api change making modules using that information not compatible with next mp. It will be fixed in this way by 0014236.

Current issue will be fixed by reverting the fix for 0012426 related to generated tabs and making WAD not to generate web.xml entries in case the tab or windows is not active.
(0030552)
hgbot   
2010-09-01 08:40   
Repository: erp/devel/pi
Changeset: ff4ecf3d867637c0fe39680981bc50ac12f5060c
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Aug 31 11:27:47 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ff4ecf3d867637c0fe39680981bc50ac12f5060c [^]

fixed bug 14120: Roll back model object deletion for wad tabs

  Rolled back model object deletion for wad tabs performed by fix of issue 12426.

  Now web.xml file for wad tabs does not take into account active value of model
  object, but it uses this value from tab and window. So if a tab is inactive its
  entry is not added in web.xml regardless it is active in model object table.

---
M src-db/database/model/triggers/AD_TAB_TRG2.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
M src-wad/src/org/openbravo/wad/Wad_data.xsql
---
(0030553)
hgbot   
2010-09-01 08:40   
Repository: erp/devel/pi
Changeset: 1d662363a99c25d7af6f5273c96ef38572834285
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Aug 31 13:11:30 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1d662363a99c25d7af6f5273c96ef38572834285 [^]

related to issue 14120: Deleted unneded mapping

---
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
---
(0030710)
hudsonbot   
2010-09-07 09:18   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/ff4ecf3d8676 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/4390fe5213a4 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18274.obx [^]
(0030712)
hudsonbot   
2010-09-07 09:18   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/1d662363a99c [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/4390fe5213a4 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18274.obx [^]
(0031028)
marvintm   
2010-09-14 11:29   
Verified that indeed if a tab is not active, an entry for its class is not added to the web.xml file.