Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0014091Openbravo ERPY. DBSourceManagerpublic2010-07-29 16:542010-10-26 16:29
Reporternetworkb 
Assigned Tomarvintm 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version2.50MP20 
Target Version2.50MP21Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0014091: When installing a module and having a template that removes check constraints the process fails
DescriptionWhen installing a module and having a template that removes check constraints the process fails
Steps To Reproduce-define a new template and check it as "indevelopment"
-remove some checkconstraint on the database.
-Export the template with
ant export.database
ant export.config.script
-Install a module from the module managemente console.
-You get the following error:

[java] 92898 INFO - Executed 134 SQL command(s) successfully
[java] 92901 INFO - Executing default postscript
[java] 94114 INFO - Executed 22 SQL command(s) successfully
[java] 94180 INFO - Loading data from XML files
[java] 99520 INFO - Loading and applying configuration scripts
[java] 99522 INFO - Loading configuration script: /opt/openbravo/modules/de.openbalance.stamm.template/src-db/database/configScript.xml
[java] java.lang.NullPointerException
[java] at org.apache.ddlutils.alteration.RemoveCheckChange.apply(RemoveCheckChange.java:98)
[java] at org.openbravo.ddlutils.util.DBSMOBUtil.loadDataStructures(DBSMOBUtil.java:885)
[java] at org.openbravo.ddlutils.util.DBSMOBUtil.loadDataStructures(DBSMOBUtil.java:821)
[java] at org.openbravo.ddlutils.task.AlterDatabaseDataMod.doExecute(AlterDatabaseDataMod.java:369)
[java] at org.openbravo.ddlutils.task.BaseDatabaseTask.execute(BaseDatabaseTask.java:87)
[java] at org.openbravo.ddlutils.task.AlterDatabaseModJava.main(AlterDatabaseModJava.java:40)
[java] Exception in thread "main" java.lang.NullPointerException
[java] at org.openbravo.ddlutils.task.AlterDatabaseDataMod.doExecute(AlterDatabaseDataMod.java:386)
[java] at org.openbravo.ddlutils.task.BaseDatabaseTask.execute(BaseDatabaseTask.java:87)
[java] at org.openbravo.ddlutils.task.AlterDatabaseModJava.main(AlterDatabaseModJava.java:40)
[java] Caused by: java.lang.NullPointerException
[java] at org.apache.ddlutils.alteration.RemoveCheckChange.apply(RemoveCheckChange.java:98)
[java] at org.openbravo.ddlutils.util.DBSMOBUtil.loadDataStructures(DBSMOBUtil.java:885)
[java] at org.openbravo.ddlutils.util.DBSMOBUtil.loadDataStructures(DBSMOBUtil.java:821)
[java] at org.openbravo.ddlutils.task.AlterDatabaseDataMod.doExecute(AlterDatabaseDataMod.java:369)
[java] ... 2 more
[java] --- Nested Exception ---
[java] java.lang.NullPointerException
[java] at org.apache.ddlutils.alteration.RemoveCheckChange.apply(RemoveCheckChange.java:98)
[java] at org.openbravo.ddlutils.util.DBSMOBUtil.loadDataStructures(DBSMOBUtil.java:885)
[java] at org.openbravo.ddlutils.util.DBSMOBUtil.loadDataStructures(DBSMOBUtil.java:821)
[java] at org.openbravo.ddlutils.task.AlterDatabaseDataMod.doExecute(AlterDatabaseDataMod.java:369)
[java] at org.openbravo.ddlutils.task.BaseDatabaseTask.execute(BaseDatabaseTask.java:87)
[java] at org.openbravo.ddlutils.task.AlterDatabaseModJava.main(AlterDatabaseModJava.java:40)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0014623 closed marvintm export.config.script can fail with NullPointerException in the ColumnDataChange.equals() method 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-07-29 16:54networkbNew Issue
2010-07-29 16:54networkbAssigned To => marvintm
2010-07-29 16:54networkbOBNetwork customer => Yes
2010-08-02 08:09alostaleStatusnew => scheduled
2010-08-04 10:01hgbotCheckin
2010-08-04 10:01hgbotNote Added: 0029778
2010-08-04 10:01hgbotStatusscheduled => resolved
2010-08-04 10:01hgbotResolutionopen => fixed
2010-08-04 10:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/8cd939863e92b1c21eafb8bfd0db0e21ae145379 [^]
2010-08-05 09:16hudsonbotCheckin
2010-08-05 09:16hudsonbotNote Added: 0029804
2010-08-16 08:47alostaleStatusresolved => closed
2010-08-16 08:47alostaleFixed in Version => 2.50MP21
2010-08-16 09:58hgbotCheckin
2010-08-16 09:58hgbotNote Added: 0029981
2010-08-16 09:58hgbotStatusclosed => resolved
2010-08-16 09:58hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/8cd939863e92b1c21eafb8bfd0db0e21ae145379 [^] => http://code.openbravo.com/erp/devel/dbsm-main/rev/92af67d2294f797cdf39eec454807226fd59695c [^]
2010-08-17 16:04alostaleStatusresolved => closed
2010-08-18 00:00anonymoussf_bug_id0 => 3047308
2010-10-07 10:57rafarodaRelationship addedrelated to 0014623
2010-10-18 18:11networkbNote Added: 0031942
2010-10-18 18:11networkbStatusclosed => new
2010-10-18 18:11networkbResolutionfixed => open
2010-10-18 18:11networkbFixed in Version2.50MP21 =>
2010-10-19 09:30hgbotCheckin
2010-10-19 09:30hgbotNote Added: 0031949
2010-10-19 09:30hgbotStatusnew => resolved
2010-10-19 09:30hgbotResolutionopen => fixed
2010-10-19 09:30hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/dbsm-main/rev/92af67d2294f797cdf39eec454807226fd59695c [^] => http://code.openbravo.com/erp/devel/dbsm-main/rev/50937b15501ef2e2de657a6334ced0b620d9fdb1 [^]
2010-10-19 09:31hgbotCheckin
2010-10-19 09:31hgbotNote Added: 0031950
2010-10-19 09:31hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/dbsm-main/rev/50937b15501ef2e2de657a6334ced0b620d9fdb1 [^] => http://code.openbravo.com/erp/devel/pi/rev/eb105fcc44008f7e18144ba855fbb262103ea75a [^]
2010-10-19 20:12hudsonbotCheckin
2010-10-19 20:12hudsonbotNote Added: 0031991
2010-10-26 16:29shuehnerNote Added: 0032228
2010-10-26 16:29shuehnerStatusresolved => closed

Notes
(0029778)
hgbot   
2010-08-04 10:01   
Repository: erp/devel/pi
Changeset: 8cd939863e92b1c21eafb8bfd0db0e21ae145379
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Aug 04 09:59:13 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/8cd939863e92b1c21eafb8bfd0db0e21ae145379 [^]

Fixed issue 14091. RemoveCheckChanges will no longer fail if the table doesn't exist.
Also, changed the behaviour of ColumnSizeChanges so that an error message doesn't appear if the table or column do not exist.

---
M src-db/database/lib/dbsourcemanager.jar
---
(0029804)
hudsonbot   
2010-08-05 09:16   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/8cd939863e92 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/02ad8e3730d2 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18019.obx [^]
(0029981)
hgbot   
2010-08-16 09:58   
Repository: erp/devel/dbsm-main
Changeset: 92af67d2294f797cdf39eec454807226fd59695c
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Aug 04 09:58:42 2010 +0200
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/92af67d2294f797cdf39eec454807226fd59695c [^]

Fixed issue 14091. RemoveCheckChanges will no longer fail if the table doesn't exist.
Also, changed the behaviour of ColumnSizeChanges so that an error message doesn't appear if the table or column do not exist.

---
M src/org/apache/ddlutils/alteration/ColumnSizeChange.java
M src/org/apache/ddlutils/alteration/RemoveCheckChange.java
---
(0031942)
networkb   
2010-10-18 18:11   
The problem was solved when exporting, but not when updating.
The update.database.mod fails
(0031949)
hgbot   
2010-10-19 09:30   
Repository: erp/devel/dbsm-main
Changeset: 50937b15501ef2e2de657a6334ced0b620d9fdb1
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Oct 19 09:30:30 2010 +0200
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/50937b15501ef2e2de657a6334ced0b620d9fdb1 [^]

Fixed issue 14091. Return early also in RemoveCheckChange.apply() method.

---
M src/org/apache/ddlutils/alteration/RemoveCheckChange.java
---
(0031950)
hgbot   
2010-10-19 09:31   
Repository: erp/devel/pi
Changeset: eb105fcc44008f7e18144ba855fbb262103ea75a
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Oct 19 09:29:36 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/eb105fcc44008f7e18144ba855fbb262103ea75a [^]

Fixed issue 14091. Return early also in RemoveCheckChange.apply() method.

---
M src-db/database/lib/dbsourcemanager.jar
---
(0031991)
hudsonbot   
2010-10-19 20:12   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/eb105fcc4400 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/95c6f3deb9db [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18563.obx [^]
(0032228)
shuehner   
2010-10-26 16:29   
Reviewed and tested. Working fine now.
Note: the changed code is only used by the now (deprecated and unused) update.database.mod task.