Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0014045Openbravo ERPZ. Otherspublic2010-07-26 13:112010-07-29 00:00
Reportershuehner 
Assigned Tomirurita 
PriorityurgentSeveritycriticalReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Versionpi 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0014045: try api-check 79 fails
DescriptionThis (try) api-check build fails:

http://builds.openbravo.com/view/try/job/try-api/79/changes [^]

Two issues:
a.) Unique constraint added: table: FIN_FINACC_PAYMENTMETHOD - Unique constraint: FIN_FINACC_PAYMENTMETHOD_UN

b.) Changed column value AD_MESSAGE.VALUE -ID:968C37CD41AD45C3AD92D394CC357A90 from [FIN_FINACC_PAYMETHOD_UNIQUEKEY] to [FIN_FINACC_PAYMENTMETHOD_UN]
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-07-26 13:11shuehnerNew Issue
2010-07-26 13:11shuehnerAssigned To => mirurita
2010-07-26 13:11shuehnerOBNetwork customer => No
2010-07-26 13:14shuehnerNote Added: 0029556
2010-07-27 09:07pjuvaraStatusnew => scheduled
2010-07-27 09:07pjuvaraNote Added: 0029570
2010-07-27 09:07pjuvarafix_in_branch => pi
2010-07-27 10:49miruritaNote Added: 0029577
2010-07-27 10:49miruritaStatusscheduled => resolved
2010-07-27 10:49miruritaFixed in Version => pi
2010-07-27 10:49miruritaFixed in SCM revision => 6834c4694499
2010-07-27 10:49miruritaResolutionopen => fixed
2010-07-28 10:43miruritaStatusresolved => closed
2010-07-29 00:00anonymoussf_bug_id0 => 3036289

Notes
(0029556)
shuehner   
2010-07-26 13:14   
Changeset relevant for this build:
https://code.openbravo.com/erp/devel/try/rev/832c0e77063b [^]

a.) is a false positive, as can be seen in the changeset. In addition to create this unique constraint a unique-index with exactly the same definition was removed. The the restriction placed on the is identical -> no data problem -> false positive

b.) Changing of the 'name' of a ad_message entry. Is done to correspond to the unique-index -> unique-constraint move. Potential issue: someone using the old name manully. However this name/message is only (in core) for this specific constraint (with the same name) and i think its unlikely that its reused in any custom code.

Suggestion for b.) accept as change with low risk
(0029570)
pjuvara   
2010-07-27 09:07   
API change accepted.

Please send notice with risk level none.
(0029577)
mirurita   
2010-07-27 10:49   
Fixed on pi revision 7922:6834c4694499

https://code.openbravo.com/erp/devel/pi/rev/6834c4694499 [^]

and

api-checks repository
https://code.openbravo.com/erp/devel/api-checks/rev/0628a7ed4126 [^]