Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0014033Openbravo ERP07. Sales managementpublic2010-07-22 12:202010-08-19 00:00
Reporternetworkb 
Assigned Toadrianromero 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionsuspended 
PlatformOS5OS Version
Product Version2.50MP19 
Target Version2.50MP21Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0014033: The Address field keeps the value of the previous invoice
DescriptionThe Address field keep the value of the previous invoice. This error happens in Firefox.
Steps To Reproduce- Go to Sales Management || Transactions || Sales Invoice
- Create a new record (BP: McGiveer)
- Save and new.
- Realize that the Address field keeps the last value (talavera de la Reina...)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-07-22 12:20networkbNew Issue
2010-07-22 12:20networkbAssigned To => adrianromero
2010-07-22 12:20networkbOBNetwork customer => Yes
2010-07-22 17:01adrianromeroStatusnew => scheduled
2010-07-22 17:01adrianromerofix_in_branch => pi
2010-08-13 13:22adrianromeroNote Added: 0029952
2010-08-18 13:10adrianromeroNote Added: 0030113
2010-08-18 13:10adrianromeroStatusscheduled => closed
2010-08-18 13:10adrianromeroResolutionopen => suspended
2010-08-19 00:00anonymoussf_bug_id0 => 3048129

Notes
(0029952)
adrianromero   
2010-08-13 13:22   
To fill the locations list an SQL sentence is executed, and this sentence needs the Business Partner as a parameter

The error is in the code line https://code.openbravo.com/erp/devel/pi/file/3d3e7ced4ea6/src/org/openbravo/erpCommon/utility/Utility.java#l1378 [^] when reading the Business Partner ID parameter. Because the value is empty in the window then it is read from the session, and because the Business Partner ID is marked as stored in session and session values are not cleaned when pressing new, the list is filled incorrectly with the locations of the latest Business Partner.

The problem here is that all the behaviors described that are the cause of the error cannot be modified easily without breaking any other part of the application and raising several regression issues.
(0030113)
adrianromero   
2010-08-18 13:10   
All the possible solutions explored break the current functionality or are very risky.

* Removing the "In session" attribute of the Business Partner field is risky because this value is used in other parts of the window.
* Removing the validation of the locator field and let the callout fill in the locator does not work because the application will fill the field with all possible values.
* To hide the locator field when the business partner is empty does not have functional explanation and breaks the current behavior of the application.
* To change the behavior of functions in the Utility.java class is very risky because problems will appear in other parts of the application